Re: [Beignet] Status of cl_khr_gl_sharing

2017-08-07 Thread Yang, Rong R
The application is responsible for synchronizing access to shared objects. So I 
think only one thing
clEnqueueAcquire/ReleaseGLObjects to do is set the parameter event's status 
correctly.
I will implement them, and remove the other NOT_IMPLEMENTED functions.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Rebecca N. Palmer
> Sent: Friday, August 4, 2017 2:46 PM
> To: beignet@lists.freedesktop.org
> Subject: Re: [Beignet] Status of cl_khr_gl_sharing
> 
> The *missing* functions aren't likely to be a problem: as far as I can tell,
> http://sources.debian.net/src/forge/0.9.2-
> 2/examples/opencl/cl_helpers.h/?hl=72#L72
> is the only place in Debian that tries to use one of them, and it correctly 
> handles
> its absence.
> 
> I'm more worried about the potential consequences (if any) of
> clEnqueueAcquire/ReleaseGLObjects not actually doing anything.
> 
> ___
> Beignet mailing list
> Beignet@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/beignet







___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] Status of cl_khr_gl_sharing

2017-08-04 Thread Rebecca N. Palmer
The *missing* functions aren't likely to be a problem: as far as I can 
tell, 
http://sources.debian.net/src/forge/0.9.2-2/examples/opencl/cl_helpers.h/?hl=72#L72 
is the only place in Debian that tries to use one of them, and it 
correctly handles its absence.


I'm more worried about the potential consequences (if any) of 
clEnqueueAcquire/ReleaseGLObjects not actually doing anything.


___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] Status of cl_khr_gl_sharing

2017-08-03 Thread Yang, Rong R
Commit a892148 has re-implement this extension, use the 
eglExportDMABUFImageMESA and 
glGetTexLevelParameteriv to get sharing buffer's informatin.
Now it require the libEGL.so and libGL.so's version >= 13.0.

But this extension is partially implemented, only support 
clCreateFromGLTexture2D.

> -Original Message-
> From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of
> Simon Richter
> Sent: Thursday, August 3, 2017 12:28 AM
> To: beignet@lists.freedesktop.org
> Subject: Re: [Beignet] Status of cl_khr_gl_sharing
> 
> Hi,
> 
> On 01.08.2017 23:39, Rebecca N. Palmer wrote:
> 
> > As beignet's Debian maintainer, I am considering whether to enable
> > CL-GL sharing in our package, given its incomplete state.
> 
> I haven't looked at it since the initial package, because back then it 
> required the
> Mesa source code in order to get offsets into an internal structure.
> 
> If that has changed, I'd be totally in favour of enabling it, because we're 
> early in
> the buster cycle, so this is the time to get "new"
> features in.
> 
>Simon

___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


Re: [Beignet] Status of cl_khr_gl_sharing

2017-08-02 Thread Simon Richter
Hi,

On 01.08.2017 23:39, Rebecca N. Palmer wrote:

> As beignet's Debian maintainer, I am considering whether to enable CL-GL
> sharing in our package, given its incomplete state.

I haven't looked at it since the initial package, because back then it
required the Mesa source code in order to get offsets into an internal
structure.

If that has changed, I'd be totally in favour of enabling it, because
we're early in the buster cycle, so this is the time to get "new"
features in.

   Simon



signature.asc
Description: OpenPGP digital signature
___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet


[Beignet] Status of cl_khr_gl_sharing

2017-08-01 Thread Rebecca N. Palmer
As beignet's Debian maintainer, I am considering whether to enable CL-GL 
sharing in our package, given its incomplete state.


Fedora do enable it, and have a Blender crash bug 
https://bugs.freedesktop.org/show_bug.cgi?id=101779 , though as I can't 
reproduce this I can't tell whether disabling it would help.


src/sl_gl_api.c contains clEnqueueAcquire/ReleaseGLObjects which do 
nothing and return success, and are marked "XXX NULL function 
currently."  Is 'nothing' the correct thing for these to do on Intel 
hardware, or is this a potential problem?


___
Beignet mailing list
Beignet@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/beignet