Re: [SlimDevices: Beta] New in 7.9: "Don't Stop The Music"
mherger wrote:
> > do you think you could add Erland's *DynamicPlaylist* plugin to the
> > 'list of mix plugins that DSTM watches out for'
>
> Can you say what class and property name to look for? When does
> DynamicPlaylist kick in? How do they conflict? I'm surprised this only
> comes up now, as DSTM has been out for quite a while already.
Not sure this handles all cases, but Dynamic Playlist sets a client
property when is starts a playlist:
https://github.com/erland/lms-dynamicplaylist/blob/6a0c37c4d80e2ebeed307fc3620b757490186b76/src/Plugin.pm#L649
And removes the same property when it stops:
https://github.com/erland/lms-dynamicplaylist/blob/6a0c37c4d80e2ebeed307fc3620b757490186b76/src/Plugin.pm#L690
$prefs is initiated here:
https://github.com/erland/lms-dynamicplaylist/blob/6a0c37c4d80e2ebeed307fc3620b757490186b76/src/Plugin.pm#L51
I think looking for the playlist property should work in most cases. Im
not sure the property is removed if someone disconnect the power cable
but except for that I suspect its a fairly reliable way to detect if a
dynamic playlist is running. Please keep in mind that I wrote this code
a long time ago and might have interpreted it incorrect when looking at
it now, so someone should verify that it works if you implement this.
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)
*Starting with LMS 8.0 I no longer support my plugins/applets* ('see
here for more information'
(https://forums.slimdevices.com/showthread.php?49483-Announce-New-versions-of-erlands-plugins=998836=1#post998836)
)
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=105757
___
beta mailing list
beta@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] New in 7.9: "Don't Stop The Music"
RobbH wrote: > > afriend wrote: > > Michael, > > > > do you think you could add Erland's *DynamicPlaylist* plugin to the > > 'list of mix plugins that DSTM watches out for' > > (https://github.com/Logitech/slimserver/blob/7b30413bad6142b80de4a089c0786d41b0338554/Slim/Plugin/DontStopTheMusic/Plugin.pm#L177)? > > > > Please pardon this (very likely irrelevant) comment from a > > non-developer. I trust you are aware that a Dynamic Playlist mix that > > has been saved as a favorite can be used by DSTM?> > > > That's a misunderstanding. I'm not looking for DPL as a DSTM mixer. I > need DSTM to not hiijack active DPL mixes. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=105757 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] New in 7.9: "Don't Stop The Music"
mherger wrote:
> > do you think you could add Erland's *DynamicPlaylist* plugin to the
> > 'list of mix plugins that DSTM watches out for'
>
> Can you say what class and property name to look for? When does
> DynamicPlaylist kick in? How do they conflict? I'm surprised this only
> comes up now, as DSTM has been out for quite a while already.
So I'm not @erland who would be the one qualified to answer those
questions but my guess, maybe line 416/7:
Code:
if(defined($mixInfo{$masterClient}->{'type'})) {
my $playlist =
getPlayList($client,$mixInfo{$masterClient}->{'type'});
If type returns "disabled" then DPL is not active?
For me DPL behaves in many regards much like RandomPlay, except for
DSTM: when I start a RandomPlay mix and skip to the penultimate track,
DSTM doesn't take over. When I start a DPL mix and skip to the
penultimate track DSTM takes over and adds tracks.
It probably hasn't come up before because DSTM kicks in at the
penultimate track while (I think) the default DPL settings add tracks
earlier. So unless you skip very fast or change the default DPL settings
you probably won't notice this.
afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306
View this thread: http://forums.slimdevices.com/showthread.php?t=105757
___
beta mailing list
beta@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] New in 7.9: "Don't Stop The Music"
afriend wrote: > Michael, > > do you think you could add Erland's *DynamicPlaylist* plugin to the > 'list of mix plugins that DSTM watches out for' > (https://github.com/Logitech/slimserver/blob/7b30413bad6142b80de4a089c0786d41b0338554/Slim/Plugin/DontStopTheMusic/Plugin.pm#L177)? > > Please pardon this (very likely irrelevant) comment from a > non-developer. I trust you are aware that a Dynamic Playlist mix that > has been saved as a favorite can be used by DSTM? LMS 8 nightly running on Raspberry Pi OS. Mostly virtual players, occasionally with SB Radio, Boom or Classic. RobbH's Profile: http://forums.slimdevices.com/member.php?userid=67008 View this thread: http://forums.slimdevices.com/showthread.php?t=105757 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] New in 7.9: "Don't Stop The Music"
do you think you could add Erland's *DynamicPlaylist* plugin to the 'list of mix plugins that DSTM watches out for' Can you say what class and property name to look for? When does DynamicPlaylist kick in? How do they conflict? I'm surprised this only comes up now, as DSTM has been out for quite a while already. ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
Re: [SlimDevices: Beta] New in 7.9: "Don't Stop The Music"
Michael, do you think you could add Erland's *DynamicPlaylist* plugin to the 'list of mix plugins that DSTM watches out for' (https://github.com/Logitech/slimserver/blob/7b30413bad6142b80de4a089c0786d41b0338554/Slim/Plugin/DontStopTheMusic/Plugin.pm#L177)? Right now I think DSTM starts to load new tracks when the -penultimate- playlist track has started. The time that different mixers require to come up with the next batch of DSTM tracks varies, depending on hardware, what the mixer plugin does and such. Sometimes I wish I could set DSTM to load tracks *earlier* (like "5 tracks before the last one") to allow for slower response times or quick serial-skipping. An option for that would be great imho. Thank you. afriend's Profile: http://forums.slimdevices.com/member.php?userid=39306 View this thread: http://forums.slimdevices.com/showthread.php?t=105757 ___ beta mailing list beta@lists.slimdevices.com http://lists.slimdevices.com/mailman/listinfo/beta
