Re: Operational Notification: Some releases of BIND are too strict when handling referrals containing non-empty answer sections
Code refactoring is nothing compared to what Mozilla did to Firefox! It's hard to believe they didn't change the name, given that they totally changed the add-on interface and thereby removed so many of the features that made Firefox our browser of choice. On Thu, 20 Sep 2018 09:48:08 +0100 (BST) "G.W. Haywood via bind-users" wrote: > Hi there, > > On Wed, 19 Sep 2018, Michael McNally wrote: > > > ... code refactoring ... > > That phrase always sends shudders through my corpus. > ___ Please visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list bind-users mailing list bind-users@lists.isc.org https://lists.isc.org/mailman/listinfo/bind-users
Re: Operational Notification: Some releases of BIND are too strict when handling referrals containing non-empty answer sections
On Thu, Sep 20, 2018 at 09:48:08AM +0100, G.W. Haywood via bind-users wrote: > Hi there, > > On Wed, 19 Sep 2018, Michael McNally wrote: > > > ... code refactoring ... > > That phrase always sends shudders through my corpus. Some functions in the reply handling in the resolver, e.g., answer_response() before refactoring were responsible for multiple CVEs and IIRC even regressions introduced by fixes. Note that the bug now is not a CVE severity one. Such refactoring, though risky to do for evolved code, was necessary. Mukund ___ Please visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list bind-users mailing list bind-users@lists.isc.org https://lists.isc.org/mailman/listinfo/bind-users
Re: Operational Notification: Some releases of BIND are too strict when handling referrals containing non-empty answer sections
On Thu, Sep 20, 2018 at 11:28:46AM +0100, Tony Finch wrote: > G.W. Haywood via bind-users wrote: > > On Wed, 19 Sep 2018, Michael McNally wrote: > > > > > ... code refactoring ... > > > > That phrase always sends shudders through my corpus. > > I recommend having a read through query_find() from before 9.12. Be > warned it'll take a while, because the function is 2500 lines long. tis but a scratch ;-) Mukund ___ Please visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list bind-users mailing list bind-users@lists.isc.org https://lists.isc.org/mailman/listinfo/bind-users
Re: Operational Notification: Some releases of BIND are too strict when handling referrals containing non-empty answer sections
G.W. Haywood via bind-users wrote: > On Wed, 19 Sep 2018, Michael McNally wrote: > > > ... code refactoring ... > > That phrase always sends shudders through my corpus. I recommend having a read through query_find() from before 9.12. Be warned it'll take a while, because the function is 2500 lines long. https://gitlab.isc.org/isc-projects/bind9/blob/v9_11/bin/named/query.c#L6700 Tony. -- f.anthony.n.finchhttp://dotat.at/ Trafalgar: Southwesterly 4 or 5 in northwest, otherwise northerly 5 or 6. Moderate or rough. Fog patches in east. Moderate or good, occasionally very poor in east. ___ Please visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list bind-users mailing list bind-users@lists.isc.org https://lists.isc.org/mailman/listinfo/bind-users
Re: Operational Notification: Some releases of BIND are too strict when handling referrals containing non-empty answer sections
Hi there, On Wed, 19 Sep 2018, Michael McNally wrote: ... code refactoring ... That phrase always sends shudders through my corpus. -- 73, Ged. ___ Please visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list bind-users mailing list bind-users@lists.isc.org https://lists.isc.org/mailman/listinfo/bind-users
