Re: bird 2.14 segfault
Hello! Transfered to our internal issue tracker as a possible bug, gonna check it later. Thank you for reporting! https://gitlab.nic.cz/labs/bird/-/issues/30 Maria On 2024-02-08 10:26, ico wrote: I wanted to upgrade bird on router A from 1.6 to 2.14. As soon as new bird started up on A, almost all of B, C, etc. started crashing. Today I started to look into this. I found out I messed up the configuration on router A, I didn't filter out all routes from BGP and all those prefixes (IPv4 only, ~100k) were exported to OSPF. The bird on router A handled it quite OK, but routers B, C, etc. segfaulted after few seconds of exporting all those prefixes to kernel. And that happened repeatedly after bird started again. And again.. In bird's log file I found nothing. In system log were 2 lines for each segfault: [Thu Feb 1 01:51:10 2024] bird[23724]: segfault at 7ffe0e092ff8 ip 7f2c4fb219a7 sp 7ffe0e093000 error 6 in libc-2.33.so[7f2c4fabe000+15e000] [Thu Feb 1 01:51:10 2024] Code: 48 89 d9 49 8b 7f 28 49 8b 5f 30 48 39 df 73 bf 48 29 fb 4c 39 f3 49 0f 47 de 48 83 fb 14 76 a3 48 89 ce 48 89 da 48 89 0c 24 f4 c8 f9 ff 48 8b 0c 24 49 89 47 28 48 01 d9 eb 90 0f 1f 80 00 I will try again to upgrade router A without all those prefixes exported to OSPF, that should work I believe. I am not good at this, but maybe someone could use this information to find a bug somewhere in bird. Maybe I can help and try something with the same failing setup? -- Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.
Re: BIRD 2.14
Hi, I want to add that I had the same problem with building bird master branch some time ago for our Arista switches. I also found that reverting f8bcb037b5b71a19209f1b63d52895c8c34c675b helps and maked the build successful. But we did not try it in production yet. Unfortunately, upgrading the kernel is not an option there, as the whole system is proprietary. As far as I know it is based on some Fedora and we have 4.9.* kernel there. Regards, Alexander On Mon, Oct 9, 2023 at 12:19 AM Ondrej Zajicek wrote: > > On Sun, Oct 08, 2023 at 11:47:42PM +0200, Robert Scheck wrote: > > > >>Or you can try to revert commit > > > >>d61505b039bf0aa6697e28b2a4e07907c89ba1fb. I > > > >>can't guarantee it working out of the box, though. > > > >Or rather f8bcb037b5b71a19209f1b63d52895c8c34c675b > > > > > > Oh sorry, messed up two commits from the same person, mea culpa. You're > > > right, disregard my hash, please. > > > > https://gitlab.nic.cz/labs/bird/-/commit/f8bcb037b5b71a19209f1b63d52895c8c34c675b > > let's the build succeed. As there is no MPLS support in CentOS/RHEL 7...do > > you treat reverting this commit only for this build target as very risky or > > problematic (without an in-depth analysis, just from your feeling)? > > Reverting this patch for CentOS is safe. > > -- > Elen sila lumenn' omentielvo > > Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) > OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) > "To err is human -- to blame it on a computer is even more so."
Re: BIRD 2.14
On Sun, Oct 08, 2023 at 11:47:42PM +0200, Robert Scheck wrote: > > >>Or you can try to revert commit d61505b039bf0aa6697e28b2a4e07907c89ba1fb. > > >>I > > >>can't guarantee it working out of the box, though. > > >Or rather f8bcb037b5b71a19209f1b63d52895c8c34c675b > > > > Oh sorry, messed up two commits from the same person, mea culpa. You're > > right, disregard my hash, please. > > https://gitlab.nic.cz/labs/bird/-/commit/f8bcb037b5b71a19209f1b63d52895c8c34c675b > let's the build succeed. As there is no MPLS support in CentOS/RHEL 7...do > you treat reverting this commit only for this build target as very risky or > problematic (without an in-depth analysis, just from your feeling)? Reverting this patch for CentOS is safe. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Re: BIRD 2.14
Hello Maria, hello Ondrej, On Sun, 08 Oct 2023, Maria Matejka wrote: > On 2023-10-08 23:06, Ondrej Zajicek wrote: > >On Sun, Oct 08, 2023 at 10:18:24PM +0200, Maria Matejka via Bird-users wrote: > >>Sorry, support for CentOS / RHEL 7 has been discontinued due to a too old > >>kernel version and backwards-incompatible Netlink changes. I think the > >>easiest way would be to add a dependency on a newer kernel, e.g. kernel-lt > >>which is now afaik 5.4 (supported). For EPEL, I only can depend on packages in RHEL itself (or in EPEL). > >>Or you can try to revert commit d61505b039bf0aa6697e28b2a4e07907c89ba1fb. I > >>can't guarantee it working out of the box, though. > >Or rather f8bcb037b5b71a19209f1b63d52895c8c34c675b > > Oh sorry, messed up two commits from the same person, mea culpa. You're > right, disregard my hash, please. https://gitlab.nic.cz/labs/bird/-/commit/f8bcb037b5b71a19209f1b63d52895c8c34c675b let's the build succeed. As there is no MPLS support in CentOS/RHEL 7...do you treat reverting this commit only for this build target as very risky or problematic (without an in-depth analysis, just from your feeling)? As of writing, BIRD 2.13.1 works on the stock CentOS/RHEL 7 kernel (at least for a simple BGP setup). Regards, Robert
Re: BIRD 2.14
On 2023-10-08 23:06, Ondrej Zajicek wrote:
On Sun, Oct 08, 2023 at 10:18:24PM +0200, Maria Matejka via Bird-users wrote:
Hello Robert,
On 2023-10-08 21:40, Robert Scheck wrote:
Unfortunately, building BIRD 2.14 on CentOS/RHEL 7 fails like this:
sysdep/linux/netlink.c: In function 'rta_get_via':
sysdep/linux/netlink.c:499:11: error: dereferencing pointer to incomplete type
'struct rtvia'
switch(v->rtvia_family) {
^~
While I assume that the kernel in CentOS/RHEL 7 is simply too old to
support the desired functionality in BIRD, is at least possible to have
the change #ifdef'ed (or so), that it builds without the new feature?
Sorry, support for CentOS / RHEL 7 has been discontinued due to a too old
kernel version and backwards-incompatible Netlink changes. I think the
easiest way would be to add a dependency on a newer kernel, e.g. kernel-lt
which is now afaik 5.4 (supported).
Or you can try to revert commit d61505b039bf0aa6697e28b2a4e07907c89ba1fb. I
can't guarantee it working out of the box, though.
Or rather f8bcb037b5b71a19209f1b63d52895c8c34c675b
Oh sorry, messed up two commits from the same person, mea culpa. You're
right, disregard my hash, please.
Thank you for correcting me.
Maria
--
Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.
Re: BIRD 2.14
On Sun, Oct 08, 2023 at 10:18:24PM +0200, Maria Matejka via Bird-users wrote:
> Hello Robert,
>
> On 2023-10-08 21:40, Robert Scheck wrote:
> > Unfortunately, building BIRD 2.14 on CentOS/RHEL 7 fails like this:
> >
> > > sysdep/linux/netlink.c: In function 'rta_get_via':
> > > sysdep/linux/netlink.c:499:11: error: dereferencing pointer to incomplete
> > > type 'struct rtvia'
> > > switch(v->rtvia_family) {
> > > ^~
> > While I assume that the kernel in CentOS/RHEL 7 is simply too old to
> > support the desired functionality in BIRD, is at least possible to have
> > the change #ifdef'ed (or so), that it builds without the new feature?
>
> Sorry, support for CentOS / RHEL 7 has been discontinued due to a too old
> kernel version and backwards-incompatible Netlink changes. I think the
> easiest way would be to add a dependency on a newer kernel, e.g. kernel-lt
> which is now afaik 5.4 (supported).
>
> Or you can try to revert commit d61505b039bf0aa6697e28b2a4e07907c89ba1fb. I
> can't guarantee it working out of the box, though.
Or rather f8bcb037b5b71a19209f1b63d52895c8c34c675b
--
Elen sila lumenn' omentielvo
Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
Re: BIRD 2.14
Hello Robert,
On 2023-10-08 21:40, Robert Scheck wrote:
Unfortunately, building BIRD 2.14 on CentOS/RHEL 7 fails like this:
sysdep/linux/netlink.c: In function 'rta_get_via':
sysdep/linux/netlink.c:499:11: error: dereferencing pointer to incomplete type
'struct rtvia'
switch(v->rtvia_family) {
^~
While I assume that the kernel in CentOS/RHEL 7 is simply too old to
support the desired functionality in BIRD, is at least possible to have
the change #ifdef'ed (or so), that it builds without the new feature?
Sorry, support for CentOS / RHEL 7 has been discontinued due to a too
old kernel version and backwards-incompatible Netlink changes. I think
the easiest way would be to add a dependency on a newer kernel, e.g.
kernel-lt which is now afaik 5.4 (supported).
Or you can try to revert commit
d61505b039bf0aa6697e28b2a4e07907c89ba1fb. I can't guarantee it working
out of the box, though.
Rober
--
Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.
Re: BIRD 2.14
On Sat, 07 Oct 2023, Ondrej Filip wrote:
> Version 2.14
> o MPLS subsystem
> o L3VPN: BGP/MPLS VPNs (RFC 4364)
> o BGP: Access to unknown route attributes
> o RAdv: Custom options
> o Babel: RTT metric extension
> o BMP: Refactored route monitoring
> o BMP: Multiple instances of BMP protocol
> o BMP: Both pre-policy and post-policy monitoring
> o Experimental route aggregation
> o Filter: Method framework
> o Filter: Functions have return type statements
> o Filter: New bytestring data type
> o Kernel: Option to learn kernel routes
> o Many bugfixes and improvements
Unfortunately, building BIRD 2.14 on CentOS/RHEL 7 fails like this:
> sysdep/linux/netlink.c: In function 'rta_get_via':
> sysdep/linux/netlink.c:499:11: error: dereferencing pointer to incomplete
> type 'struct rtvia'
>switch(v->rtvia_family) {
>^~
While I assume that the kernel in CentOS/RHEL 7 is simply too old to
support the desired functionality in BIRD, is at least possible to have
the change #ifdef'ed (or so), that it builds without the new feature?
https://kojipkgs.fedoraproject.org/work/tasks/7281/107237281/build.log
contains the full build log for EPEL in case it helps somehow.
Regards,
Robert
Re: BIRD 2.14
On 07. 10. 23 15:26, İlteriş Yağıztegin Eroğlu via Bird-users wrote: Hi Ondrej, Fixed! Ondrej Looks like the git tag for v2.14 hasn't been pushed to CZ.NIC GitLab. Can that be done? - ilteris On 7.10.2023 15:10, Ondrej Filip wrote: Dear BIRD users, we're releasing a new version 2.14. I thank my colleagues for this this. OpenPGP_signature.asc Description: OpenPGP digital signature
Re: BIRD 2.14
Hi Ondrej, Looks like the git tag for v2.14 hasn't been pushed to CZ.NIC GitLab. Can that be done? - ilteris On 7.10.2023 15:10, Ondrej Filip wrote: > Dear BIRD users, > we're releasing a new version 2.14. I thank my colleagues for this this.
