Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Chris Harrelson 
LGTM3

On Thu, Sep 2, 2021 at 10:10 AM Mike West  wrote:

> LGTM2. I agree that this is a tiny ergonomic change, and matching Safari's
> behavior (with Mozilla's positive signals) should increase interop in the
> future.
>
> -mike
>
>
> On Thu, Sep 2, 2021 at 3:39 PM Yoav Weiss  wrote:
>
>> LGTM1
>>
>> This seems like a small addition to improve the platform's consistency.
>>
>> On Thu, Sep 2, 2021 at 2:57 PM Frédéric Wang  wrote:
>>
>>> Le 02/09/2021 à 13:46, Yoav Weiss a écrit :
>>>
>>>
>>> The motivation section brings up use cases that this would make easier,
>>> but it's not super clear what they are, and if developers feel they are
>>> important. I wondered if this is something you have evidence for.
>>> With that said, now that I understand what you're trying to ship,
>>> consistency can also be an argument for such a change.
>>>
>>>
>>> As I said one can already do that with EventTarget.addEventListener so
>>> it is not critical at all for developers. But things like
>>> EventTarget.onload = ... and  are pretty common, and
>>> it would be surprising for developers if this does not work for all events.
>>> But yes, again this is just speculation, not based on any concrete feedback
>>> from developers. I imagine somewhat hitting the problem would just switch
>>> to addEventListener and move on.
>>>
>>> --
>>> Frédéric Wang
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "blink-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to blink-dev+unsubscr...@chromium.org.
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/548bb454-41d4-9b8d-0706-ea3d1ca4138b%40igalia.com
>>> 
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU4bkkHJWLm-O%2BqztmJjS8N4XykQe0g%2BxMrkiLGzm3MPg%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfHD-GHZZOzookXU5UXk53Yzy9sEN8DO_iMAMHLEJA84Q%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-HoDShJuvWZS%2BLq%2BBC7kNjU5B5ALCf2T1ywM_Lit2VEw%40mail.gmail.com.

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Mike West 
LGTM2. I agree that this is a tiny ergonomic change, and matching Safari's
behavior (with Mozilla's positive signals) should increase interop in the
future.

-mike


On Thu, Sep 2, 2021 at 3:39 PM Yoav Weiss  wrote:

> LGTM1
>
> This seems like a small addition to improve the platform's consistency.
>
> On Thu, Sep 2, 2021 at 2:57 PM Frédéric Wang  wrote:
>
>> Le 02/09/2021 à 13:46, Yoav Weiss a écrit :
>>
>>
>> The motivation section brings up use cases that this would make easier,
>> but it's not super clear what they are, and if developers feel they are
>> important. I wondered if this is something you have evidence for.
>> With that said, now that I understand what you're trying to ship,
>> consistency can also be an argument for such a change.
>>
>>
>> As I said one can already do that with EventTarget.addEventListener so it
>> is not critical at all for developers. But things like EventTarget.onload =
>> ... and  are pretty common, and it would be
>> surprising for developers if this does not work for all events. But yes,
>> again this is just speculation, not based on any concrete feedback from
>> developers. I imagine somewhat hitting the problem would just switch to
>> addEventListener and move on.
>>
>> --
>> Frédéric Wang
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/548bb454-41d4-9b8d-0706-ea3d1ca4138b%40igalia.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU4bkkHJWLm-O%2BqztmJjS8N4XykQe0g%2BxMrkiLGzm3MPg%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfHD-GHZZOzookXU5UXk53Yzy9sEN8DO_iMAMHLEJA84Q%40mail.gmail.com.

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Yoav Weiss 
LGTM1

This seems like a small addition to improve the platform's consistency.

On Thu, Sep 2, 2021 at 2:57 PM Frédéric Wang  wrote:

> Le 02/09/2021 à 13:46, Yoav Weiss a écrit :
>
>
> The motivation section brings up use cases that this would make easier,
> but it's not super clear what they are, and if developers feel they are
> important. I wondered if this is something you have evidence for.
> With that said, now that I understand what you're trying to ship,
> consistency can also be an argument for such a change.
>
>
> As I said one can already do that with EventTarget.addEventListener so it
> is not critical at all for developers. But things like EventTarget.onload =
> ... and  are pretty common, and it would be
> surprising for developers if this does not work for all events. But yes,
> again this is just speculation, not based on any concrete feedback from
> developers. I imagine somewhat hitting the problem would just switch to
> addEventListener and move on.
>
> --
> Frédéric Wang
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/548bb454-41d4-9b8d-0706-ea3d1ca4138b%40igalia.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU4bkkHJWLm-O%2BqztmJjS8N4XykQe0g%2BxMrkiLGzm3MPg%40mail.gmail.com.

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Frédéric Wang 

Le 02/09/2021 à 13:46, Yoav Weiss a écrit :


The motivation section brings up use cases that this would make 
easier, but it's not super clear what they are, and if developers feel 
they are important. I wondered if this is something you have evidence for.
With that said, now that I understand what you're trying to ship, 
consistency can also be an argument for such a change.


As I said one can already do that with EventTarget.addEventListener so 
it is not critical at all for developers. But things like 
EventTarget.onload = ... and  are pretty common, 
and it would be surprising for developers if this does not work for all 
events. But yes, again this is just speculation, not based on any 
concrete feedback from developers. I imagine somewhat hitting the 
problem would just switch to addEventListener and move on.


--
Frédéric Wang

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/548bb454-41d4-9b8d-0706-ea3d1ca4138b%40igalia.com.

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Yoav Weiss 
On Thu, Sep 2, 2021 at 1:18 PM Frédéric Wang  wrote:

> Le 02/09/2021 à 12:15, Yoav Weiss a écrit :
>
>
> An actual explainer that outlines what the feature does, and its developer
> and user benefits would be helpful for reviewing this.
>
> Just to clarify, the slotchange event is already implemented in all
> browsers, one can find document on MDN [1] [2]. But  is used by
> developers as a placeholder for custom DOM tree in Web Components and the
> slot change event is dispatched when such a substree changes. Typically,
> the JS code of the web component will listen to slotchange events and react
> with necessary updates.
>
> As Sonia explained in the motivation, one could just use addEventListener,
> but for convenience and consistency with other events (e.g. load) it makes
> sense to add a IDL onslotchange attribute... which also reflect the
> attribute on elements. And because web components typically put their
> contents in a ShadowRoot, it makes sense to be able to place the listener
> on that root.
>
> (note: I'm not really an expert on web components, probably people who are
> more familiar can explain better the motivation)
>
OK, thanks for clarifying what this intent is aiming to ship.

>
>
>
>> TAG review
>>
>> TAG review status
>> Not applicable
>
>
> Can you explain why is a TAG review not applicable?
>
> This is just a small change to an existing spec implemented in browsers
> and it was discussed at WHATWG (see the link provided by Sonia). When is a
> TAG review typically required?
>

OK, I agree that since this is following a well-known and established
pattern, a TAG review is most-probably an overkill.

>
>
>>
>>
>> Risks
>>
>> Interoperability and Compatibility
>>
>> Gecko:
>> Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1501983)
>>
>>
>> WebKit:
>> Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=191310)
>>
>>
>> Incidentally, Sonia landed her patch so this is now shipped in WebKit and
> Firefox.
>
> Web developers:
>> No signals
>
>
> Could you gather signals? https://goo.gle/developer-signals
>
> We were not able to find much information from
> https://github.com/whatwg/html/issues/3487 ; I think Sonia meant to use
> N/A "The change is too small to justify this effort".
>

The motivation section brings up use cases that this would make easier, but
it's not super clear what they are, and if developers feel they are
important. I wondered if this is something you have evidence for.
With that said, now that I understand what you're trying to ship,
consistency can also be an argument for such a change.


> --
>
> Frédéric Wang
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ce90f246-e1f9-ce3f-9bcc-efdeca45cb01%40igalia.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfX06kfvQqd5LQhbg_p6qgSZuQF9fT-GoB-CF9nD35Zn7g%40mail.gmail.com.

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Frédéric Wang 

Le 02/09/2021 à 12:15, Yoav Weiss a écrit :


An actual explainer that outlines what the feature does, and its 
developer and user benefits would be helpful for reviewing this.


Just to clarify, the slotchange event is already implemented in all 
browsers, one can find document on MDN [1] [2]. But  is used by 
developers as a placeholder for custom DOM tree in Web Components and 
the slot change event is dispatched when such a substree changes. 
Typically, the JS code of the web component will listen to slotchange 
events and react with necessary updates.


As Sonia explained in the motivation, one could just use 
addEventListener, but for convenience and consistency with other events 
(e.g. load) it makes sense to add a IDL onslotchange attribute... which 
also reflect the attribute on elements. And because web components 
typically put their contents in a ShadowRoot, it makes sense to be able 
to place the listener on that root.


(note: I'm not really an expert on web components, probably people who 
are more familiar can explain better the motivation)




TAG review

TAG review status
Not applicable


Can you explain why is a TAG review not applicable?


This is just a small change to an existing spec implemented in browsers 
and it was discussed at WHATWG (see the link provided by Sonia). When is 
a TAG review typically required?





Risks

Interoperability and Compatibility

Gecko:
Positive (https://bugzilla.mozilla.org/show_bug.cgi?id=1501983
)


WebKit:
Shipped/Shipping (https://bugs.webkit.org/show_bug.cgi?id=191310
)


Incidentally, Sonia landed her patch so this is now shipped in WebKit 
and Firefox.



Web developers:
No signals


Could you gather signals? https://goo.gle/developer-signals


We were not able to find much information from 
https://github.com/whatwg/html/issues/3487 ; I think Sonia meant to use 
N/A "The change is too small to justify this effort".


--

Frédéric Wang

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ce90f246-e1f9-ce3f-9bcc-efdeca45cb01%40igalia.com.