[brlcad-commits] SF.net SVN: brlcad:[33558] brlcad/trunk/src
Revision: 33558
http://brlcad.svn.sourceforge.net/brlcad/?rev=33558&view=rev
Author: bob1961
Date: 2009-01-14 21:29:56 + (Wed, 14 Jan 2009)
Log Message:
---
Added "more args" behavior to libged's ged_3ptarb and modified MGED to use it.
Modified Paths:
--
brlcad/trunk/src/libged/3ptarb.c
brlcad/trunk/src/mged/cmd.c
brlcad/trunk/src/mged/cmd.h
brlcad/trunk/src/mged/setup.c
Modified: brlcad/trunk/src/libged/3ptarb.c
===
--- brlcad/trunk/src/libged/3ptarb.c2009-01-14 18:28:50 UTC (rev 33557)
+++ brlcad/trunk/src/libged/3ptarb.c2009-01-14 21:29:56 UTC (rev 33558)
@@ -33,6 +33,18 @@
#include "rtgeom.h"
#include "ged_private.h"
+static char *p_arb3pt[] = {
+"Enter X, Y, Z for point 1: ",
+"Enter Y, Z: ",
+"Enter Z: ",
+"Enter X, Y, Z for point 2: ",
+"Enter Y, Z: ",
+"Enter Z: ",
+"Enter X, Y, Z for point 3: ",
+"Enter Y, Z: ",
+"Enter Z: "
+};
+
int
ged_3ptarb(struct ged *gedp, int argc, const char *argv[])
{
@@ -42,6 +54,7 @@
fastf_tpt4[2], length, thick;
vect_t norm;
fastf_tndotv;
+char **prompts;
struct directory *dp;
struct rt_db_internal internal;
struct rt_arb_internal *aip;
@@ -54,22 +67,36 @@
/* initialize result */
bu_vls_trunc(&gedp->ged_result_str, 0);
+#if 0
/* must be wanting help */
if (argc == 1) {
bu_vls_printf(&gedp->ged_result_str, "Usage: %s %s", argv[0], usage);
return BRLCAD_HELP;
}
+#endif
-if (argc != 15) {
+if (argc > 15) {
bu_vls_printf(&gedp->ged_result_str, "Usage: %s %s", argv[0], usage);
return BRLCAD_ERROR;
}
+if (argc < 2) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter name for this arb: ");
+ return BRLCAD_MORE_ARGS;
+}
+
if ( db_lookup( gedp->ged_wdbp->dbip, argv[1], LOOKUP_QUIET) != DIR_NULL )
{
bu_vls_printf(&gedp->ged_result_str, "%s: %s already exists\n",
argv[0], argv[1]);
return BRLCAD_ERROR;
}
+/* read the three points */
+prompts = &p_arb3pt[0];
+if (argc < 11) {
+ bu_vls_printf(&gedp->ged_result_str, prompts[argc-2]);
+ return BRLCAD_MORE_ARGS;
+}
+
/* preliminary calculations to check input so far */
for (i=0; i<3; i++) {
vec1[i] = atof(argv[i+2]) - atof(argv[i+5]);
@@ -83,6 +110,11 @@
}
VSCALE(norm, norm, 1.0/length);
+if (argc < 12) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter coordinate to solve for (x,
y, or z): ");
+ return BRLCAD_MORE_ARGS;
+}
+
switch (argv[11][0]) {
case 'x':
if (norm[0] == 0.0) {
@@ -91,6 +123,15 @@
}
solve = X;
+ if (argc < 13) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter the Y, Z coordinate
values: ");
+ return BRLCAD_MORE_ARGS;
+ }
+ if (argc < 14) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter the Z coordinate
value: ");
+ return BRLCAD_MORE_ARGS;
+ }
+
pt4[0] = atof( argv[12] ) * gedp->ged_wdbp->dbip->dbi_local2base;
pt4[1] = atof( argv[13] ) * gedp->ged_wdbp->dbip->dbi_local2base;
break;
@@ -102,6 +143,15 @@
}
solve = Y;
+ if (argc < 13) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter the X, Z coordinate
values: ");
+ return BRLCAD_MORE_ARGS;
+ }
+ if (argc < 14) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter the Z coordinate
value: ");
+ return BRLCAD_MORE_ARGS;
+ }
+
pt4[0] = atof( argv[12] ) * gedp->ged_wdbp->dbip->dbi_local2base;
pt4[1] = atof( argv[13] ) * gedp->ged_wdbp->dbip->dbi_local2base;
break;
@@ -113,6 +163,15 @@
}
solve = Z;
+ if (argc < 13) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter the X, Y coordinate
values: ");
+ return BRLCAD_MORE_ARGS;
+ }
+ if (argc < 14) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter the Y coordinate
value: ");
+ return BRLCAD_MORE_ARGS;
+ }
+
pt4[0] = atof( argv[12] ) * gedp->ged_wdbp->dbip->dbi_local2base;
pt4[1] = atof( argv[13] ) * gedp->ged_wdbp->dbip->dbi_local2base;
break;
@@ -122,6 +181,11 @@
return BRLCAD_ERROR;
}
+if (argc < 15) {
+ bu_vls_printf(&gedp->ged_result_str, "Enter thickness for this arb: ");
+ return BRLCAD_MORE_ARGS;
+}
+
if ((thick = (atof( argv[14] ))) == 0.0) {
bu_vls_printf(&gedp->ged_result_str, "%s: thickness = 0.0\n", argv[0]);
return BRLCAD_ERROR;
Modified: brlcad/trunk/src/mged/cmd.c
===
[brlcad-commits] SF.net SVN: brlcad:[33557] brlcad/trunk/BUGS
Revision: 33557 http://brlcad.svn.sourceforge.net/brlcad/?rev=33557&view=rev Author: brlcad Date: 2009-01-14 18:28:50 + (Wed, 14 Jan 2009) Log Message: --- make extrude no longer crashes, bot values display with local units Modified Paths: -- brlcad/trunk/BUGS Modified: brlcad/trunk/BUGS === --- brlcad/trunk/BUGS 2009-01-14 18:24:44 UTC (rev 33556) +++ brlcad/trunk/BUGS 2009-01-14 18:28:50 UTC (rev 33557) @@ -113,9 +113,6 @@ * overlap tool in mged encourages very inefficient CSG operations (e.g. a simple bolt with an entire hull armor subtracted) -* BoT values are always listed in mm when a point is selected instead - of in current editing units. - * a character is (still) sometimes captured by the cursor box * permute (in mged) requires apply or save before 'new' vertex values @@ -237,8 +234,6 @@ * report of rtwizard hanging at 40% on Debian (from binary distro) -* make extrude crashes - * tra in console mode outputs a warning about mged_players * mged primitive editor doesn't accept/apply values to disk for This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33556] brlcad/trunk/src/libtclcad/ged_obj.c
Revision: 33556 http://brlcad.svn.sourceforge.net/brlcad/?rev=33556&view=rev Author: bob1961 Date: 2009-01-14 18:24:44 + (Wed, 14 Jan 2009) Log Message: --- Minor mod. Modified Paths: -- brlcad/trunk/src/libtclcad/ged_obj.c Modified: brlcad/trunk/src/libtclcad/ged_obj.c === --- brlcad/trunk/src/libtclcad/ged_obj.c2009-01-14 18:23:57 UTC (rev 33555) +++ brlcad/trunk/src/libtclcad/ged_obj.c2009-01-14 18:24:44 UTC (rev 33556) @@ -5008,7 +5008,7 @@ bu_vls_free(&temp); for (i = 0; i < ac; ++i) - bu_free((void *)av[i], "go_in"); + bu_free((void *)av[i], "go_more_args_func"); return ret; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33555] brlcad/trunk/NEWS
Revision: 33555 http://brlcad.svn.sourceforge.net/brlcad/?rev=33555&view=rev Author: bob1961 Date: 2009-01-14 18:23:57 + (Wed, 14 Jan 2009) Log Message: --- Updates to reflect change in MGED's "inside" command. Modified Paths: -- brlcad/trunk/NEWS Modified: brlcad/trunk/NEWS === --- brlcad/trunk/NEWS 2009-01-14 17:35:39 UTC (rev 33554) +++ brlcad/trunk/NEWS 2009-01-14 18:23:57 UTC (rev 33555) @@ -14,6 +14,8 @@ --- 2008-XX-XX Release 7.XX.X --- -- +* mged's inside command no longer uses the geometry currently being + edited for the outside solid - Bob Parker * reported and fixed mged documentation eto typein bug - Robert Penny * fixed mged itcl.tcl startup failure prior to install - Sean Morrison * fixed bot_dump -u command line option for setting units - Bob Parker This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33554] brlcad/trunk
Revision: 33554
http://brlcad.svn.sourceforge.net/brlcad/?rev=33554&view=rev
Author: brlcad
Date: 2009-01-14 17:35:39 + (Wed, 14 Jan 2009)
Log Message:
---
mged should read just fine from stdin now with the handful of trickeries going
on. this also fixes one remaining bug when reading in from stdin via gets --
was getting an error of: can't rename to "execute_cmd_save": command already
exists
Modified Paths:
--
brlcad/trunk/BUGS
brlcad/trunk/src/tclscripts/mged/text.tcl
Modified: brlcad/trunk/BUGS
===
--- brlcad/trunk/BUGS 2009-01-14 17:29:42 UTC (rev 33553)
+++ brlcad/trunk/BUGS 2009-01-14 17:35:39 UTC (rev 33554)
@@ -151,11 +151,6 @@
button many times quickly, or running rtarea on a large model) that
output a lot of data will hang mged (idle cpu utilization).
-* mged in console mode goes into an inf loop if you try to read from
- stdin using Tcl routines (e.g. read stdin, fgets stdin blah).
-
-* mged in GUI mode rejects reads on stdin
-
* solids.sh regression test fails on Mac OS X with one pixel
off-by-many on the edge of the middle ARB8 when using an optimized
-O3 compile (-fno-unsafe-math-optimizations makes no difference)
Modified: brlcad/trunk/src/tclscripts/mged/text.tcl
===
--- brlcad/trunk/src/tclscripts/mged/text.tcl 2009-01-14 17:29:42 UTC (rev
33553)
+++ brlcad/trunk/src/tclscripts/mged/text.tcl 2009-01-14 17:35:39 UTC (rev
33554)
@@ -290,6 +290,7 @@
# the entire input, then we strip off the gets line leaving just
# the line that was input. total hack. total fugly hack.
+proc execute_cmd_save {} {}
rename execute_cmd execute_cmd_save
rename gets_execute_cmd execute_cmd
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
___
BRL-CAD Source Commits mailing list
brlcad-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33553] brlcad/trunk/misc/win32-msvc8
Revision: 33553 http://brlcad.svn.sourceforge.net/brlcad/?rev=33553&view=rev Author: bob1961 Date: 2009-01-14 17:29:42 + (Wed, 14 Jan 2009) Log Message: --- Updates to get things compiling on Windows. Modified Paths: -- brlcad/trunk/misc/win32-msvc8/fence/fence.vcproj brlcad/trunk/misc/win32-msvc8/mged/mged.vcproj brlcad/trunk/misc/win32-msvc8/picket_fence/picket_fence.vcproj brlcad/trunk/misc/win32-msvc8/tire/tire.vcproj Modified: brlcad/trunk/misc/win32-msvc8/fence/fence.vcproj === --- brlcad/trunk/misc/win32-msvc8/fence/fence.vcproj2009-01-14 17:26:58 UTC (rev 33552) +++ brlcad/trunk/misc/win32-msvc8/fence/fence.vcproj2009-01-14 17:29:42 UTC (rev 33553) @@ -222,7 +222,7 @@ Filter="cpp;c;cxx;rc;def;r;odl;idl;hpj;bat;f90;for;f;fpp" > Modified: brlcad/trunk/misc/win32-msvc8/mged/mged.vcproj === --- brlcad/trunk/misc/win32-msvc8/mged/mged.vcproj 2009-01-14 17:26:58 UTC (rev 33552) +++ brlcad/trunk/misc/win32-msvc8/mged/mged.vcproj 2009-01-14 17:29:42 UTC (rev 33553) @@ -226,10 +226,6 @@ > - - @@ -350,10 +346,6 @@ > - - @@ -398,10 +390,6 @@ > - - @@ -438,10 +426,6 @@ > - - Modified: brlcad/trunk/misc/win32-msvc8/picket_fence/picket_fence.vcproj === --- brlcad/trunk/misc/win32-msvc8/picket_fence/picket_fence.vcproj 2009-01-14 17:26:58 UTC (rev 33552) +++ brlcad/trunk/misc/win32-msvc8/picket_fence/picket_fence.vcproj 2009-01-14 17:29:42 UTC (rev 33553) @@ -78,7 +78,7 @@ /> Modified: brlcad/trunk/misc/win32-msvc8/tire/tire.vcproj === --- brlcad/trunk/misc/win32-msvc8/tire/tire.vcproj 2009-01-14 17:26:58 UTC (rev 33552) +++ brlcad/trunk/misc/win32-msvc8/tire/tire.vcproj 2009-01-14 17:29:42 UTC (rev 33553) @@ -78,7 +78,7 @@ /> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33552] brlcad/trunk/BUGS
Revision: 33552 http://brlcad.svn.sourceforge.net/brlcad/?rev=33552&view=rev Author: brlcad Date: 2009-01-14 17:26:58 + (Wed, 14 Jan 2009) Log Message: --- pipe primitive no longer calls dynamic allocation during run-time thanks to john. remove the lingering default doesn't work (because it seems to work just fine and that code has changed a fair bit). also, rtwizard seems to be working just fine now too. Modified Paths: -- brlcad/trunk/BUGS Modified: brlcad/trunk/BUGS === --- brlcad/trunk/BUGS 2009-01-14 17:24:12 UTC (rev 33551) +++ brlcad/trunk/BUGS 2009-01-14 17:26:58 UTC (rev 33552) @@ -61,11 +61,6 @@ * g2asc of a v4 is apparently writing out the wrong s_cgtypes and otherwise parsing v4 .g files incorrectly -* pipe primitive has a BU_GETSTRUCT malloc getting called during - raytracing that kills performance by more than an order of magnitude - (especially when the light source is a pipe and there are a lot of - shadow rays) - * bump shader seems to be busted. only renders as flat by itself and stacked with phong it seems to ignore the uv settings. @@ -86,10 +81,6 @@ * MGED File->Preferences->Fonts results in error "named font "button _font" doesn't exist on Linux. -* lingering default isn't working for at least one linux user - -* rtwizard seems to be busted (again) - * mged tab-completion doesn't work if the object names have spaces * OpenGL display manager doesn't refresh automatically when the This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33551] brlcad/trunk/BUGS
Revision: 33551 http://brlcad.svn.sourceforge.net/brlcad/?rev=33551&view=rev Author: brlcad Date: 2009-01-14 17:24:12 + (Wed, 14 Jan 2009) Log Message: --- the fast4-g line skipping bug was fixed a while back Modified Paths: -- brlcad/trunk/BUGS Modified: brlcad/trunk/BUGS === --- brlcad/trunk/BUGS 2009-01-14 17:21:41 UTC (rev 33550) +++ brlcad/trunk/BUGS 2009-01-14 17:24:12 UTC (rev 33551) @@ -61,8 +61,6 @@ * g2asc of a v4 is apparently writing out the wrong s_cgtypes and otherwise parsing v4 .g files incorrectly -* fast4-g skips lines while processing if there are DOS line endings - * pipe primitive has a BU_GETSTRUCT malloc getting called during raytracing that kills performance by more than an order of magnitude (especially when the light source is a pipe and there are a lot of This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33550] brlcad/trunk/BUGS
Revision: 33550 http://brlcad.svn.sourceforge.net/brlcad/?rev=33550&view=rev Author: brlcad Date: 2009-01-14 17:21:41 + (Wed, 14 Jan 2009) Log Message: --- mged on mac crashes if you link against the system tcl/tk libs Modified Paths: -- brlcad/trunk/BUGS Modified: brlcad/trunk/BUGS === --- brlcad/trunk/BUGS 2009-01-14 17:03:01 UTC (rev 33549) +++ brlcad/trunk/BUGS 2009-01-14 17:21:41 UTC (rev 33550) @@ -15,6 +15,9 @@ Recent Bugs --- +* mged on Mac OS X will crash on an X11 call if compiled against + system Tcl/Tk (at least on 10.4 linking against 8.4), see TODO + * the ray tracer fails to report LOS and sometimes even hits on a BoT that is marked as unoriented or is inverted (even though it sometimes will report the segments, just without LOS). this seems This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ BRL-CAD Source Commits mailing list brlcad-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33548] brlcad/trunk/src/libged
Revision: 33548
http://brlcad.svn.sourceforge.net/brlcad/?rev=33548&view=rev
Author: bob1961
Date: 2009-01-14 16:43:04 + (Wed, 14 Jan 2009)
Log Message:
---
Add code to prevent interrupts during database writes.
Modified Paths:
--
brlcad/trunk/src/libged/inside.c
brlcad/trunk/src/libged/typein.c
Modified: brlcad/trunk/src/libged/inside.c
===
--- brlcad/trunk/src/libged/inside.c2009-01-14 16:27:58 UTC (rev 33547)
+++ brlcad/trunk/src/libged/inside.c2009-01-14 16:43:04 UTC (rev 33548)
@@ -27,6 +27,7 @@
#include "bio.h"
#include
+#include
#include
#include
#include
@@ -917,6 +918,7 @@
char *newname;
int arg = 1;
static const char *usage = "out_prim in_prim th(s)";
+void (*cur_sigint)();
GED_CHECK_DATABASE_OPEN(gedp, BRLCAD_ERROR);
GED_CHECK_READ_ONLY(gedp, BRLCAD_ERROR);
@@ -1171,16 +1173,28 @@
return BRLCAD_ERROR;
}
+/* don't allow interrupts while we update the database! */
+cur_sigint = signal(SIGINT, SIG_IGN);
+
/* Add to in-core directory */
if ( (dp = db_diradd( gedp->ged_wdbp->dbip, newname, -1, 0, DIR_SOLID,
(genptr_t)&intern.idb_type )) == DIR_NULL ) {
+ /* restore the handler before returning */
+ (void)signal(SIGINT, cur_sigint);
+
bu_vls_printf(&gedp->ged_result_str, "%s: Database alloc error,
aborting\n", argv[0]);
return BRLCAD_ERROR;
}
if ( rt_db_put_internal( dp, gedp->ged_wdbp->dbip, &intern,
&rt_uniresource ) < 0 ) {
+ /* restore the handler before returning */
+ (void)signal(SIGINT, cur_sigint);
+
bu_vls_printf(&gedp->ged_result_str, "%s: Database write error,
aborting\n", argv[0]);
return BRLCAD_ERROR;
}
+/* restore the handler before returning */
+(void)signal(SIGINT, cur_sigint);
+
return BRLCAD_OK;
}
Modified: brlcad/trunk/src/libged/typein.c
===
--- brlcad/trunk/src/libged/typein.c2009-01-14 16:27:58 UTC (rev 33547)
+++ brlcad/trunk/src/libged/typein.c2009-01-14 16:43:04 UTC (rev 33548)
@@ -28,6 +28,7 @@
#include "bio.h"
#include
+#include
#include
#include
@@ -2694,6 +2695,7 @@
struct rt_db_internal internal;
char **menu;
int nvals, (*fn_in)();
+void (*cur_sigint)();
GED_CHECK_DATABASE_OPEN(gedp, BRLCAD_ERROR);
GED_CHECK_READ_ONLY(gedp, BRLCAD_ERROR);
@@ -2987,17 +2989,29 @@
do_new_update:
/* The function may have already written via LIBWDB */
if ( internal.idb_ptr != NULL ) {
+ /* don't allow interrupts while we update the database! */
+ cur_sigint = signal(SIGINT, SIG_IGN);
+
if ( (dp=db_diradd( gedp->ged_wdbp->dbip, name, -1L, 0, DIR_SOLID,
(genptr_t)&internal.idb_type)) == DIR_NULL ) {
+ /* restore the handler before returning */
+ (void)signal(SIGINT, cur_sigint);
+
rt_db_free_internal( &internal, &rt_uniresource );
bu_vls_printf(&gedp->ged_result_str, "%s: Cannot add '%s' to
directory\n", argv[0], name);
return BRLCAD_ERROR;
}
if ( rt_db_put_internal( dp, gedp->ged_wdbp->dbip, &internal,
&rt_uniresource ) < 0 )
{
+ /* restore the handler before returning */
+ (void)signal(SIGINT, cur_sigint);
+
rt_db_free_internal( &internal, &rt_uniresource );
bu_vls_printf(&gedp->ged_result_str, "%s: Database write error,
aborting\n", argv[0]);
return BRLCAD_ERROR;
}
+
+ /* restore the handler before returning */
+ (void)signal(SIGINT, cur_sigint);
}
return BRLCAD_OK;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
___
BRL-CAD Source Commits mailing list
brlcad-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33547] brlcad/trunk/src/shapes/picket_fence.c
Revision: 33547
http://brlcad.svn.sourceforge.net/brlcad/?rev=33547&view=rev
Author: brlcad
Date: 2009-01-14 16:27:58 + (Wed, 14 Jan 2009)
Log Message:
---
msvc probably didn't like that they were empty initializers. give them a value
and it should be happy.
Modified Paths:
--
brlcad/trunk/src/shapes/picket_fence.c
Modified: brlcad/trunk/src/shapes/picket_fence.c
===
--- brlcad/trunk/src/shapes/picket_fence.c 2009-01-14 16:24:39 UTC (rev
33546)
+++ brlcad/trunk/src/shapes/picket_fence.c 2009-01-14 16:27:58 UTC (rev
33547)
@@ -38,12 +38,12 @@
long i, j, k, l;
struct rt_wdb *fp_db = NULL;
-char name[256];
-char pname[256];
-char w1name[256];
-char w2name[256];
-char firstname[256];
-char prefix[256];
+char name[256] = {0};
+char pname[256] = {0};
+char w1name[256] = {0};
+char w2name[256] = {0};
+char firstname[256] = {0};
+char prefix[256] = {0};
struct wmember wm;
struct wmember wm2;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
___
BRL-CAD Source Commits mailing list
brlcad-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
[brlcad-commits] SF.net SVN: brlcad:[33546] brlcad/trunk/src/shapes/picket_fence.c
Revision: 33546
http://brlcad.svn.sourceforge.net/brlcad/?rev=33546&view=rev
Author: bob1961
Date: 2009-01-14 16:24:39 + (Wed, 14 Jan 2009)
Log Message:
---
Initialization not needed on these character arrays (i.e. they're inititialized
below before being used). Besides, windows doesn't like it.
Modified Paths:
--
brlcad/trunk/src/shapes/picket_fence.c
Modified: brlcad/trunk/src/shapes/picket_fence.c
===
--- brlcad/trunk/src/shapes/picket_fence.c 2009-01-14 05:41:30 UTC (rev
33545)
+++ brlcad/trunk/src/shapes/picket_fence.c 2009-01-14 16:24:39 UTC (rev
33546)
@@ -38,12 +38,12 @@
long i, j, k, l;
struct rt_wdb *fp_db = NULL;
-char name[256] = {};
-char pname[256] = {};
-char w1name[256] = {};
-char w2name[256] = {};
-char firstname[256] = {};
-char prefix[256] = {};
+char name[256];
+char pname[256];
+char w1name[256];
+char w2name[256];
+char firstname[256];
+char prefix[256];
struct wmember wm;
struct wmember wm2;
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
___
BRL-CAD Source Commits mailing list
brlcad-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-commits
