bug#25563: 11.90; Many predicates in TeX-view-predicate-list-builtin don't work.

[Tassilo Horn]

Ikumi Keita  writes:

Hi Ikumi,

>> For paper-a4 and paper-a5 I wasn't quite sure if at least some of the
>> regexes there could also be styles/packages so there I check both
>> styles and documentclass options.  If you know better than me, feel
>> free to make that more specific.
>
> Sorry, I am not familiar about that issue either.

Ok, no problem to keep checking for both.

> And just some minor comments about the code related to the problem.
>
> 1. Isn't the the regexp \`a5paper\|a5comb\' for paper-a5 really intended
>as \`\(?:a5paper\|a5comb\)\' ?  Similar question goes to the regexp
>for paper-a4, too.

Oh, I didn't think about it.  But after a short test it seems that
foo\|bar is equivalent to \(foo\|bar\) and not to fo\(o\|b\)ar which you
seem to expect (and which sounded more plausible to me, too).

Anyway, IMO the shy group with its parens makes it more understandable
to me, so please go ahead.

> 2. `LaTeX-auto-cleanup' treats "package" and "Package" equally at the
>part
> (if (or (string-equal "package" class)
> (string-equal "Package" class))
>.  Thus the later part
>   (cond (equal class "class")
> (add-to-list 'TeX-auto-file "latex2e"))
>shuold also treat "class" and "Class" equally, shouldn't it?

Yes, makes sense.

Could you do me a favor and submit a one-in-all patch which also
contains your changes from your later 2 changes with a ChangeLog-like
commit message?

Bye,
Tassilo

BTW: You are a contributor since a very long time (12 years!) and I
completely trust your ability to not mess up things beyond repair.  So
I'd happily give you push access to our repository if you want to.
Interested?



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25601: Possible need for an update to the \TeX "preview" package.

[Arash Esbati]

Hi Emmanuel,

Emmanuel Charpentier  writes:

> I recently stumbled on a  problem that is not specifically bound to
> preview, but shows that a (slight) revision may be in order. See the
> transcript of a thread in comp.text.tex at
> https://groups.google.com/forum/#!topic/comp.text.tex/umzerAdDkX0 .
>
> Working on this problem, I saw that preview had an option specific to
> the XeLaTeX compiler. This made me think that an analogous solution
> was needed for the LuaTeX compiler, which uses the same mechanisms for
> font loading and font metrics. However, I do not know welle enough the
> internals of these engines to determine if the solution used for
> XeLaTeX can be applied to LuaTeX, of if specific actions are needed.
>
> Do you think that a slight revision of your package could be done (if
> only to document how to use it with LuaLaTeX) ?

Thanks for your report.  For the records, LuaTeX and pdfTeX used to
share some primitives like \pdfoutput, \pdfvorigin, \pdfhorigin,
\pdfpageheight and \pdfpagewidth.  With the advent of LuaTeX 0.85,
LuaTeX uses other names for these primitives and hence the code in
preview.sty does not work with this engine.

One can solve the issue by doing:

\RequirePackage{luatex85}
\documentclass{article}
...

I will try to update this in preview.pdf.  But the real solution will
have to wait.

Best, Arash



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25564: 11.90; XEmacs lacks file-local-variables-alist and reports error.

[Tassilo Horn]

Ikumi Keita  writes:

Hi Ikumi,

>> Did you also check that the feature works?  That is, that the code
>> between | and | in
>
>> \mycode|(lambda () "wohoo")|
>
>> is highlighted as verbatim in a file with
>
>> %% Local Variables:
>> %% LaTeX-verbatim-macros-with-delims: ("mycode")
>> %% End:
>
> I checked with the given example.  It seems that highlighting works as
> expected.  See the attached images, please.

Perfect, thanks a lot.  I close this issue then.

Bye,
Tassilo



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25563: 11.90; Many predicates in TeX-view-predicate-list-builtin don't work.

[Ikumi Keita]

>> I attach a patch based on the above idea.

> Added trivial fix for coherency (provided -> match).

Sorry for noise, I had to change "options" to "option", too.

Bye,
Ikumi Keita

diff -r c52403a42881 latex.el
--- a/latex.el  Wed Dec 21 22:58:09 2016 +0900
+++ b/latex.el  Fri Feb 03 00:21:58 2017 +0900
@@ -1799,9 +1799,10 @@
  (list (cons style options)
 
;; The third argument if "class" indicates LaTeX2e features.
-   (cond ((equal class "class")
+   (cond ((or (string-equal class "class")
+  (string-equal class "Class"))
   (add-to-list 'TeX-auto-file "latex2e"))
- ((equal class "style")
+ ((string-equal class "style")
   (add-to-list 'TeX-auto-file "latex2"))
 
   ;; Cleanup optional arguments
diff -r c52403a42881 tex.el
--- a/tex.elWed Dec 21 22:58:09 2016 +0900
+++ b/tex.elFri Feb 03 00:21:58 2017 +0900
@@ -1167,18 +1167,18 @@
 (mode-io-correlate
  TeX-source-correlate-mode)
 (paper-landscape
- (and (fboundp 'LaTeX-provided-class-options)
+ (and (fboundp 'LaTeX-match-class-option)
  (LaTeX-match-class-option "\\`landscape\\'")))
 (paper-portrait
- (not (and (fboundp 'LaTeX-provided-class-options)
+ (not (and (fboundp 'LaTeX-match-class-option)
   (LaTeX-match-class-option "\\`landscape\\'"
 (paper-a4
- (let ((regex "\\`a4paper\\|a4dutch\\|a4wide\\|sem-a4\\'"))
+ (let ((regex "\\`\\(?:a4paper\\|a4dutch\\|a4wide\\|sem-a4\\)\\'"))
(or (TeX-match-style regex)
   (and (fboundp 'LaTeX-match-class-option)
(LaTeX-match-class-option regex)
 (paper-a5
- (let ((regex "\\`a5paper\\|a5comb\\'"))
+ (let ((regex "\\`\\(?:a5paper\\|a5comb\\)\\'"))
(or (TeX-match-style regex)
   (and (fboundp 'LaTeX-match-class-option)
(LaTeX-match-class-option regex)



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25563: 11.90; Many predicates in TeX-view-predicate-list-builtin don't work.

[Ikumi Keita]

> I attach a patch based on the above idea.

Added trivial fix for coherency (provided -> match).

Bye,
Ikumi Keita

diff -r c52403a42881 latex.el
--- a/latex.el  Wed Dec 21 22:58:09 2016 +0900
+++ b/latex.el  Thu Feb 02 23:40:09 2017 +0900
@@ -1799,9 +1799,10 @@
  (list (cons style options)
 
;; The third argument if "class" indicates LaTeX2e features.
-   (cond ((equal class "class")
+   (cond ((or (string-equal class "class")
+  (string-equal class "Class"))
   (add-to-list 'TeX-auto-file "latex2e"))
- ((equal class "style")
+ ((string-equal class "style")
   (add-to-list 'TeX-auto-file "latex2"))
 
   ;; Cleanup optional arguments
diff -r c52403a42881 tex.el
--- a/tex.elWed Dec 21 22:58:09 2016 +0900
+++ b/tex.elThu Feb 02 23:40:09 2017 +0900
@@ -1167,18 +1167,18 @@
 (mode-io-correlate
  TeX-source-correlate-mode)
 (paper-landscape
- (and (fboundp 'LaTeX-provided-class-options)
+ (and (fboundp 'LaTeX-match-class-options)
  (LaTeX-match-class-option "\\`landscape\\'")))
 (paper-portrait
- (not (and (fboundp 'LaTeX-provided-class-options)
+ (not (and (fboundp 'LaTeX-match-class-options)
   (LaTeX-match-class-option "\\`landscape\\'"
 (paper-a4
- (let ((regex "\\`a4paper\\|a4dutch\\|a4wide\\|sem-a4\\'"))
+ (let ((regex "\\`\\(?:a4paper\\|a4dutch\\|a4wide\\|sem-a4\\)\\'"))
(or (TeX-match-style regex)
   (and (fboundp 'LaTeX-match-class-option)
(LaTeX-match-class-option regex)
 (paper-a5
- (let ((regex "\\`a5paper\\|a5comb\\'"))
+ (let ((regex "\\`\\(?:a5paper\\|a5comb\\)\\'"))
(or (TeX-match-style regex)
   (and (fboundp 'LaTeX-match-class-option)
(LaTeX-match-class-option regex)



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25564: 11.90; XEmacs lacks file-local-variables-alist and reports error.

[Ikumi Keita]

Hi Tassilo,

> Did you also check that the feature works?  That is, that the code
> between | and | in

> \mycode|(lambda () "wohoo")|

> is highlighted as verbatim in a file with

> %% Local Variables:
> %% LaTeX-verbatim-macros-with-delims: ("mycode")
> %% End:

I checked with the given example.  It seems that highlighting works as
expected.  See the attached images, please.

Bye,
Ikumi Keita

___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25563: 11.90; Many predicates in TeX-view-predicate-list-builtin don't work.

[Ikumi Keita]

Hi Tassilo,

> I think I've fixed this in commit
> c0f3659059a138aaf5fa610f2913035d63225bfb.

Thanks, the problem is fixed now.

> For paper-a4 and paper-a5 I wasn't quite sure if at least some of the
> regexes there could also be styles/packages so there I check both
> styles and documentclass options.  If you know better than me, feel
> free to make that more specific.

Sorry, I am not familiar about that issue either.

And just some minor comments about the code related to the problem.

1. Isn't the the regexp \`a5paper\|a5comb\' for paper-a5 really intended
   as \`\(?:a5paper\|a5comb\)\' ?  Similar question goes to the regexp
   for paper-a4, too.
2. `LaTeX-auto-cleanup' treats "package" and "Package" equally at the
   part
(if (or (string-equal "package" class)
(string-equal "Package" class))
   .  Thus the later part
(cond (equal class "class")
  (add-to-list 'TeX-auto-file "latex2e"))
   shuold also treat "class" and "Class" equally, shouldn't it?  The
   variable `LaTeX-auto-class-regexp-list' contains lines
;; \LoadClass[]{}[]
("Load\\(Class\\)\\(\\[\\([^#\\.%]*?\\)\\]\\)?{\\([^#\\.\n\r]+?\\)}"
 (3 4 1) LaTeX-auto-style)
;; \LoadClassWithOptions{}[]
("Load\\(Class\\)WithOptions\\(\\){\\([^#\\.\n\r]+?\\)}"
 (2 3 1) LaTeX-auto-style)
  , with capitalized word "Class".

I attach a patch based on the above idea.

Bye,
Ikumi Keita

diff -r c52403a42881 latex.el
--- a/latex.el  Wed Dec 21 22:58:09 2016 +0900
+++ b/latex.el  Thu Feb 02 22:50:17 2017 +0900
@@ -1799,9 +1799,10 @@
  (list (cons style options)
 
;; The third argument if "class" indicates LaTeX2e features.
-   (cond ((equal class "class")
+   (cond ((or (string-equal class "class")
+  (string-equal class "Class"))
   (add-to-list 'TeX-auto-file "latex2e"))
- ((equal class "style")
+ ((string-equal class "style")
   (add-to-list 'TeX-auto-file "latex2"))
 
   ;; Cleanup optional arguments
diff -r c52403a42881 tex.el
--- a/tex.elWed Dec 21 22:58:09 2016 +0900
+++ b/tex.elThu Feb 02 22:50:17 2017 +0900
@@ -1173,12 +1173,12 @@
  (not (and (fboundp 'LaTeX-provided-class-options)
   (LaTeX-match-class-option "\\`landscape\\'"
 (paper-a4
- (let ((regex "\\`a4paper\\|a4dutch\\|a4wide\\|sem-a4\\'"))
+ (let ((regex "\\`\\(?:a4paper\\|a4dutch\\|a4wide\\|sem-a4\\)\\'"))
(or (TeX-match-style regex)
   (and (fboundp 'LaTeX-match-class-option)
(LaTeX-match-class-option regex)
 (paper-a5
- (let ((regex "\\`a5paper\\|a5comb\\'"))
+ (let ((regex "\\`\\(?:a5paper\\|a5comb\\)\\'"))
(or (TeX-match-style regex)
   (and (fboundp 'LaTeX-match-class-option)
(LaTeX-match-class-option regex)



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex

bug#25564: 11.90; XEmacs lacks file-local-variables-alist and reports error.

[Ikumi Keita]

Hi Tassilo,

> Ikumi, I'll implement that now.  Could you please check if it works as
> expected in the coming days?

With the updated code, the error went away.  Thank you.

Bye,
Ikumi Keita



___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex