Re: add generated files to .gitignore

[Mike Frysinger]

On 05 Mar 2018 14:33, Chet Ramey wrote:
> On 3/5/18 1:15 PM, Mike Frysinger wrote:
> > On 02 Mar 2018 14:25, Chet Ramey wrote:
> >> On 2/27/18 11:46 AM, don fong wrote:
> >>> Chet, thanks for the suggestion.
> >>>
> >>> i still wonder what's the objection to changing .gitignore?
> >>
> >> I don't think it will be useful to me, since I curate the commits I
> >> make to the various branches, but I don't have any real objection if
> >> it will help others.
> > 
> > i wish the bash/readline git repos had .gitignore in them so every
> > dev didn't have to create it by hand themselves
> 
> OK, since the bash devel branch has one, I assume you mean the master
> branches for bash/readline?

all the active branches that people would normally use :)

so yeah, master & devel would be great, and as new branches are cut
off of master/devel, they'll get them for free.  i don't think there's
any need to backport to older stuff.
-mike


signature.asc
Description: Digital signature

Re: add generated files to .gitignore

[Chet Ramey]

On 3/5/18 1:15 PM, Mike Frysinger wrote:
> On 02 Mar 2018 14:25, Chet Ramey wrote:
>> On 2/27/18 11:46 AM, don fong wrote:
>>> Chet, thanks for the suggestion.
>>>
>>> i still wonder what's the objection to changing .gitignore?
>>
>> I don't think it will be useful to me, since I curate the commits I
>> make to the various branches, but I don't have any real objection if
>> it will help others.
> 
> i wish the bash/readline git repos had .gitignore in them so every
> dev didn't have to create it by hand themselves

OK, since the bash devel branch has one, I assume you mean the master
branches for bash/readline?

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/

Re: add generated files to .gitignore

[Mike Frysinger]

On 02 Mar 2018 14:25, Chet Ramey wrote:
> On 2/27/18 11:46 AM, don fong wrote:
> > Chet, thanks for the suggestion.
> > 
> > i still wonder what's the objection to changing .gitignore?
> 
> I don't think it will be useful to me, since I curate the commits I
> make to the various branches, but I don't have any real objection if
> it will help others.

i wish the bash/readline git repos had .gitignore in them so every
dev didn't have to create it by hand themselves
-mike


signature.asc
Description: Digital signature

Re: add generated files to .gitignore

[Chet Ramey]

On 2/27/18 11:46 AM, don fong wrote:
> Chet, thanks for the suggestion.
> 
> i still wonder what's the objection to changing .gitignore?

I don't think it will be useful to me, since I curate the commits I
make to the various branches, but I don't have any real objection if
it will help others.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/

Re: add generated files to .gitignore

[don fong]

Chet, thanks for the suggestion.

i still wonder what's the objection to changing .gitignore?

using a separate directory to build, while i'm working on the sources,
feels less convenient.





On Sun, Feb 25, 2018 at 1:10 PM, Chet Ramey  wrote:

> On 2/25/18 2:49 PM, don fong wrote:
> > Chet, i'm not sure i understand your suggestion.
> >
> >> You don't have to build in the source directory.
> >
> > i don't see anything in the INSTALL or README files about building
> outside
> > the source dir.
> > according to INSTALL,
>
> This is a standard feature of any autoconf-generated configure script, and
> is not specific to bash. Make a directory, cd to it, run
> "bash /path/to/srcdir/configure" and configure will make sure the right
> paths end up in the generated Makefiles.
>
> --
> ``The lyf so short, the craft so long to lerne.'' - Chaucer
>  ``Ars longa, vita brevis'' - Hippocrates
> Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/
>

Re: add generated files to .gitignore

[Chet Ramey]

On 2/25/18 2:49 PM, don fong wrote:
> Chet, i'm not sure i understand your suggestion.
> 
>> You don't have to build in the source directory.
> 
> i don't see anything in the INSTALL or README files about building outside
> the source dir.
> according to INSTALL,

This is a standard feature of any autoconf-generated configure script, and
is not specific to bash. Make a directory, cd to it, run
"bash /path/to/srcdir/configure" and configure will make sure the right
paths end up in the generated Makefiles.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/

Re: add generated files to .gitignore

[don fong]

Chet, i'm not sure i understand your suggestion.

> You don't have to build in the source directory.

i don't see anything in the INSTALL or README files about building outside
the source dir.
according to INSTALL,

The simplest way to compile Bash is:
>   1. 'cd' to the directory containing the source code and type
>  './configure' to configure Bash for your system.


it sounds like you're suggesting to make a copy of the source directory?
(or if that's not what you mean, can you be more explicit?)

making a copy of the source directory has drawbacks.  i also don't see how
it solves the problem of "git status" being cluttered.  either the copy is
a git repo, in which case "git status" will still be cluttered with
generated files; or it's not a git repo in which case i won't be able to do
"git status" or "git diff" to create the patch.

either way, if i'm trying to create a patch, and i have to move my changed
files from the copy back to the original source dir, it'd be easy to
accidentally leave something out.

it seems to me that building in the source directory is the natural and
most convenient way to do things.  from what i've seen, it's also the way
that "most" other open source software works.  my proposed change to
.gitignore will facilitate that mode of operation.

what do you perceive as the drawback?






On Sat, Feb 24, 2018 at 3:29 PM, Chet Ramey  wrote:

> On 2/24/18 3:36 PM, don fong wrote:
> > Eric, thanks for the tip.
> >
> > my feeling is that regardless of whether these files are pushed, they
> > clutter up the "git status" listing after i've done a build.
>
> You don't have to build in the source directory.
>
> --
> ``The lyf so short, the craft so long to lerne.'' - Chaucer
>  ``Ars longa, vita brevis'' - Hippocrates
> Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/
>

Re: add generated files to .gitignore

[Chet Ramey]

On 2/24/18 3:36 PM, don fong wrote:
> Eric, thanks for the tip.
> 
> my feeling is that regardless of whether these files are pushed, they
> clutter up the "git status" listing after i've done a build.

You don't have to build in the source directory.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/

Re: add generated files to .gitignore

[don fong]

Eric, thanks for the tip.

my feeling is that regardless of whether these files are pushed, they
clutter up the "git status" listing after i've done a build.



On Sat, Feb 24, 2018 at 11:28 AM, Eric Blake  wrote:
> On 02/24/2018 01:26 PM, Chet Ramey wrote:
>>
>> On 2/24/18 1:46 AM, don fong wrote:
>>>
>>> based on my experience creating one patch, running "make" and "make
>>> test", i found that "git status" was reporting a lot of generated and
>>> built files that i think should be ignored.
>>
>>
>> Those files aren't ever pushed to the bash git repositories (master,
>> devel).
>
>
> If Chet doesn't want to patch the primary bash.git to ignore them for
> everybody in .gitignore, you can still patch your downstream repo to ignore
> them locally by instead adding those exclusions to .git/info/exclude.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.   +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org

Re: add generated files to .gitignore

[Eric Blake]

On 02/24/2018 01:26 PM, Chet Ramey wrote:

On 2/24/18 1:46 AM, don fong wrote:

based on my experience creating one patch, running "make" and "make
test", i found that "git status" was reporting a lot of generated and
built files that i think should be ignored.


Those files aren't ever pushed to the bash git repositories (master,
devel).


If Chet doesn't want to patch the primary bash.git to ignore them for 
everybody in .gitignore, you can still patch your downstream repo to 
ignore them locally by instead adding those exclusions to .git/info/exclude.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: add generated files to .gitignore

[Chet Ramey]

On 2/24/18 1:46 AM, don fong wrote:
> based on my experience creating one patch, running "make" and "make
> test", i found that "git status" was reporting a lot of generated and
> built files that i think should be ignored.

Those files aren't ever pushed to the bash git repositories (master,
devel).

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/