[Bug ld/29617] Ld segfaults when bfd_close() fails

2022-09-26 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29617

Alan Modra  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Target Milestone|--- |2.40
 Resolution|--- |FIXED
   Assignee|unassigned at sourceware dot org   |amodra at gmail dot com

--- Comment #2 from Alan Modra  ---
Fixed for 2.40

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29617] Ld segfaults when bfd_close() fails

2022-09-26 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29617

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Alan Modra :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e122316b7ce78b999db944d7b524e11d642e2a49

commit e122316b7ce78b999db944d7b524e11d642e2a49
Author: Alan Modra 
Date:   Tue Sep 27 10:08:18 2022 +0930

PR29617, ld segfaults when bfd_close fails

PR 29617
* ldmain.c (main): Don't access output_bfd after bfd_close.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29617] New: Ld segfaults when bfd_close() fails

2022-09-26 Thread nishikawa.k at nec dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29617

Bug ID: 29617
   Summary: Ld segfaults when bfd_close() fails
   Product: binutils
   Version: 2.26
Status: UNCONFIRMED
  Severity: minor
  Priority: P2
 Component: ld
  Assignee: unassigned at sourceware dot org
  Reporter: nishikawa.k at nec dot com
  Target Milestone: ---

When the ld linker fails to close an output file (ex. the file on NFS is
removed from another machine), it refers the memory area of the variable for
the output file that is illegally deallocated for outputing message.

This problem occurs in the ld code below.


 465   if (! bfd_close (link_info.output_bfd))
 466 einfo (_("%F%B: final close failed: %E\n"), link_info.output_bfd);

The "bfd_close" function calls "bclose"(bfd/opncls.c:line 740) to close the
output file pointed to by the argument link_info.output_bfd.
If the file close fails, the "bfd_close" function returns false and the memory
area of the argument "link_info.output_bfd" is deallocated.
And then, when calling the function "einfo" on line 466 of ld/ldmain.c, the
deallocated link_info.output_bfd is referred to and it causes a segmentation
fault.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/29397] binutils: support zstd for SHF_COMPRESSED debug sections

2022-09-26 Thread i at maskray dot me
https://sourceware.org/bugzilla/show_bug.cgi?id=29397

--- Comment #3 from Fangrui Song  ---
(In reply to Fangrui Song from comment #2)
> https://sourceware.org/pipermail/gdb-patches/2022-September/191915.html
> [PATCH] binutils, gdb: support zstd compressed debug sections

The latest version is at
https://sourceware.org/pipermail/binutils/2022-September/123085.html . The gdb
part has been approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/27215] as: Error: non-constant .uleb128 is not supported on riscv64

2022-09-26 Thread ndesaulniers at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=27215

Nick Desaulniers  changed:

   What|Removed |Added

 CC||ndesaulniers at google dot com

--- Comment #7 from Nick Desaulniers  ---
Looks like this is an issue for DWARF v5 compatibility with Clang.
https://github.com/ClangBuiltLinux/linux/issues/1719

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Issue 48766 in oss-fuzz: binutils:fuzz_addr2line: Direct-leak in bfd_malloc

2022-09-26 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 48766 by sheriffbot: binutils:fuzz_addr2line: Direct-leak 
in bfd_malloc
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=48766#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

Issue 48768 in oss-fuzz: binutils:fuzz_ranlib_simulation: Direct-leak in bfd_malloc

2022-09-26 Thread sheriffbot via monorail
Updates:
Labels: Deadline-Approaching

Comment #2 on issue 48768 by sheriffbot: binutils:fuzz_ranlib_simulation: 
Direct-leak in bfd_malloc
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=48768#c2

This bug is approaching its deadline for being fixed, and will be automatically 
derestricted within 7 days. If a fix is planned within 2 weeks after the 
deadline has passed, a grace extension can be granted.

- Your friendly Sheriffbot

-- 
You received this message because:
  1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

[Bug ld/29592] [2.39 Regression][bisected] Exec stack warning causes go programs with cgo to fail to link on mips

2022-09-26 Thread matoro_bugzilla_glibc at matoro dot tk
https://sourceware.org/bugzilla/show_bug.cgi?id=29592

--- Comment #8 from matoro  ---
(In reply to Nick Clifton from comment #7)
> (In reply to matoro from comment #6)
> Hi Matoro,
> 
>  
> > Then I compared the scripts with the linker invocations that I got out of
> > pgrep and saw that they were different.  The linker is getting invoked
> > differently depending on whether the execstack warning is enabled or not.
> 
> OK - so does that mean that the bug is inside whatever is constructing the
> linker
> command line ?
> 
> You said that Gentoo is adding --enable-warn-execstack. How does it do this
> ?  Could whatever method it is using also be the source of the
> mis-constructed linker command line ?
> 
>  
> > With --enable-warn-execstack:
> 
> I might be missing something here, but I do not actually see
> --enable-warn-execstack on the command line that you listed.
> 
> > -melf64btsmip -pie -o go-sqlite3.test -s
>   
> It looks to me like the -pie option is also added here...
> 
> Cheers
>   Nick

--enable-warn-execstack is the flag you yourself added to default-enable this
feature at binutils build-time in ba951afb99912da01a6e8434126b8fac7aa75107.

To test this, I am toggling this flag on/off and rebuilding binutils.  When
it's toggled on, it always enables the warning, and -pie gets added to link
invocations from ld.  When toggled off, it defers to the target-specific rules,
which you already used to disable the warning on mips, and -pie does NOT get
added to link invocations.

As for what actually invokes the linker, I believe it is the usual gcc ->
collect2 -> ld chain.  I will check and see if these command lines are
different also.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29592] [2.39 Regression][bisected] Exec stack warning causes go programs with cgo to fail to link on mips

2022-09-26 Thread nickc at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29592

--- Comment #7 from Nick Clifton  ---
(In reply to matoro from comment #6)
Hi Matoro,


> Then I compared the scripts with the linker invocations that I got out of
> pgrep and saw that they were different.  The linker is getting invoked
> differently depending on whether the execstack warning is enabled or not.

OK - so does that mean that the bug is inside whatever is constructing the
linker
command line ?

You said that Gentoo is adding --enable-warn-execstack. How does it do this ? 
Could whatever method it is using also be the source of the mis-constructed
linker command line ?


> With --enable-warn-execstack:

I might be missing something here, but I do not actually see
--enable-warn-execstack on the command line that you listed.

> -melf64btsmip -pie -o go-sqlite3.test -s

It looks to me like the -pie option is also added here...

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/29616] New: The help document of readelf misses some options

2022-09-26 Thread mengda2020 at iscas dot ac.cn
https://sourceware.org/bugzilla/show_bug.cgi?id=29616

Bug ID: 29616
   Summary: The help document of readelf misses some options
   Product: binutils
   Version: 2.39
Status: UNCONFIRMED
  Severity: critical
  Priority: P2
 Component: binutils
  Assignee: unassigned at sourceware dot org
  Reporter: mengda2020 at iscas dot ac.cn
  Target Milestone: ---

The "--help" option of readelf misses the option "i" and "dwarf-check". 

1) For the option "i", the following code appears during option parsing and
calls the request_dump() in binutils/readelf.c:5597-5601 for version 2.39.

#ifdef SUPPORT_DISASSEMBLY
case 'i':
  request_dump (dumpdata, DISASS_DUMP);
  break;
#endif

2) For the option "dwarf-check", the following code appears during option
parsing and modifies the dwarf_check in binutils/readelf.c:5572-5574 for
version 2.39. 

case OPTION_DWARF_CHECK:
  dwarf_check = true;
  break;

But they do not appear in the document provided by "-h".

It may prevent users from using the relevant function.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/29542] PowerPC: internal error in get_output_view, at output.h:110

2022-09-26 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29542

Alan Modra  changed:

   What|Removed |Added

   Target Milestone|--- |2.40
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Alan Modra  ---
Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/29542] PowerPC: internal error in get_output_view, at output.h:110

2022-09-26 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29542

--- Comment #3 from cvs-commit at gcc dot gnu.org  ---
The binutils-2_39-branch branch has been updated by Alan Modra
:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=041c22e35de06d22566f4c71e4425c3351215e66

commit 041c22e35de06d22566f4c71e4425c3351215e66
Author: Alan Modra 
Date:   Sun Sep 25 12:07:36 2022 +0930

PR29542, PowerPC gold internal error in get_output_view,

We were attempting to set a BSS style section contents.

PR 29542
* powerpc.cc (Output_data_plt_powerpc::do_write): Don't set .plt,
.iplt or .lplt section contents when position independent.

(cherry picked from commit c21736aed1d4877e090df60362413669dbdc391d)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/29613] Use-of Uninitialized Value in objcopy

2022-09-26 Thread amodra at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=29613

Alan Modra  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Target Milestone|--- |2.40
   Assignee|unassigned at sourceware dot org   |amodra at gmail dot com
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Alan Modra  ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/29613] Use-of Uninitialized Value in objcopy

2022-09-26 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29613

--- Comment #1 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Alan Modra :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c7afb87bea33c27c7e669b94275fb8c22d6f43bc

commit c7afb87bea33c27c7e669b94275fb8c22d6f43bc
Author: Alan Modra 
Date:   Mon Sep 26 18:25:24 2022 +0930

PR29613, use of uninitialized value in objcopy

PR 29613
* elf.c (_bfd_elf_write_secondary_reloc_section): Trim sh_size
back to relocs written.  Use better types for vars.

-- 
You are receiving this mail because:
You are on the CC list for the bug.