[Bug ld/27566] [RISC-V] relocation truncated to fit: R_RISCV_GPREL_I against aymbol

2024-05-20 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=27566

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=115166
 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/31644] [Regression] libstdc++prettyprinters/debug.[cc|cxx11.cc] failing to build - linker error

2024-04-16 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31644

--- Comment #6 from Andrew Pinski  ---
It looks like the link against libstdc++v3.so is not happening ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/31644] [Regression] libstdc++prettyprinters/debug.[cc|cxx11.cc] failing to build - linker error

2024-04-16 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31644

--- Comment #5 from Andrew Pinski  ---
Oh note it is with -flto .

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/31644] [Regression] libstdc++prettyprinters/debug.[cc|cxx11.cc] failing to build - linker error

2024-04-15 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31644

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org

--- Comment #2 from Andrew Pinski  ---
Note also the jenkins does not keep around the .log files from the testsuite is
it is not very useful info except something failed ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28351] aarch64 ".xword :dtprel:t" is not supported

2024-02-29 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28351

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://github.com/llvm/llv
   ||m-project/issues/83466

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/31043] Poor error message for wrong number of registers

2023-11-07 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31043

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=24348

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/24348] GNU (g)as is confusing about vmovdqu mnemonics

2023-11-07 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=24348

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=31043

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/31043] Poor error message for wrong number of registers

2023-11-07 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=31043

Andrew Pinski  changed:

   What|Removed |Added

 Target||x86_64-linux-gnu

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/30724] Massive ld performance regression in binutils-2.41 since 014a602b86f08de96fc80ef3f96a87db6cccad56

2023-08-05 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=30724

--- Comment #2 from Andrew Pinski  ---
(In reply to Achim from comment #1)
> AFter a few false starts since it seems one really needs to freshly
> configure and compile the whole thing each time this got bisected to:
> 
> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;
> h=014a602b86f08de96fc80ef3f96a87db6cccad56
> 
> Why and how this produces the effect I've reported is a massive
> head-scratcher, but I've confirmed that with this patch reverted 2.41 does
> not only link as fast as 2.40 again, it is actually faster:
> 
> 2.41re:   10.494u   1.370s  0:17.01 69.7%   0+0k 0+0io 1904230pf+0w

That would be then a bug in cygwin stdio code I suspect ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/30724] massive ld performance regression

2023-08-05 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=30724

Andrew Pinski  changed:

   What|Removed |Added

 Target||cygwin
 CC||pinskia at gcc dot gnu.org
   Severity|critical|normal

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/12240] offset can't be used as label in Intel syntax

2023-05-03 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=12240

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=53929
 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/30418] use of labels that happen to match register names or keywords

2023-05-03 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=30418

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=53929

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/30279] UBSAN error: /buildworker/marxinbox-cross-binutils-sanitizers/build/gas/config/tc-m68hc11.c:708:20

2023-03-27 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=30279

Andrew Pinski  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|MOVED   |---
 CC||pinskia at gcc dot gnu.org
 Ever confirmed|1   |0

--- Comment #3 from Andrew Pinski  ---
The code in gas/config/tc-m68hc11.c is undefined:
  opc = XNEWVEC (struct m68hc11_opcode_def, num_opcodes);
  m68hc11_opcode_defs = opc--;


This is not defined at all. You cannot take the address before the start of the
allocated area.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/30033] binutils-2.40 broke arm-linux-gnueabi libraries on arm64 kernel with >4KB pages

2023-01-23 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=30033

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org

--- Comment #1 from Andrew Pinski  ---
https://inbox.sourceware.org/binutils/y7ogx08fcfvuc...@squeak.grove.modra.org/T/#t


I think this is by design ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/29794] find_reloc_table_entry in tc-aarch64.c should be speed up

2022-11-16 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29794

--- Comment #2 from Andrew Pinski  ---
There is another thing which could be done is do strchr up front to find the
other : and then match the length and not do the strncasecmp in that case.

That is:
static struct reloc_table_entry *
find_reloc_table_entry (char **str)
{
  unsigned int i;
  const char *relocnameinstrend = strchr(*str, ':');
  if (!relocnameinstrend)
return NULL;

  int reloclengthinstr = *str - relocnameinstrend;
  for (i = 0; i < ARRAY_SIZE (reloc_table); i++)
{
  int length = reloc_table[i].name_length;
  if (length == -1)
length = strlen (reloc_table[i].name);
  if (reloclengthinstr != length)
continue;

  if (strncasecmp (reloc_table[i].name, *str, length) == 0
  && (*str)[length] == ':')
{
  *str += (length + 1);
  return _table[i];
}
}

  return NULL;
}

- CUT 
These two should give a reasonable speed up I think. Also reording the list to
the most used first will also speed it up (I think that is the reason why lo12
is first already).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/29794] find_reloc_table_entry in tc-aarch64.c should be speed up

2022-11-16 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29794

--- Comment #1 from Andrew Pinski  ---
Created attachment 14459
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14459=edit
First attempt at a patch for this

I did not test this and I am not 100% sure about the GNUC check. I need to
check other locations which use this trick (if there is others).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/29794] find_reloc_table_entry in tc-aarch64.c should be speed up

2022-11-16 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29794

Andrew Pinski  changed:

   What|Removed |Added

Summary|find_reloc_table_entry  |find_reloc_table_entry in
   |should be speed up  |tc-aarch64.c should be
   ||speed up

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/29794] New: find_reloc_table_entry should be speed up

2022-11-16 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29794

Bug ID: 29794
   Summary: find_reloc_table_entry should be speed up
   Product: binutils
   Version: unspecified
Status: NEW
  Keywords: performance
  Severity: normal
  Priority: P2
 Component: gas
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
Target: aarch64*-*-*

With -O0 generated code, sometimes strlen shows up high on the perf profiling
of gas.
I looked and saw find_reloc_table_entry each time calls strlen on the name of
the relocation in the const table.
There has to be a better way of matching :lo12: and such.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29448] aarch64: "has a LOAD segment with RWX permissions"

2022-08-23 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29448

--- Comment #6 from Andrew Pinski  ---
(In reply to Jérôme Forissier from comment #4)
> But then how is it that the LLVM linker (ld.lld) has no problem with that?
> Same, linker script, and even same object files... (it generates 4 LOAD
> segments instead of just 2).

Because LLVM linker is set incorrectly for the max page size. It should be set
to 64k as that as Linux supports 64k page size. See comment #5 otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29448] aarch64: "has a LOAD segment with RWX permissions"

2022-08-23 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29448

--- Comment #5 from Andrew Pinski  ---
The reasoning is because the max "page size" on aarch64 is set to 64k so there
is only one segment. 

Either change the " . = ALIGN((1 << (12)));" to " . = ALIGN((1 << (14)));"
Or use "-z max-page-size=4096" .

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29448] aarch64: "has a LOAD segment with RWX permissions"

2022-08-23 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29448

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org
   See Also||https://github.com/OP-TEE/o
   ||ptee_os/issues/5471#issueco
   ||mment-1205362895

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/24678] RISC-V pcrel relocs and abs global pointer variable

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=24678

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=24983

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/24983] RISC-V GP linker relaxation is not performed with -nostdlib

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=24983

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org
   See Also||https://github.com/riscv-co
   ||llab/riscv-gnu-toolchain/is
   ||sues/497,
   ||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=91713,
   ||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=24678

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/24983] RISC-V GP linker relaxation is not performed with -nostdlib

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=24983

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=29509

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28441] [RISCV] ld linker relaxation is really slow

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28441

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=29509

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29509] The RISCV linker relaxation is just plain broken and should be removed

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29509

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=28441,
   ||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=24983,
   ||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=28878

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28878] [RISCV] Incorrect DW_AT_high_pc for assembly source with linker relaxation

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28878

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=29509

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/29509] New: The RISCV linker relaxation is just plain broken and should be removed

2022-08-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=29509

Bug ID: 29509
   Summary: The RISCV linker relaxation is just plain broken and
should be removed
   Product: binutils
   Version: unspecified
Status: NEW
  Severity: normal
  Priority: P2
 Component: ld
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
Target: riscv

Deleting data while doing relaxation is not only slow (see PR 28441) but forces
many real bugs (see PR 24983 and PR 28878 and others). Therefore it should be
removed and GCC should do many of them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gold/28876] gold should error out when creating a direct reference to protected function

2022-02-09 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28876

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=37611

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28875] ld should warn or error out about creating copy relocs & direct external references for protected symbols

2022-02-09 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28875

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=19520

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/28875] ld should warn or error out about creating copy relocs & direct external references for protected symbols

2022-02-09 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28875

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=37611

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/26548] LEB decoding error

2022-01-26 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=26548

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=104238
 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/13031] Building CodeBlocks on Windows using mingw gcc 4.6.1 "-flto -fuse-linker-plugin" results in many linker stage errors

2022-01-08 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=13031

Andrew Pinski  changed:

   What|Removed |Added

   See Also||http://gcc.gnu.org/bugzilla
   ||/show_bug.cgi?id=49844
 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/13256] AR + plugin fails with "no operation specified" error

2021-12-19 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=13256

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |2.33
 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27931] objcopy --localize-hidden/--keep-global-symbol: drop GRP_COMDAT if the signature symbol becomes local?

2021-12-05 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=27931

--- Comment #2 from Andrew Pinski  ---
There was an old (7 years ago) bug filed against GCC about __x86.get_pc_thunk
and "objcopy --keep-global-symbol" (https://gcc.gnu.org/PR59842) which seems
like the same issue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/3182] objcopy doesn't update section group when a member is removed

2021-12-05 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=3182

Andrew Pinski  changed:

   What|Removed |Added

 Resolution|WONTFIX |FIXED
 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/27931] objcopy --localize-hidden/--keep-global-symbol: drop GRP_COMDAT if the signature symbol becomes local?

2021-12-05 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=27931

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=59842

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28367] Aarch64 disassembler could print out related addresses better

2021-09-21 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28367

Andrew Pinski  changed:

   What|Removed |Added

   Assignee|unassigned at sourceware dot org   |pinskia at gcc dot 
gnu.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug binutils/28367] New: Aarch64 disassembler could print out related addresses better

2021-09-21 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28367

Bug ID: 28367
   Summary: Aarch64 disassembler could print out related addresses
better
   Product: binutils
   Version: 2.30
Status: NEW
  Severity: normal
  Priority: P2
 Component: binutils
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Created attachment 13673
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13673=edit
patch

We should be able to do:
  40064c:   b4000194cbz x20, 40067c  // . + 48
...
  400604:   9001adrpx1, 40
<__libc_start_main@plt-0x4c0> // . - 1540

I am filing this bug to keep track of the patch which I want to finish up but
won't be able to get it done right away as there are testsuite changes needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28351] aarch64 ".xword :dtprel:t" is not supported

2021-09-18 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28351

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://sourceware.org/bugz
   ||illa/show_bug.cgi?id=27886

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28351] aarch64 ".xword :dtprel:t" is not supported

2021-09-18 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28351

Andrew Pinski  changed:

   What|Removed |Added

 Target||aarch64

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28351] aarch64 ".xword :dtprel:t" is not supported

2021-09-18 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28351

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=97344

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28351] New: aarch64 ".xword :dtprel:t" is not supported

2021-09-18 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28351

Bug ID: 28351
   Summary: aarch64 ".xword :dtprel:t" is not supported
   Product: binutils
   Version: 2.30
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Take:
.xword  :dtprel:t

A couple of things error message is way off for this.
Second is this is needed to be supported to support debugging information for
TLS on aarch64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28211] gas puts local labels in the symbol talble if @GOTOFF is used in rodata

2021-08-09 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28211

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=43025

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28211] gas puts local labels in the symbol talble if @GOTOFF is used in rodata

2021-08-09 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28211

Andrew Pinski  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|WAITING |UNCONFIRMED

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28211] gas puts local labels in the symbol talble if @GOTOFF is used in rodata

2021-08-09 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28211

Andrew Pinski  changed:

   What|Removed |Added

  Attachment #13605|0   |1
is obsolete||

--- Comment #2 from Andrew Pinski  ---
Created attachment 13607
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13607=edit
right testcase

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug gas/28211] New: gas puts local labels in the symbol talble if @GOTOFF is used in rodata

2021-08-08 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=28211

Bug ID: 28211
   Summary: gas puts local labels in the symbol talble if @GOTOFF
is used in rodata
   Product: binutils
   Version: 2.30
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Created attachment 13605
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13605=edit
test assembly file

>From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43025 .
Assemble attach .s file on 32bit i686 and do nm on the object file:
[apinski@xeond2 upstream-gcc-git]$ as --32 -o t55.o t55.s
[apinski@xeond2 upstream-gcc-git]$ nm t55.o
 T fn
 U _GLOBAL_OFFSET_TABLE_
0039 t .L10
0032 t .L11
002b t .L12
0024 t .L13
0063 t .L3
005c t .L5
0055 t .L6
004e t .L7
0047 t .L8
0040 t .L9
 T __x86.get_pc_thunk.ax
- CUT ---
Jakub mentions  in the gcc bug:
I'd say this is a gas bug, I don't see why if we don't need on x86 the local
symbols in .long .L3 or call .L3 cases, we don't need it for .long .L3@GOTOFF
either, resolving it to .text +  is perfectly fine.

-- CUT -

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25285] FAIL: Run with libfunc1.so comm1.o with GCC 10

2020-01-08 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25285

Andrew Pinski  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Andrew Pinski  ---
(In reply to Nick Clifton from comment #1)
> 
> I think that this issue may have been fixed by my patch for PR25327.  Please
> could you check and let me know ?

Yes they are fixed.

*** This bug has been marked as a duplicate of bug 25327 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25327] FAIL: Run pr20276

2020-01-08 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25327

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org

--- Comment #8 from Andrew Pinski  ---
*** Bug 25285 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/25285] New: FAIL: Run with libfunc1.so comm1.o with GCC 10

2019-12-15 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=25285

Bug ID: 25285
   Summary: FAIL: Run with libfunc1.so comm1.o with GCC 10
   Product: binutils
   Version: 2.33
Status: NEW
  Severity: normal
  Priority: P2
 Component: ld
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

GCC 10 enables -fno-common by default and we get an extra failure due to that:
/bajas/pinskia/src/toolchain-10/marvell-tools/bin/../lib/gcc/aarch64-marvell-linux-gnu/10.0.0/../../../../aarch64-marvell-linux-gnu/bin/ld:
warning: type of symbol `foo' changed from 2 to 1 in tmpdir/comm1.o
/bajas/pinskia/src/toolchain-10/marvell-tools/bin/../lib/gcc/aarch64-marvell-linux-gnu/10.0.0/../../../../aarch64-marvell-linux-gnu/bin/ld:
warning: type of symbol `foo' changed from 2 to 1 in tmpdir/comm1.o
FAIL: Run with libfunc1.so comm1.o

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/22764] [2.30 Regression] ld fails to link 4.13 and 4.15 kernels on aarch64-linux-gnu

2018-02-02 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=22764

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org

--- Comment #7 from Andrew Pinski  ---
(In reply to Matthias Klose from comment #6)
> systemd on aarch64 configured with efi support fails with a similar
> relocation error:
> 
> ld -o src/boot/efi/systemd_boot.so -T /usr/lib/elf_aarch64_efi.lds -shared
> -Bsymbolic -nostdlib -znocombreloc -L /usr/lib /usr/lib/crt0-efi-aarch64.o
> --defsym=EFI_SUBSYSTEM=0xa src/boot/efi/disk.c.o src/boot/efi/graphics.c.o
> src/boot/efi/measure.c.o src/boot/efi/pe.c.o src/boot/efi/util.c.o
> src/boot/efi/boot.c.o src/boot/efi/console.c.o src/boot/efi/shim.c.o -lefi
> -lgnuefi /usr/lib/gcc/aarch64-linux-gnu/7/libgcc.a
> ld: /usr/lib/crt0-efi-aarch64.o: relocation R_AARCH64_ABS16 against
> `EFI_SUBSYSTEM' can not be used when making a shared object

This is a bug in either in gnu-efi or systemd.  EFI_SUBSYSTEM is in the pe-coff
header so we don't want any relocation there :).  Basically EFI_SUBSYSTEM is
not being defined.  Note Uboot has a similar bug too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/20868] ld relaxes TLS access erroneously for aarch64 in ilp32 mode

2016-11-25 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=20868

Andrew Pinski  changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gold/17670] internal error in symval_for_branch, at powerpc.cc:6755 during qt5 build

2014-12-03 Thread pinskia at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=17670

Andrew Pinski pinskia at gcc dot gnu.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||pinskia at gcc dot gnu.org
 Resolution|MOVED   |---

--- Comment #5 from Andrew Pinski pinskia at gcc dot gnu.org ---
Reopening since the linker should not crash on code which violates C++ ODR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/16103] Symbol referenced when it should not be in aarch64

2013-10-30 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=16103

Andrew Pinski pinskia at gcc dot gnu.org changed:

   What|Removed |Added

 Target||aarch64-*-*

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/16103] New: Symbol referenced when it should not be in aarch64

2013-10-30 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=16103

Bug ID: 16103
   Summary: Symbol referenced when it should not be in aarch64
   Product: binutils
   Version: 2.25 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
  Assignee: unassigned at sourceware dot org
  Reporter: pinskia at gcc dot gnu.org

Take:
.text
.align  2
.global Extract_double_from_vector
.type   Extract_double_from_vector, %function
Extract_double_from_vector:
mov x0, v0.D[0]
ret
.size   Extract_double_from_vector, .-Extract_double_from_vector
--

The assembler produces an undefined reference to v0.D (note the capitalization
does not matter); this is wrong as this is movement from v0 register to the x0
register.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/596] non-dynamic global symbols in .dynstr and .hash sections

2012-10-22 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=596

Andrew Pinski pinskia at gcc dot gnu.org changed:

   What|Removed |Added

 CC||pinskia at gcc dot gnu.org

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/13509] branch target to the wrong location

2011-12-16 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=13509

--- Comment #4 from Andrew Pinski pinskia at gcc dot gnu.org 2011-12-16 
22:18:04 UTC ---
The reason why GCC emits LABEL = . is because of the following reason:
* Print debug labels as foo = . rather than foo: because they should
   represent a byte pointer rather than an ISA-encoded address.
...

The .uleb128 requies $LFBxxx to match the FDE start address, which is
   likewise a byte pointer rather than an ISA-encoded address.

So I think we should just delete the code in the assembler which moves the
labels since they don't move = . based labels.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/13509] branch target to the wrong location

2011-12-16 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=13509

--- Comment #6 from Andrew Pinski pinskia at gcc dot gnu.org 2011-12-16 
23:25:39 UTC ---
Looks like this version of the mips patch:
http://sourceware.org/ml/binutils/2010-10/msg00512.html
Would have fixed it also.  But it was rejected and only a fake labels were
added rather than all cases where the symbol = . .

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/13509] branch target to the wrong location

2011-12-16 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=13509

--- Comment #8 from Andrew Pinski pinskia at gcc dot gnu.org 2011-12-17 
00:38:56 UTC ---
Something like:
Index: config/tc-mips.c
===
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.500
diff -u -p -r1.500 tc-mips.c
--- config/tc-mips.c8 Dec 2011 20:47:25 -1.500
+++ config/tc-mips.c17 Dec 2011 00:38:28 -
@@ -15633,7 +15633,7 @@ get_symbol (void)
label.  */

 static void
-mips_align (int to, int *fill, symbolS *label)
+mips_align (int to, int *fill, struct insn_label_list *labels)
 {
   mips_emit_delays ();
   mips_record_compressed_mode ();
@@ -15642,11 +15642,13 @@ mips_align (int to, int *fill, symbolS *
   else
 frag_align (to, fill ? *fill : 0, 0);
   record_alignment (now_seg, to);
-  if (label != NULL)
+ while (labels != NULL)
 {
+  symbolS *label = labels-label;
   gas_assert (S_GET_SEGMENT (label) == now_seg);
   symbol_set_frag (label, frag_now);
   S_SET_VALUE (label, (valueT) frag_now_fix ());
+  labels = labels-next;
 }
 }

@@ -15689,7 +15691,7 @@ s_align (int x ATTRIBUTE_UNUSED)
   struct insn_label_list *l = si-label_list;
   /* Auto alignment should be switched on by next section change.  */
   auto_align = 1;
-  mips_align (temp, fill_ptr, l != NULL ? l-label : NULL);
+  mips_align (temp, fill_ptr, l);
 }
   else
 {
@@ -15859,12 +15861,10 @@ s_cons (int log_size)
 {
   segment_info_type *si = seg_info (now_seg);
   struct insn_label_list *l = si-label_list;
-  symbolS *label;

-  label = l != NULL ? l-label : NULL;
   mips_emit_delays ();
   if (log_size  0  auto_align)
-mips_align (log_size, 0, label);
+mips_align (log_size, 0, l);
   cons (1  log_size);
   mips_clear_insn_labels ();
 }
@@ -15874,18 +15874,15 @@ s_float_cons (int type)
 {
   segment_info_type *si = seg_info (now_seg);
   struct insn_label_list *l = si-label_list;
-  symbolS *label;
-
-  label = l != NULL ? l-label : NULL;

   mips_emit_delays ();

   if (auto_align)
 {
   if (type == 'd')
-mips_align (3, 0, label);
+mips_align (3, 0, l);
   else
-mips_align (2, 0, label);
+mips_align (2, 0, l);
 }

   float_cons (type);
@@ -16653,7 +16650,6 @@ s_gpword (int ignore ATTRIBUTE_UNUSED)
 {
   segment_info_type *si;
   struct insn_label_list *l;
-  symbolS *label;
   expressionS ex;
   char *p;

@@ -1,10 +16662,9 @@ s_gpword (int ignore ATTRIBUTE_UNUSED)

   si = seg_info (now_seg);
   l = si-label_list;
-  label = l != NULL ? l-label : NULL;
   mips_emit_delays ();
   if (auto_align)
-mips_align (2, 0, label);
+mips_align (2, 0, l);

   expression (ex);
   mips_clear_insn_labels ();
@@ -16693,7 +16688,6 @@ s_gpdword (int ignore ATTRIBUTE_UNUSED)
 {
   segment_info_type *si;
   struct insn_label_list *l;
-  symbolS *label;
   expressionS ex;
   char *p;

@@ -16706,10 +16700,9 @@ s_gpdword (int ignore ATTRIBUTE_UNUSED)

   si = seg_info (now_seg);
   l = si-label_list;
-  label = l != NULL ? l-label : NULL;
   mips_emit_delays ();
   if (auto_align)
-mips_align (3, 0, label);
+mips_align (3, 0, l);

   expression (ex);
   mips_clear_insn_labels ();

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/13509] New: branch target to the wrong location

2011-12-15 Thread pinskia at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=13509

 Bug #: 13509
   Summary: branch target to the wrong location
   Product: binutils
   Version: unspecified
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: pins...@gcc.gnu.org
Classification: Unclassified


Take:
.align 2
.global main
.ent main
main:
beqz $5, .L1
nop
addi $5, $5, 1
b .L2
nop

.L1:
#.L3=.
.align 3
.L2:
la $5, .L3
jr  $31
nop
.end main
--- CUT ---
The two branches will take you to L2.
If we uncomment the assignment to .L3, we get something different, where one is
before the .align and the other is after.  This causes in the end causes a
miscompare inside GCC when comparing with and without debugging info.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils