[Bug binutils/13292] Binutils uses struct stat instead of #include sys/stat.h
http://sourceware.org/bugzilla/show_bug.cgi?id=13292 --- Comment #8 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot gnu.org 2011-10-24 11:23:47 UTC --- CVSROOT:/cvs/src Module name:src Changes by:ni...@sourceware.org2011-10-24 11:23:41 Modified files: bfd: ChangeLog bfd-in.h bfd-in2.h Log message: PR binutils/13292 * bfd-in.h: Include sys/stat.h rather than forward defining struct stat. * bfd-in2.h: Regenerate. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5500r2=1.5501 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd-in.h.diff?cvsroot=srcr1=1.158r2=1.159 http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd-in2.h.diff?cvsroot=srcr1=1.549r2=1.550 -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13292] Binutils uses struct stat instead of #include sys/stat.h
http://sourceware.org/bugzilla/show_bug.cgi?id=13292 Nick Clifton nickc at redhat dot com changed: What|Removed |Added Status|NEW |RESOLVED CC||nickc at redhat dot com Resolution||FIXED --- Comment #9 from Nick Clifton nickc at redhat dot com 2011-10-24 11:26:26 UTC --- Hi Pau, Thanks for the bug report and patch. I have checked your patch in along with the following changelog entry. Cheers Nick bfd/ChangeLog 2011-10-24 Pau Garcia i Quiles pgqui...@elpauer.org PR binutils/13292 * bfd-in.h: Include sys/stat.h rather than forward defining struct stat. * bfd-in2.h: Regenerate. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13292] Binutils uses struct stat instead of #include sys/stat.h
http://sourceware.org/bugzilla/show_bug.cgi?id=13292 --- Comment #2 from Pau Garcia i Quiles pgquiles at elpauer dot org 2011-10-20 10:06:32 UTC --- (In reply to comment #1) (In reply to comment #0) Created attachment 5984 [details] Fix mingw-w64 recently implemented support for large files using _FILE_OFFSET_BITS=64. Binutils uses struct stat instead of #include sys/stat.h, which makes it fail to compile with mingw-w64 trunk. The attached patch fixes the issue. I think you shouldn't edit bfd/bfd-in2.h since it is auto generated. The bfd-in.h is the file you want to patch, I guess. You are right. I'm attaching a new patch against bfd/bfd-in.h (which is essentially the same). The patch doesn't seem to solve the problem for me. What is the problem you are experiencing now? What compiler are you trying? Do you have the issue bfd/archive.c? Sorry, I don't understand :-? -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13292] Binutils uses struct stat instead of #include sys/stat.h
http://sourceware.org/bugzilla/show_bug.cgi?id=13292 Pau Garcia i Quiles pgquiles at elpauer dot org changed: What|Removed |Added Attachment #5984|0 |1 is obsolete|| --- Comment #3 from Pau Garcia i Quiles pgquiles at elpauer dot org 2011-10-20 10:07:43 UTC --- Created attachment 6020 -- http://sourceware.org/bugzilla/attachment.cgi?id=6020 Fix (patch bfd-in.h) -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13292] Binutils uses struct stat instead of #include sys/stat.h
http://sourceware.org/bugzilla/show_bug.cgi?id=13292 --- Comment #4 from Alen Skondro askondro at gmail dot com 2011-10-20 12:02:39 UTC --- (In reply to comment #2) (In reply to comment #1) (In reply to comment #0) Created attachment 5984 [details] Fix mingw-w64 recently implemented support for large files using _FILE_OFFSET_BITS=64. Binutils uses struct stat instead of #include sys/stat.h, which makes it fail to compile with mingw-w64 trunk. The attached patch fixes the issue. I think you shouldn't edit bfd/bfd-in2.h since it is auto generated. The bfd-in.h is the file you want to patch, I guess. You are right. I'm attaching a new patch against bfd/bfd-in.h (which is essentially the same). The patch doesn't seem to solve the problem for me. What is the problem you are experiencing now? What compiler are you trying? I'm using gcc 4.7 (trunk). ../../../binutils/bfd/archive.c: In function 'bfd_ar_hdr_from_filesystem': ../../../binutils/bfd/archive.c:1841:7: error: passing argument 1 of 'time' from incompatible pointer type [-Werror] In file included from j:\cross-gcc\bin\../lib/gcc/i686-w64-mingw32/4.7.0/../../../../i686-w64-mingw32/include/sys/time.h:10:0, from ../../../binutils/bfd/sysdep.h:64, from ../../../binutils/bfd/archive.c:130: j:\cross-gcc\bin\../lib/gcc/i686-w64-mingw32/4.7.0/../../../../i686-w64-mingw32/include/time.h:241:29: note: expected 'time_t *' but argument is of type '__time64_t *' cc1.exe: all warnings being treated as errors Do you have the issue bfd/archive.c? Sorry, I don't understand :-? Sorry, I wanted to ask if you also experienced the compile error in bfd/archive.c or somewhere else? -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug binutils/13292] Binutils uses struct stat instead of #include sys/stat.h
http://sourceware.org/bugzilla/show_bug.cgi?id=13292 Alen Skondro askondro at gmail dot com changed: What|Removed |Added CC||askondro at gmail dot com --- Comment #1 from Alen Skondro askondro at gmail dot com 2011-10-19 17:44:21 UTC --- (In reply to comment #0) Created attachment 5984 [details] Fix mingw-w64 recently implemented support for large files using _FILE_OFFSET_BITS=64. Binutils uses struct stat instead of #include sys/stat.h, which makes it fail to compile with mingw-w64 trunk. The attached patch fixes the issue. I think you shouldn't edit bfd/bfd-in2.h since it is auto generated. The bfd-in.h is the file you want to patch, I guess. The patch doesn't seem to solve the problem for me. Do you have the issue bfd/archive.c? -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
