[Bug gold/11899] segments not sorted by LMA
http://sourceware.org/bugzilla/show_bug.cgi?id=11899 Ian Lance Taylor ian at airs dot com changed: What|Removed |Added Status|WAITING |RESOLVED Resolution||FIXED --- Comment #7 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot gnu.org 2010-08-24 07:24:32 UTC --- Subject: Bug 11899 CVSROOT:/cvs/src Module name:src Changes by: ni...@sourceware.org2010-08-24 07:24:10 Modified files: gold : ChangeLog layout.cc Log message: PR 11899 * layout.cc (segment_precedes): Sort segments by their physical addresses, if they have been set. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/ChangeLog.diff?cvsroot=srcr1=1.621r2=1.622 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/layout.cc.diff?cvsroot=srcr1=1.176r2=1.177 --- Comment #8 from Nick Clifton nickc at redhat dot com 2010-08-24 07:25:01 UTC --- Subject: Re: segments not sorted by LMA Hi Ian, I would use parentheses and line up the ?: under the first part of the expression. Patch is OK. Thanks - patch committed with that change. Cheers Nick --- Comment #9 from Ian Lance Taylor ian at airs dot com 2011-07-09 00:17:32 UTC --- This seems to be fixed. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/11899] segments not sorted by LMA
--- Additional Comments From ian at airs dot com 2010-08-23 04:50 --- I would use parentheses and line up the ?: under the first part of the expression. Patch is OK. Thanks. -- http://sourceware.org/bugzilla/show_bug.cgi?id=11899 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/11899] segments not sorted by LMA
--- Additional Comments From nickc at redhat dot com 2010-08-20 08:43 --- Created an attachment (id=4943) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4943action=view) Revised patch -- What|Removed |Added Attachment #4922 is|0 |1 obsolete|| http://sourceware.org/bugzilla/show_bug.cgi?id=11899 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/11899] segments not sorted by LMA
--- Additional Comments From nickc at redhat dot com 2010-08-20 08:45 --- Hi Ian, Thanks for catching that for me. Your suggested improvement works just fine, so I have uploaded a revised patch. OK to apply ? Cheers Nick gold/ChangeLog 2010-08-20 Nick Clifton ni...@redhat.com PR 11899 * layout.cc (segment_precedes): Sort segments by their physical addresses, if they have been set. -- http://sourceware.org/bugzilla/show_bug.cgi?id=11899 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/11899] segments not sorted by LMA
--- Additional Comments From ian at airs dot com 2010-08-19 23:00 --- The patch is not correct in general, because the paddr_ field of segments is not set in general at the point where it is tested. It will be set when a linker script is used, but not by default. The paddr_ field is set when Layout::set_segment_offsets calls set_section_addresses, but not before. Your patch would probably be correct if it tested something like seg1-are_addresses_set() ? seg1-paddr() : seg1-first_section_load_address() Want to try that? -- What|Removed |Added Status|NEW |WAITING http://sourceware.org/bugzilla/show_bug.cgi?id=11899 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/11899] segments not sorted by LMA
--- Additional Comments From nickc at redhat dot com 2010-08-10 11:19 --- Created an attachment (id=4922) -- (http://sourceware.org/bugzilla/attachment.cgi?id=4922action=view) Sort segments by their load address -- http://sourceware.org/bugzilla/show_bug.cgi?id=11899 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug gold/11899] segments not sorted by LMA
--- Additional Comments From nickc at redhat dot com 2010-08-10 11:20 --- Proposed patch uploaded. -- http://sourceware.org/bugzilla/show_bug.cgi?id=11899 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
