[Bug ld/10858] ld generate broken PIE binaries on MIPS
https://sourceware.org/bugzilla/show_bug.cgi?id=10858 Andreas Schwab changed: What|Removed |Added CC|jackie.rosen at hushmail dot com | -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
https://sourceware.org/bugzilla/show_bug.cgi?id=10858 Jackie Rosen changed: What|Removed |Added CC||jackie.rosen at hushmail dot com --- Comment #12 from Jackie Rosen --- *** Bug 260998 has been marked as a duplicate of this bug. *** Seen from the domain http://volichat.com Page where seen: http://volichat.com/adult-chat-rooms Marked for reference. Resolved as fixed @bugzilla. -- You are receiving this mail because: You are on the CC list for the bug. ___ bug-binutils mailing list bug-binutils@gnu.org https://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From nickc at redhat dot com 2010-02-24 14:22 --- Hi Jay, Hi Aurelian, I have checked in the modified version of Alan's patch. Cheers Nick -- What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From jay dot foad at gmail dot com 2010-02-24 14:24 --- Thanks Nick! -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From cvs-commit at gcc dot gnu dot org 2010-02-24 14:22 --- Subject: Bug 10858 CVSROOT:/cvs/src Module name:src Changes by: ni...@sourceware.org2010-02-24 14:21:51 Modified files: bfd: ChangeLog elfxx-mips.c Log message: PR binutils/10858 * elfxx-mips.c (mips_elf_create_dynamic_relocation): Ise SYMBOL_REFERENCES_LOCAL to exclude entries from the dynamic symbol table. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=src&r1=1.4940&r2=1.4941 http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/bfd/elfxx-mips.c.diff?cvsroot=src&r1=1.266&r2=1.267 -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From jay dot foad at gmail dot com 2010-02-21 18:23 --- I've recently hit this problem myself. Is there any chance of one of the fixes being committed? Thanks. -- What|Removed |Added CC||jay dot foad at gmail dot ||com, rsandifo at sourceware ||dot org http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From aurelien at aurel32 dot net 2009-11-04 10:47 --- The alternative patch also fixes the problem, and also doesn't introduce any regressions in the testsuite. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From aurelien at aurel32 dot net 2009-11-04 09:46 --- Thanks a lot for the patch, I confirm it works for both the versions just after the problem has been introduced and trunk. I also checked it introduces no regressions on the trunk version. I haven't tested your alternative patch yet, I will do that soon. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From amodra at bigpond dot net dot au 2009-11-04 02:06 --- Created an attachment (id=4356) --> (http://sourceware.org/bugzilla/attachment.cgi?id=4356&action=view) likely fix I believe this patch will fix your problem, but I don't have mips machines and toolchains to properly test. Hmm, an alternate (and better!) fix would be to use " if (!SYMBOL_REFERENCES_LOCAL (info, &h->root))" here. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From aurelien at aurel32 dot net 2009-11-03 13:03 --- I have been able to bisect the bug further, here is the changeset that causes the problem: 2008-08-07 Richard Sandiford * elfxx-mips.c (mips_got_info): Add a "reloc_only_gotno" field. (mips_elf_got_section): Delete. (mips_elf_sort_hash_table): Use g->reloc_only_gotno to decide how many reloc-only entries there are. (mips_elf_count_got_symbols): Adjust g->reloc_only_gotno as well as g->global_gotno. (mips_elf_make_got_per_bfd): Initialize reloc_only_gotno. (mips_elf_multi_got): Likewise. Use gg->reloc_only_gotno rather than gg->assigned_gotno to store the number of reloc-only GOT entries. (mips_elf_create_got_section): Remove the MAYBE_EXCLUDE parameter. Initialize reloc_only_gotno. (mips_elf_calculate_relocation): Check htab->got_info instead of dynobj when deciding whether to call mips_elf_adjust_gp, (_bfd_mips_elf_create_dynamic_sections): Adjust the call to mips_elf_create_got_section. (mips_elf_record_relocs): Likewise. Remove redundant "dynobj == NULL" code. Do not use mips_elf_create_got_section or mips_elf_record_global_got_symbol for R_MIPS_32, R_MIPS_REL32 and R_MIPS_64; limit global_got_area to GGA_RELOC_ONLY instead. (_bfd_mips_elf_finish_dynamic_symbol): Use htab->sgot instead of mips_elf_got_section. (_bfd_mips_vxworks_finish_dynamic_symbol): Likewise. (_bfd_mips_elf_finish_dynamic_sections): Likewise. Move the initial assignment of G to the block that uses it; it is used for an unrelated purpose later. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From aurelien at aurel32 dot net 2009-11-01 10:44 --- The problem has been introduced by this (huge) changeset: 2008-08-07 Richard Sandiford * elf-bfd.h (elf_backend_data): Add a "rela_plts_and_copies_p" field. * elfxx-target.h (elf_backend_rela_plts_and_copies_p): New macro. (elfNN_bed): Use it. * elf.c (_bfd_elf_get_synthetic_symtab): Use rela_plts_and_copies_p instead of default_use_rela_p to choose between ".rel.plt" and ".rela.plt". * elflink.c (_bfd_elf_create_dynamic_sections): Use rela_plts_and_copies_p instead of default_use_rela_p to choose between ".rel.plt" and ".rela.plt", and between ".rel.bss" and ".rela.bss". 2008-08-07 Richard Sandiford * elf-bfd.h (MIPS_ELF_TDATA): New elf_object_id. * elf32-mips.c (bfd_elf32_mkobject): Define. * elf64-mips.c (bfd_elf64_mkobject): Likewise. * elfn32-mips.c (bfd_elf32_mkobject): Likewise. * elfxx-mips.h (_bfd_mips_elf_mkobject): Declare. * elfxx-mips.c (is_mips_elf): New macro. (_bfd_mips_elf_mkobject): New function. (_bfd_mips_elf_final_link): Use is_mips_elf. (_bfd_mips_elf_merge_private_bfd_data): Likewise. 2008-08-07 Richard Sandiford * elfxx-mips.c (mips_elf_record_relocs): Defer allocation of a global GOT entry when deferring allocation of dynamic relocations. (allocate_dynrelocs): When allocating deferred dynamic relocations, also do the deferred allocation of a GOT entry. 2008-08-07 Richard Sandiford * elfxx-mips.c (mips_got_info): Add a "reloc_only_gotno" field. (mips_elf_got_section): Delete. (mips_elf_sort_hash_table): Use g->reloc_only_gotno to decide how many reloc-only entries there are. (mips_elf_count_got_symbols): Adjust g->reloc_only_gotno as well as g->global_gotno. (mips_elf_make_got_per_bfd): Initialize reloc_only_gotno. (mips_elf_multi_got): Likewise. Use gg->reloc_only_gotno rather than gg->assigned_gotno to store the number of reloc-only GOT entries. (mips_elf_create_got_section): Remove the MAYBE_EXCLUDE parameter. Initialize reloc_only_gotno. (mips_elf_calculate_relocation): Check htab->got_info instead of dynobj when deciding whether to call mips_elf_adjust_gp, (_bfd_mips_elf_create_dynamic_sections): Adjust the call to mips_elf_create_got_section. (mips_elf_record_relocs): Likewise. Remove redundant "dynobj == NULL" code. Do not use mips_elf_create_got_section or mips_elf_record_global_got_symbol for R_MIPS_32, R_MIPS_REL32 and R_MIPS_64; limit global_got_area to GGA_RELOC_ONLY instead. (_bfd_mips_elf_finish_dynamic_symbol): Use htab->sgot instead of mips_elf_got_section. (_bfd_mips_vxworks_finish_dynamic_symbol): Likewise. (_bfd_mips_elf_finish_dynamic_sections): Likewise. Move the initial assignment of G to the block that uses it; it is used for an unrelated purpose later. 2008-08-07 Richard Sandiford * elfxx-mips.c (count_section_dynsyms): Move before the new first use. (mips_elf_sort_hash_table): Take the output bfd as a parameter. Remove the MAX_LOCAL parameter. Exit early if there are no dynamic symbols, if there is no dynobj, or if there is no GOT section. Use count_section_dynsyms instead of MAX_LOCAL. Assert == rather than <= when checking hsd.max_unref_got_dynindx. Also assert that g->global_gotno is right. (mips_elf_count_forced_local_got_symbols): Rename to... (mips_elf_count_got_symbols): ...and count global GOT entries too. Set the global_got_area of a forced-local GGA_RELOC_ONLY symbol to GGA_NONE. (mips_elf_multi_got): Don't sort the symbol table. (mips_elf_lay_out_got): Likewise. Use mips_elf_count_got_symbols to count the number of global GOT entries. (_bfd_mips_elf_final_link): Unconditionally call mips_elf_sort_hash_table. 2008-08-07 Richard Sandiford * elfxx-mips.c (GGA_NORMAL, GGA_RELOC_ONLY, GGA_NONE): New macros. (mips_elf_link_hash_entry): Add a "global_got_area" field. (mips_elf_link_hash_newfunc): Initialize it. (mips_elf_sort_hash_table_f): Use h->global_got_area instead of h->root.got.offset. Do not handle forced_local symbols specially. (mips_elf_record_global_got_symbol): Set h->global_got_area instead of h->root.got.offset. (mips_elf_recreate_got): Assert that h->global_got_area == GGA_NONE for indirect and warning symbols. (mips_elf_count_forced_local_got_symbols): Change the argument from a "elf_link_hash_entry" to "mips_elf_link_hash_entry". Use and set h->global_got_area instead of h->root.got.offset. Set it to
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From aurelien at aurel32 dot net 2009-10-29 08:33 --- Unfortunately, bisecting takes time, especially on my slow machine. What I can tell for now is that the CVS from 2008/07/03 works the CVS from 2008/08/14 does not work. About the gcc 4.3 issue not activating pie with the -pie flag, it only happens if the output filename contains fpie. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
[Bug ld/10858] ld generate broken PIE binaries on MIPS
--- Additional Comments From amodra at bigpond dot net dot au 2009-10-29 03:47 --- Please identify the version of your working binutils. It would be really useful to know which patch introduced the failure, or failing that, as narrow a date range as you can manage easily. -- http://sourceware.org/bugzilla/show_bug.cgi?id=10858 --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ bug-binutils mailing list bug-binutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-binutils
