[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2011-02-13 Thread amodra at gmail dot com 
http://sourceware.org/bugzilla/show_bug.cgi?id=11931

Alan Modra amodra at gmail dot com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #10 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2010-09-10 01:23:29 UTC ---
Subject: Bug 11931

CVSROOT:/cvs/src
Module name:src
Changes by: amo...@sourceware.org   2010-09-10 01:23:13

Modified files:
ld : ChangeLog ldlang.c ldlang.h 
ld/emultempl   : xtensaelf.em 

Log message:
PR ld/11931
* ldlang.h (lang_for_each_statement_worker): Declare.
* ldlang.c (lang_for_each_statement_worker): Make global.  Don't
recurse into children of output_section_statement with constraint
set to -1.
(print_assignment): Handle NULL output_section-bfd_section.
(lang_size_sections_1): Ignore output section statement address
when constraint is -1.
* emultempl/xtensaelf.em (lang_for_each_statement_worker): Delete.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=srcr1=1.2184r2=1.2185
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldlang.c.diff?cvsroot=srcr1=1.338r2=1.339
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldlang.h.diff?cvsroot=srcr1=1.88r2=1.89
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/emultempl/xtensaelf.em.diff?cvsroot=srcr1=1.25r2=1.26



--- Comment #11 from Alan Modra amodra at gmail dot com 2011-02-14 00:34:21 
UTC ---
Fixed months ago.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2011-02-13 Thread Matthew.Gretton-Dann at arm dot com 
http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- Comment #12 from Matthew.Gretton-Dann at arm dot com 2011-02-14 00:41:39 
UTC ---
Hi,

I am out of the office on Friday 11th February 2011, and will not be reading
email.

If you have an urgent issue please get in touch with Roger Teague.

Otherwise, I will get back to you as soon as possible after I am back in the
office on Monday 14th February 2011.

Thanks,

Matt

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-09-09 Thread nickc at redhat dot com 

--- Additional Comments From nickc at redhat dot com  2010-09-09 10:16 
---
Hi Alan,

 Nick, I think you're just papering over the real problem here.  Our handling 
 of
 assignments inside ONLY_IF... sections is quite broken.  To see more problems,
 try the link with a map file.  :-(

I suspected as much when I wrote the patch.  Silly me for looking at the issue
as the last thing in the day...

Cheers
  Nick




-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-09-09 Thread nickc at redhat dot com 

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2010-09-09 
10:38 ---
Subject: Bug 11931

CVSROOT:/cvs/src
Module name:src
Changes by: ni...@sourceware.org2010-09-09 10:37:48

Modified files:
gas/testsuite  : ChangeLog 
gas/testsuite/gas/mn10300: basic.exp 
Added files:
gas/testsuite/gas/mn10300: pr11931.d pr11931.s 

Log message:
PR gas/11931
* gas/mn10300/pr11931.s: New file: Test case.
* gas/mn10300/pr11931.d: New file: Expected output.
* gas/mn10300/basic.exp: Run the new test.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=srcr1=1.1730r2=1.1731
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/mn10300/pr11931.d.diff?cvsroot=srcr1=NONEr2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/mn10300/pr11931.s.diff?cvsroot=srcr1=NONEr2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/mn10300/basic.exp.diff?cvsroot=srcr1=1.15r2=1.16


--- Additional Comments From nickc at redhat dot com  2010-09-09 10:42 
---
Oops - please ignore that commit - it was for PR 11973, not this PR.

Cheers
  Nick


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-09-09 Thread amodra at gmail dot com 

--- Additional Comments From amodra at gmail dot com  2010-09-09 13:01 
---
Created an attachment (id=4973)
 -- (http://sourceware.org/bugzilla/attachment.cgi?id=4973action=view)
proposed fix

Also late in the day so possibly suspect.  Running tests overnight.

-- 
   What|Removed |Added

Attachment #4971 is|0   |1
   obsolete||
 AssignedTo|mgretton at sourceware dot  |amodra at gmail dot com
   |org |


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-09-08 Thread nickc at redhat dot com 

--- Additional Comments From nickc at redhat dot com  2010-09-08 17:02 
---
Created an attachment (id=4971)
 -- (http://sourceware.org/bugzilla/attachment.cgi?id=4971action=view)
Skip abort for linker created symbols.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-09-08 Thread amodra at gmail dot com 

--- Additional Comments From amodra at gmail dot com  2010-09-09 02:06 
---
Nick, I think you're just papering over the real problem here.  Our handling of
assignments inside ONLY_IF... sections is quite broken.  To see more problems,
try the link with a map file.  :-(

The trouble is that we create symbols in before_allocation, and finish setting
them up properly in lang_size_sections, but lang_size_sections doesn't look
inside an output section statement that has no output bfd section.

I'm not sure what the best fix is.  Hacking elf32.em like the following stops
the symbol being created in the first place.

static void
gld${EMULATION_NAME}_find_statement_assignment (lang_statement_union_type *s)
{
  static lang_output_section_statement_type *curr_os;

  if (s-header.type == lang_output_section_statement_enum)
curr_os = s-output_section_statement;
  else if (curr_os != NULL
curr_os-header.next == s)
curr_os = NULL;

  if (s-header.type == lang_assignment_statement_enum
   (curr_os == NULL
  || curr_os-constraint != -1))
gld${EMULATION_NAME}_find_exp_assignment (s-assignment_statement.exp);
}


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-08-20 Thread mgretton at sourceware dot org 

--- Additional Comments From mgretton at sourceware dot org  2010-08-20 
15:44 ---
Created an attachment (id=4944)
 -- (http://sourceware.org/bugzilla/attachment.cgi?id=4944action=view)
Assembler source to generate object file to link


-- 
   What|Removed |Added

 AssignedTo|unassigned at sources dot   |mgretton at sourceware dot
   |redhat dot com  |org
 Status|NEW |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-08-20 Thread mgretton at sourceware dot org 


-- 
   What|Removed |Added

   Attachment #4944|application/octet-stream|text/plain
  mime type||


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug ld/11931] Segfault in ld (elf_link_output_extsym) when defining symbols with a constraint on a non-existent section

2010-08-20 Thread mgretton at sourceware dot org 

--- Additional Comments From mgretton at sourceware dot org  2010-08-20 
15:45 ---
Created an attachment (id=4945)
 -- (http://sourceware.org/bugzilla/attachment.cgi?id=4945action=view)
Linker script required to reproduce issue.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11931

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils