[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2023-06-23 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #22 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by Alan Modra :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0ec2cde4f48fbe19c72d0963101888743015041e

commit 0ec2cde4f48fbe19c72d0963101888743015041e
Author: Alan Modra 
Date:   Fri Jun 23 11:36:13 2023 +0930

lto test fails with -fno-inline in CFLAGS

Putting -fno-inline in CFLAGS results in these failures.
FAIL: Build liblto-17b.so 1
FAIL: PR ld/12365
FAIL: PR ld/13183

* ld-plugin/lto.exp: Add -finline to compiler flags in some tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2016-03-01 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #20 from cvs-commit at gcc dot gnu.org  ---
The master branch has been updated by H.J. Lu :

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ef621b15e0b14f8fc0dc5940bc6b14a9aaa40ea3

commit ef621b15e0b14f8fc0dc5940bc6b14a9aaa40ea3
Author: H.J. Lu 
Date:   Tue Mar 1 12:39:49 2016 -0800

Update PR ld/12365 test for GCC 6

PR ld/12365 test is to verify that linker catches the reference to
undefined symbol error caused by a GCC bug.  Since the GCC bug has
been fixed in GCC 6, update the test to verify that there is no
reference to undefined symbol in executable

* testsuite/ld-plugin/lto.exp: Update PR ld/12365 test for GCC 6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2015-02-04 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #18 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org ---
The master branch has been updated by H.J. Lu h...@sourceware.org:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8962a307ae3dd59166a4a6dc4e60a4da880686cd

commit 8962a307ae3dd59166a4a6dc4e60a4da880686cd
Author: H.J. Lu hjl.to...@gmail.com
Date:   Wed Feb 4 04:34:11 2015 -0800

Pass -flto-partition=none to the PR ld/12365 test

*  ld-plugin/lto.exp: Pass -flto-partition=none to the PR
ld/12365 test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2015-02-03 Thread cvs-commit at gcc dot gnu.org
https://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #16 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org ---
The master branch has been updated by H.J. Lu h...@sourceware.org:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=60f79275127603876d94da4bf4e3f6212903b407

commit 60f79275127603876d94da4bf4e3f6212903b407
Author: H.J. Lu hjl.to...@gmail.com
Date:   Tue Feb 3 09:03:23 2015 -0800

Mark the plugin symbol undefined

LTO may optimize out a plugin symbol, which is also referenced by a
non-IR file.  When that happens, we should mark the plugin symbol
undefined.  It isn't the problem since LTO already determined the
symbols in the non-IR file aren't used.

bfd/

PR ld/12365
PR ld/14272
* elflink.c (_bfd_elf_fix_symbol_flags): Mark the plugin symbol
undefined if it is referenced from a non-IR file.

ld/testsuite/

PR ld/12365
* ld-plugin/pr12365a.c: New file.
* ld-plugin/pr12365b.c: Likewise.
* ld-plugin/pr12365c.c: Likewise.

* ld-plugin/lto.exp (lto_link_tests): Prepare for the PR ld/12365
test.
Run the PR ld/12365 test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2015-02-03 Thread hjl.tools at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=12365

H.J. Lu hjl.tools at gmail dot com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
Version|unspecified |2.26 (HEAD)
 Resolution|FIXED   |---

--- Comment #15 from H.J. Lu hjl.tools at gmail dot com ---
It is completely fixed. From

https://sourceware.org/bugzilla/show_bug.cgi?id=14272#c18

After the fix, the error message becomes:

Executing on host: sh -c {gcc
-B/export/build/gnu/binutils-lto/build-x86_64-linux/ld/tmpdir/gas/
-B/export/build/gnu/binutils-lto/build-x86_64-linux/ld/tmpdir/ld/
-L/usr/local/x86_64-unknown-linux-gnu/lib64 -L/usr/local/lib64 -L/lib64
-L/usr/lib64 -L/usr/local/x86_64-unknown-linux-gnu/lib -L/usr/local/lib -L/lib
-L/usr/lib -O2 -flto -fuse-linker-plugin tmpdir/pr12365a.o tmpdir/pr12365b.o
tmpdir/pr12365c.o 21}  /dev/null ld.tmp (timeout = 300)
spawn [open ...]^M
/tmp/cc6BNJK9.ltrans0.ltrans.o: In function `main':
cc6BNJK9.ltrans0.o:(.text.startup+0x197): undefined reference to `my_bcopy'
collect2: error: ld returned 1 exit status
/tmp/cc6BNJK9.ltrans0.ltrans.o: In function `main':
cc6BNJK9.ltrans0.o:(.text.startup+0x197): undefined reference to `my_bcopy'
collect2: error: ld returned 1 exit status
PASS: PR ld/12365

The difference is my_bcopy should be simply undefined, not defined in
a discarded section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-05-07 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #12 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-05-07 14:27:00 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:da...@sourceware.org2011-05-07 14:26:57

Modified files:
bfd: coffgen.c ChangeLog 

Log message:
PR ld/12365
* coffgen.c (coff_write_symbol): Assume input section is its own
output section if output_section member not set.
(coff_write_alien_symbol): Likewise.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/coffgen.c.diff?cvsroot=srcr1=1.78r2=1.79
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5333r2=1.5334

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-05-07 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #13 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-05-07 14:29:13 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:da...@sourceware.org2011-05-07 14:29:10

Modified files:
bfd: cofflink.c ChangeLog 
ld/scripttempl : pe.sc pep.sc 
ld : ChangeLog 
ld/testsuite/ld-plugin: plugin-7.d plugin-8.d 
ld/testsuite   : ChangeLog 

Log message:
bfd/ChangeLog:

PR ld/12365
* cofflink.c (bfd_coff_link_input_bfd): Check for and warn about
references to symbols defined in discarded sections.

ld/ChangeLog:

PR ld/12365
* scripttempl/pe.sc (__rt_psrelocs_start): New symbol definition.
(__rt_psrelocs_end): Likewise.
(__rt_psrelocs_size): Likewise difference between the above.
(__RUNTIME_PSEUDO_RELOC_LIST_END__): Move outside .rdata section
immediately after end of pseudo-reloc data.
(___RUNTIME_PSEUDO_RELOC_LIST_END___): Likewise.
(__RUNTIME_PSEUDO_RELOC_LIST__): Move outside .rdata section and
calculate backward from list end.
(___RUNTIME_PSEUDO_RELOC_LIST___): Likewise.
* scripttempl/pep.sc: Likewise.

ld/testsuite/ChangeLog:

PR ld/12365
* ld-plugin/plugin-7.d: Allow underscore in error message.
* ld-plugin/plugin-8.d: Likewise.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/cofflink.c.diff?cvsroot=srcr1=1.75r2=1.76
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5334r2=1.5335
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/scripttempl/pe.sc.diff?cvsroot=srcr1=1.25r2=1.26
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/scripttempl/pep.sc.diff?cvsroot=srcr1=1.14r2=1.15
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=srcr1=1.2327r2=1.2328
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-7.d.diff?cvsroot=srcr1=1.3r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-8.d.diff?cvsroot=srcr1=1.3r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=srcr1=1.1397r2=1.1398

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-27 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #10 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-04-27 07:17:51 UTC ---
CVSROOT:/cvs/src
Module name:src
Branch: binutils-2_21-branch
Changes by:amo...@sourceware.org2011-04-27 07:17:45

Modified files:
bfd: ChangeLog bfd-in2.h bfd.c coff-aux.c elf-bfd.h 
 elf.c elf32-i386.c elf32-ppc.c elf32-sparc.c 
 elf64-ppc.c elf64-sparc.c elf64-x86-64.c 
 elfcode.h elflink.c linker.c opncls.c plugin.c 
 simple.c xcofflink.c 
gas/testsuite  : ChangeLog 
gas/testsuite/gas/elf: elf.exp 
include: ChangeLog bfdlink.h 
ld : ChangeLog ld.texinfo ldfile.c ldlang.c ldlang.h 
 ldmain.c lexsup.c plugin.c plugin.h 
ld/testsuite   : ChangeLog 
ld/testsuite/ld-plugin: plugin-7.d plugin-8.d plugin.exp 
Added files:
gas/testsuite/gas/elf: section9.d section9.s 
ld/testsuite/ld-plugin: plugin-12.d 
ld/testsuite/ld-unique: unique.exp unique.s unique_empty.s 
unique_shared.s 

Log message:
PR ld/12696
PR ld/12672
PR ld/12507
PR ld/12365
PR 10549
Backport fixes for these PRs.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.5180.2.26r2=1.5180.2.27
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd-in2.h.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.522.2.1r2=1.522.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.114.2.1r2=1.114.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/coff-aux.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.10r2=1.10.10.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf-bfd.h.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.313.2.1r2=1.313.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.524.2.1r2=1.524.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-i386.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.241r2=1.241.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-ppc.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.290.2.2r2=1.290.2.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-sparc.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.94r2=1.94.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-ppc.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.339.2.7r2=1.339.2.8
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-sparc.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.124r2=1.124.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf64-x86-64.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.202r2=1.202.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elfcode.h.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.103r2=1.103.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.388.2.1r2=1.388.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/linker.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.77.2.1r2=1.77.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/opncls.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.66r2=1.66.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/plugin.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.9.2.1r2=1.9.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/simple.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.34r2=1.34.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/xcofflink.c.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.76.2.1r2=1.76.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.1802.2.8r2=1.1802.2.9
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/elf/section9.d.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=NONEr2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/elf/section9.s.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=NONEr2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/elf/elf.exp.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.69.2.1r2=1.69.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/ChangeLog.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.510.2.1r2=1.510.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/bfdlink.h.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.82r2=1.82.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1..2.18r2=1..2.19
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ld.texinfo.diff?cvsroot=srconly_with_tag=binutils-2_21-branchr1=1.267.2.1r2=1.267.2.2

[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-27 Thread amodra at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

Alan Modra amodra at gmail dot com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #11 from Alan Modra amodra at gmail dot com 2011-04-27 07:40:55 
UTC ---
fixed

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-24 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #9 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-04-24 10:02:19 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:amo...@sourceware.org2011-04-24 10:02:14

Modified files:
include: ChangeLog bfdlink.h 
bfd: ChangeLog coff-aux.c linker.c elflink.c 
ld : ChangeLog ldmain.c plugin.c 

Log message:
PR ld/12365
PR ld/12696
include/
* bfdlink.h (ENUM_BITFIELD): Define.
(struct bfd_link_hash_entry): Make type a bitfield.  Add non_ir_ref.
(struct bfd_link_callbacks notice): Pass bfd_link_hash_entry pointer
rather than name.
bfd/
* coff-aux.c (coff_m68k_aux_link_add_one_symbol): Update notice call.
* linker.c (_bfd_link_hash_newfunc): Clear bitfields.
(_bfd_generic_link_add_one_symbol): Update notice call.
* elflink.c (_bfd_elf_merge_symbol): Don't skip weak redefs when
it is a redef of an IR symbol in a real BFD.
ld/
* ldmain.c (notice): Delete name param, add h.
* plugin.c (plugin_notice): Likewise.  Set non_ir_ref.  Handle
redefinitions of IR symbols in real BFDs.
(plugin_multiple_definition, plugin_multiple_common): Delete.
(non_ironly_hash, init_non_ironly_hash): Delete.
(is_visible_from_outside): Traverse entry_symbol chain.
(get_symbols): Use non_ir_ref flag rather than hash lookup.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/ChangeLog.diff?cvsroot=srcr1=1.527r2=1.528
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/bfdlink.h.diff?cvsroot=srcr1=1.83r2=1.84
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5318r2=1.5319
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/coff-aux.c.diff?cvsroot=srcr1=1.10r2=1.11
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/linker.c.diff?cvsroot=srcr1=1.80r2=1.81
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=srcr1=1.401r2=1.402
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=srcr1=1.2321r2=1.2322
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldmain.c.diff?cvsroot=srcr1=1.153r2=1.154
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.c.diff?cvsroot=srcr1=1.32r2=1.33

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-19 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #7 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-04-20 00:11:37 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:amo...@sourceware.org2011-04-20 00:11:33

Modified files:
include: ChangeLog bfdlink.h 
bfd: ChangeLog elflink.c linker.c simple.c 
 xcofflink.c 
ld : ChangeLog ldmain.c plugin.c 

Log message:
PR ld/12365
include/
* bfdlink.h (struct bfd_link_callbacks): Modify multiple_definition
and multiple_common parameters to pass in a bfd_link_hash_entry
pointer rather than name,bfd etc. found in the hash entry.
bfd/
* elflink.c (_bfd_elf_merge_symbol): Update multiple_common calls.
* linker.c (_bfd_generic_link_add_one_symbol): Likewise.  Call
multiple_definition regardless of allow_multiple_definition.
* simple.c (simple_dummy_multiple_definition): Update.
* xcofflink.c (xcoff_link_add_symbols): Update multiple_definition
calls.
ld/
* ldmain.c (multiple_definition): Take a bfd_link_hash_entry
pointer arg rather than name, obfd, osec, oval.  Add code
removed from linker.c.  Hack around xcofflink.c oddity in
passing NULL nbfd.
(multiple_common): Similarly.
* plugin.c (orig_allow_multiple_defs): Delete.
(plugin_call_all_symbols_read): Don't twiddle allow_multiple_definition.
(plugin_multiple_definition): Update.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/ChangeLog.diff?cvsroot=srcr1=1.526r2=1.527
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/bfdlink.h.diff?cvsroot=srcr1=1.82r2=1.83
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5308r2=1.5309
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=srcr1=1.397r2=1.398
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/linker.c.diff?cvsroot=srcr1=1.78r2=1.79
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/simple.c.diff?cvsroot=srcr1=1.34r2=1.35
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/xcofflink.c.diff?cvsroot=srcr1=1.78r2=1.79
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=srcr1=1.2316r2=1.2317
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldmain.c.diff?cvsroot=srcr1=1.151r2=1.152
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.c.diff?cvsroot=srcr1=1.30r2=1.31

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-19 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #8 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-04-20 00:22:11 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:amo...@sourceware.org2011-04-20 00:22:09

Modified files:
bfd: ChangeLog elfcode.h elflink.c linker.c 
ld : ChangeLog ldfile.c ldmain.c plugin.c plugin.h 

Log message:
PR ld/12365
bfd/
* elfcode.h (elf_slurp_symbol_table): Put common plugin IR symbols
in their own common section.
* elflink.c (elf_link_add_object_symbols): Likewise.
* linker.c (generic_link_check_archive_element): Don't lose flags
if common section is pre-existing.
(_bfd_generic_link_add_one_symbol): Likewise.
ld/
* ldfile.c (ldfile_try_open_bfd): Move code creating and switching
to plugin IR BFD..
* ldmain.c (add_archive_element): ..and similar code here..
* plugin.c (plugin_maybe_claim): ..to here.  New function.
(plugin_call_claim_file): Make static.
(asymbol_from_plugin_symbol): Set ELF st_shndx for common syms.
(plugin_multiple_common): New function.
(plugin_call_all_symbols_read): Hook in plugin_multiple_common.
* plugin.h (plugin_call_claim_file): Don't declare.
(plugin_maybe_claim): Declare.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=srcr1=1.5309r2=1.5310
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elfcode.h.diff?cvsroot=srcr1=1.105r2=1.106
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=srcr1=1.398r2=1.399
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/linker.c.diff?cvsroot=srcr1=1.79r2=1.80
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=srcr1=1.2317r2=1.2318
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldfile.c.diff?cvsroot=srcr1=1.62r2=1.63
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldmain.c.diff?cvsroot=srcr1=1.152r2=1.153
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.c.diff?cvsroot=srcr1=1.31r2=1.32
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.h.diff?cvsroot=srcr1=1.8r2=1.9

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-17 Thread cvs-commit at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #4 from cvs-commit at gcc dot gnu.org cvs-commit at gcc dot 
gnu.org 2011-04-17 23:15:18 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:amo...@sourceware.org2011-04-17 23:15:13

Modified files:
bfd: bfd.c bfd-in2.h elflink.c opncls.c 
ld : ldfile.c ldmain.c ldlang.c plugin.h plugin.c 
ld/testsuite/ld-plugin: plugin-7.d plugin-8.d plugin.exp 
Added files:
ld/testsuite/ld-plugin: plugin-12.d 

Log message:
PR ld/12365
PR ld/12672
bfd/
* bfd.c (BFD_PLUGIN): Define.
(BFD_FLAGS_SAVED, BFD_FLAGS_FOR_BFD_USE_MASK): Add BFD_PLUGIN.
* bfd-in2.h: Regenerate.
* elflink.c (elf_link_output_extsym): Strip undefined plugin syms.
* opncls.c (bfd_make_readable): Don't lose original bfd flags.
ld/
* ldfile.c (ldfile_try_open_bfd): Don't attempt any plugin action
when no_more_claiming.
* ldmain.c (add_archive_element): Likewise.
(multiple_definition): Remove plugin_multiple_definition call.
(notice): Remove plugin_notice call.
* ldlang.c (lang_list_insert_after, void lang_list_remove_tail): Move.
Delete prototype.
(plugin_insert): New static var.
(open_input_bfds): Only rescan libs after plugin insert point.
(lang_gc_sections): Omit plugin claimed files.
(lang_process): Set plugin_insert.  Only rescan when plugin adds
objects.
* plugin.h (no_more_claiming): Declare.
(plugin_notice, plugin_multiple_definition): Don't declare.
* plugin.c: Formatting.
(orig_notice_all, orig_allow_multiple_defs, orig_callbacks,
plugin_callbacks): New static vars.
(no_more_claiming): Make global.
(plugin_cached_allow_multiple_defs): Delete.
(plugin_get_ir_dummy_bfd): Set SEC_EXCLUDE on dummy .text section,
use newer bfd_make_section variant.  Make COMMON section too.
Error handling.  Correct setting of gp size.
(asymbol_from_plugin_symbol): Properly cast last arg of concat.
(message): Likewise for ACONCAT.
(asymbol_from_plugin_symbol): Use our COMMON section.
(get_symbols): When report_plugin_symbols, show visibility too.
(init_non_ironly_hash): Move.  Don't test non_ironly_hash.
(plugin_load_plugins): Save state of linker callbacks, set up to
call plugin_notice instead.  Call init_non_ironly_hash here.
(plugin_call_all_symbols_read): Set plugin_multiple_definition in
plugin callbacks.
(plugin_notice): Rewrite.
(plugin_multiple_definition): Make static, call original callback.
ld/testsuite/
* ld-plugin/plugin-7.d: Adjust for plugin changes.
* ld-plugin/plugin-8.d: Likewise.
* ld-plugin/plugin.exp: Pass --verbose=2 for visibility test, and
compare ld output to..
* ld-plugin/plugin-12.d: New.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd.c.diff?cvsroot=srcr1=1.115r2=1.116
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/bfd-in2.h.diff?cvsroot=srcr1=1.532r2=1.533
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=srcr1=1.396r2=1.397
http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/opncls.c.diff?cvsroot=srcr1=1.66r2=1.67
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldfile.c.diff?cvsroot=srcr1=1.61r2=1.62
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldmain.c.diff?cvsroot=srcr1=1.150r2=1.151
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldlang.c.diff?cvsroot=srcr1=1.365r2=1.366
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.h.diff?cvsroot=srcr1=1.7r2=1.8
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.c.diff?cvsroot=srcr1=1.29r2=1.30
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-12.d.diff?cvsroot=srcr1=NONEr2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-7.d.diff?cvsroot=srcr1=1.1r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-8.d.diff?cvsroot=srcr1=1.1r2=1.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin.exp.diff?cvsroot=srcr1=1.6r2=1.7

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-17 Thread amodra at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #6 from Alan Modra amodra at gmail dot com 2011-04-17 23:27:33 
UTC ---
Fixed for anything but common IR-only symbols.  These will require a bit more
work in the linker.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-04-16 Thread amodra at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

Alan Modra amodra at gmail dot com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||amodra at gmail dot com
 AssignedTo|unassigned at sources dot   |amodra at gmail dot com
   |redhat.com  |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-01-05 Thread hjl.tools at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

H.J. Lu hjl.tools at gmail dot com changed:

   What|Removed |Added

 Status|NEW |WAITING
 CC||hjl.tools at gmail dot com

--- Comment #1 from H.J. Lu hjl.tools at gmail dot com 2011-01-05 15:19:55 
UTC ---
Please provide a complete testcase.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-01-05 Thread hjl.tools at gmail dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

H.J. Lu hjl.tools at gmail dot com changed:

   What|Removed |Added

 Status|WAITING |NEW

--- Comment #2 from H.J. Lu hjl.tools at gmail dot com 2011-01-05 15:44:18 
UTC ---
Works for me on hjl/lto-mixed branch at

http://git.kernel.org/?p=devel/binutils/hjl/x86.git;a=summary

[...@gnu-32 testsuite]$ ../xgcc -B../
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/memops-asm*.c
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/lib/main.c
-O2 -fuse-linker-plugin -flto
/tmp/ccUDWDxu.ltrans0.ltrans.o: In function `main':
ccUDWDxu.ltrans0.o:(.text.startup+0x173): undefined reference to `my_bcopy'
collect2: ld returned 1 exit status
[...@gnu-32 testsuite]$

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-01-05 Thread davek at gcc dot gnu.org
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

Dave Korn davek at gcc dot gnu.org changed:

   What|Removed |Added

 CC||davek at gcc dot gnu.org

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/12365] undefined references produced by linker plugin are silently ignored

2011-01-05 Thread jh at suse dot cz
http://sourceware.org/bugzilla/show_bug.cgi?id=12365

--- Comment #3 from Jan Hubicka jh at suse dot cz 2011-01-05 20:23:59 UTC ---
Hmm, wonder how testcases for linker plugin related bugs should look like.  All
I can think of is the GCC version + testcase that is in testsuite anyway.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils