Re: Strange singular/plural messages in 2.33.90

2020-01-24 Thread Nick Clifton
Hi Göran,

> While translating 2.33.90 to Swedish, I came across this code from readelf.c:
> 
> warn (ngettext ("debuginfod: Corrupt note: only %ld byte remains, "
>   "not enough for a full note\n",
>   "Corrupt note: only %ld bytes remain, "
>   "not enough for a full note\n",
>   data_remaining),
> (long) data_remaining);
> 
> It seems strange you would want the "debuginfod" prefix only in the
> case of singular, while the plural form has no such prefix.  I suspect
> that is a mistake.
> 
> The code snippet appears twice.

Thanks for reporting this.  I have checked in the obvious fix.

Cheers
  Nick

binutils/ChangeLog
2020-01-24  Nick Clifton  

* readelf.c (get_build_id): Fix warning messages about corrupt
notes.




Strange singular/plural messages in 2.33.90

2020-01-23 Thread Göran Uddeborg
While translating 2.33.90 to Swedish, I came across this code from readelf.c:

warn (ngettext ("debuginfod: Corrupt note: only %ld byte remains, "
"not enough for a full note\n",
"Corrupt note: only %ld bytes remain, "
"not enough for a full note\n",
data_remaining),
  (long) data_remaining);

It seems strange you would want the "debuginfod" prefix only in the
case of singular, while the plural form has no such prefix.  I suspect
that is a mistake.

The code snippet appears twice.