Re: modify chmod
Re: modify chmod
jeff.liu wrote: ... http://git.sv.gnu.org/cgit/coreutils.git/plain/HACKING Sure, that's sounds interesting. For the copyright assignment, Oracle did, it as a company, and the assignment covers all the employees. :-) Confirmed. That was easy ;-) Just one thing need to statement here, does it has a deadline? No. But if someday you realize you're not going to do it after all, please give us a heads-up. I can not promise it could be done in a precise time, I am coding in my spare time for fun. You'll still need to file an individual copyright assignment.
Re: modify chmod
Re: Incorrect use of USE_XATTR in coreutils-8.4
I'm going to push this which uses the newly parameterized location of lib/config.h commit 6b5b05f3bf08faccf0ee3098722b0ae64f7019ed Author: Pádraig Brady p...@draigbrady.com Date: Thu Jan 28 18:12:20 2010 + maint: use $(CONFIG_INCLUDE) rather than the hardcoding lib/config.h * tests/check.mk (TESTS_ENVIRONMENT): Use the generated CONFIG_INCLUDE variable. Note $(abs_builddir)/$(CONFIG_HEADER) also currently works, but $(CONFIG_HEADER) is deprecated and may not be generated in future. $(CONFIG_INCLUDE) was made available by gnulib in commit, 22970f8a, syntax-check: detect incorrect boolean macro values in config.h diff --git a/tests/check.mk b/tests/check.mk index 86f7dc2..d3b08e0 100644 --- a/tests/check.mk +++ b/tests/check.mk @@ -79,7 +79,7 @@ TESTS_ENVIRONMENT = \ host_triplet='$(host_triplet)' \ srcdir='$(srcdir)' \ top_srcdir='$(top_srcdir)' \ - CONFIG_HEADER='$(abs_top_builddir)/lib/config.h' \ + CONFIG_HEADER='$(abs_top_builddir)/$(CONFIG_INCLUDE)' \ CU_TEST_NAME=`basename '$(abs_srcdir)'`,`echo $$tst|sed 's,^\./,,;s,/,-,g'` \ CC='$(CC)' \ AWK='$(AWK)' \
Re: join with header line support
On 26/01/10 11:49, Pádraig Brady wrote: There are 2 questions with this. 1. Since this is only specific to --check-order really, perhaps we should add it as a parameter like --check-order=+N where N is the number of lines to skip checks on, and output as header lines. 2. Do we want to output headings from the first file when they don't match the second? I'll push the attached patch (which has a few tweaks) in a while unless others want changes as per the questions above. Pushed. thanks again, Pádraig.
Re: [PATCH] maint: fix an inconsequential mem leak in join
On 27/01/10 16:18, Jim Meyering wrote: Pádraig Brady wrote: valgrind was complaining about definite mem leaks in `join` so I refactored the offending code a little and removed the inconseqential leak (which may mask real leaks in future). ... Subject: [PATCH] maint: fix an inconsequential mem leak in join * src/join.c (join): Refactor the code that checks for misorder at the tail of the files. The most significant change here is that freeline() is called thus silencing a valgrind warning about a definite but inconseqential memory leak. (freeline): Make more general by doing nothing when passed NULL, and setting freed pointers to NULL. Thanks. That had been an annoyance when looking at leak summaries. pushed
Re: join with header line support
According to Pádraig Brady on 2/1/2010 7:08 AM: On 26/01/10 11:49, Pádraig Brady wrote: There are 2 questions with this. 1. Since this is only specific to --check-order really, perhaps we should add it as a parameter like --check-order=+N where N is the number of lines to skip checks on, and output as header lines. That actually sounds like a good idea, of accepting an optional argument (defaulting to 0). And it works well since --check-order has no short option. 2. Do we want to output headings from the first file when they don't match the second? I'm not as sure on this one. I'll push the attached patch (which has a few tweaks) in a while unless others want changes as per the questions above. Pushed. Pushing was reasonable; such changes are good incrementally, anyways. -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net signature.asc Description: OpenPGP digital signature
[PATCH] tests/cp/cp-a-selinux: skip the test if no loopdevices available
Hello, as reported in rhbz #558898 , cp-a-selinux test could fail if there are no loop devices available or if the kernel has no support for loop devices. Other similar tests just skip if the mount or filesystem creation fails. Attached patch does the same for the cp/cp-a-selinux test. Greetings, Ondřej Vašík From 67bc8118e98f99f59d1f601d06c121f3ed2c4f58 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= ova...@redhat.com Date: Mon, 1 Feb 2010 16:29:27 +0100 Subject: [PATCH] tests: cp-a-selinux :skip the test if no loopdevices available * tests/cp/cp-a-selinux: skip the test (instead of fail) if no loopdevices available --- tests/cp/cp-a-selinux |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/cp/cp-a-selinux b/tests/cp/cp-a-selinux index b1359c0..539c512 100755 --- a/tests/cp/cp-a-selinux +++ b/tests/cp/cp-a-selinux @@ -48,12 +48,15 @@ ls -Z f | grep $ctx || fail=1 # Create a file system, then mount it with the context=... option. dd if=/dev/zero of=blob bs=8192 count=200 /dev/null 21 \ - || framework_failure -mkdir mnt|| framework_failure + || skip=1 +mkdir mnt|| skip=1 mkfs -t ext2 -F blob || skip_test_ failed to create an ext2 file system -mount -oloop,context=$ctx blob mnt || framework_failure +mount -oloop,context=$ctx blob mnt || skip=1 +test $skip = 1 \ + skip_test_ insufficient mount/ext2 support + cd mnt || framework_failure echo f || framework_failure -- 1.5.6.1.156.ge903b signature.asc Description: Toto je digitálně podepsaná část zprávy
Re: [RFC] join -t ''
On 26/01/10 12:01, Pádraig Brady wrote: I'm thinking of pushing both the doc change (that join -t '\0' operates on whole line usually) and the new functionality: (that join -t '' always operates on the whole line) as mentioned below... I just pushed that with 2 new tests. NEWS documents the change in behavior as: join -t '' no longer emits an error and instead operates on each line as a whole (even if they contain NUL characters). cheers, Pádraig.
Re: [PATCH] tests/cp/cp-a-selinux: skip the test if no loopdevices available
Ondřej Vašík wrote: as reported in rhbz #558898 , cp-a-selinux test could fail if there are no loop devices available or if the kernel has no support for loop devices. Other similar tests just skip if the mount or filesystem creation fails. Attached patch does the same for the cp/cp-a-selinux test. ... Subject: [PATCH] tests: cp-a-selinux :skip the test if no loopdevices available * tests/cp/cp-a-selinux: skip the test (instead of fail) if no loopdevices available Thanks. That looks fine, so I've pushed it. From f53a0e1062e251baf709552cdde73ce4f6ccf6fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= ova...@redhat.com Date: Mon, 1 Feb 2010 16:29:27 +0100 Subject: [PATCH] tests: cp-a-selinux: skip the test if mounting a loop device fails * tests/cp/cp-a-selinux: Skip the test (instead of fail) if we fail to mount a loop device (e.g., none available). --- tests/cp/cp-a-selinux |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/cp/cp-a-selinux b/tests/cp/cp-a-selinux index 313f132..770dcc4 100755 --- a/tests/cp/cp-a-selinux +++ b/tests/cp/cp-a-selinux @@ -48,12 +48,15 @@ ls -Z f | grep $ctx || fail=1 # Create a file system, then mount it with the context=... option. dd if=/dev/zero of=blob bs=8192 count=200 /dev/null 21 \ - || framework_failure -mkdir mnt|| framework_failure + || skip=1 +mkdir mnt|| skip=1 mkfs -t ext2 -F blob || skip_test_ failed to create an ext2 file system -mount -oloop,context=$ctx blob mnt || framework_failure +mount -oloop,context=$ctx blob mnt || skip=1 +test $skip = 1 \ + skip_test_ insufficient mount/ext2 support + cd mnt || framework_failure echo f || framework_failure -- 1.7.0.rc1.149.g0b0b7
