bug#7241: Possible bug on split ?

2010-10-18 Thread Ulf Zibis

 With split --help I get the information on units like K, KB, M, MB etc.

As split 123m and split 123MB work fine, but split 123mb doesn't, it seems, that the unit 
identifiers only partly work for lower-case letters.


IMO this is a bug, or should be documented more explicit.

What you think?

-Ulf






bug#7239: [PATCH] Update URL of help section on GNU website

2010-10-18 Thread Tobias Quathamer
Hi,

the help section on www.gnu.org has moved. Please consider to apply the
attached patch which uses the current URL.

Regards,
Tobias

-- 
Tobias Quathamer | Right now I'm having amnesia and deja vu at the
Hamburg, Germany | same time. I think I've forgotten this before.

From a96bb375ee99076a5875d23481e980bdedddcb1d Mon Sep 17 00:00:00 2001
From: Tobias Quathamer to...@debian.org
Date: Mon, 18 Oct 2010 17:23:36 +0200
Subject: [PATCH] Update URL of help section on GNU website

---
 src/system.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/system.h b/src/system.h
index 9e14681..74cd342 100644
--- a/src/system.h
+++ b/src/system.h
@@ -598,7 +598,7 @@ emit_ancillary_info (void)
   /* FIXME 2010: use AC_PACKAGE_URL once we require autoconf-2.64 */
   printf (_(%s home page: http://www.gnu.org/software/%s/\n),
   PACKAGE_NAME, PACKAGE);
-  fputs (_(General help using GNU software: http://www.gnu.org/gethelp/\n),
+  fputs (_(General help using GNU software: http://www.gnu.org/help/gethelp.html\n),
  stdout);
   /* Don't output this redundant message for English locales.
  Note we still output for 'C' so that it gets included in the man page.  */
-- 
1.7.1



signature.asc
Description: This is a digitally signed message part


bug#7243: [patch] making md5sum's warnings clearer

2010-10-18 Thread Benno Schulenberg

Hi,

Two years ago I complained about the untranslatability of the warnings
that md5sum prints when it has encountered unexpected things:
http://lists.gnu.org/archive/html/bug-coreutils/2008-09/msg00168.html

Jim asked to come up with a change that doesn't remove information.
I've finally gotten around to making this -- see the attached patch.
In addition to read failures and checksum failures, md5sum now alerts
the user to the number of misformatted checksum lines.  It prints this
line also when '--warn' is not given, because it is so important.

Regards,

Benno

(Please CC, not subscribed.)

-- 
http://www.fastmail.fm - Same, same, but different...

From fc5460ed05561a9754754993f7aadd541eb98c1c Mon Sep 17 00:00:00 2001
From: Benno Schulenberg bensb...@justemail.net
Date: Mon, 18 Oct 2010 22:35:39 +0200
Subject: [PATCH] md5sum: print a summary warning for improperly formatted lines

And remove the now superfluous totals from the other two warnings,
so the plurals will also work in other languages than English.

Signed-off-by: Benno Schulenberg bensb...@justemail.net
---
 src/md5sum.c |   36 +++-
 1 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/src/md5sum.c b/src/md5sum.c
index 10d4fa2..a660e3b 100644
--- a/src/md5sum.c
+++ b/src/md5sum.c
@@ -431,6 +431,7 @@ static bool
 digest_check (const char *checkfile_name)
 {
   FILE *checkfile_stream;
+  uintmax_t n_misformatted_lines = 0;
   uintmax_t n_properly_formatted_lines = 0;
   uintmax_t n_mismatched_checksums = 0;
   uintmax_t n_open_or_read_failures = 0;
@@ -489,6 +490,8 @@ digest_check (const char *checkfile_name)
   ! (is_stdin  STREQ (filename, -))
   hex_digits (hex_digest)))
 {
+  ++n_misformatted_lines;
+
   if (warn)
 {
   error (0, 0,
@@ -571,27 +574,26 @@ digest_check (const char *checkfile_name)
 {
   if (!status_only)
 {
+  if (n_misformatted_lines != 0)
+error (0, 0,
+   ngettext (WARNING: % PRIuMAX  line is improperly formatted,
+ WARNING: % PRIuMAX  lines are improperly formatted,
+ select_plural (n_misformatted_lines)),
+   n_misformatted_lines);
+
   if (n_open_or_read_failures != 0)
 error (0, 0,
-   ngettext (WARNING: % PRIuMAX  of % PRIuMAX
-  listed file could not be read,
- WARNING: % PRIuMAX  of % PRIuMAX
-  listed files could not be read,
- select_plural (n_properly_formatted_lines)),
-   n_open_or_read_failures, n_properly_formatted_lines);
+   ngettext (WARNING: % PRIuMAX  listed file could not be read,
+ WARNING: % PRIuMAX  listed files could not be read,
+ select_plural (n_open_or_read_failures)),
+   n_open_or_read_failures);
 
   if (n_mismatched_checksums != 0)
-{
-  uintmax_t n_computed_checksums =
-(n_properly_formatted_lines - n_open_or_read_failures);
-  error (0, 0,
- ngettext (WARNING: % PRIuMAX  of % PRIuMAX
-computed checksum did NOT match,
-   WARNING: % PRIuMAX  of % PRIuMAX
-computed checksums did NOT match,
-   select_plural (n_computed_checksums)),
- n_mismatched_checksums, n_computed_checksums);
-}
+error (0, 0,
+   ngettext (WARNING: % PRIuMAX  computed checksum did NOT match,
+ WARNING: % PRIuMAX  computed checksums did NOT match,
+ select_plural (n_mismatched_checksums)),
+   n_mismatched_checksums);
 }
 }
 
-- 
1.6.3.3