Re: lib/xtime.h is included twice

2005-03-04 Thread Georg Schwarz
I cannot judge this.
I was just following the example given in
http://cvsweb.NetBSD.org/bsdweb.cgi/src/share/misc/style?rev=HEADcontent-type=text/x-cvsweb-markup

If you think different naming conventions are more appropriate, I don't mind.


 [EMAIL PROTECTED] wrote:
  Dear cvs developers,
  
  for cvs 1.11.19 and earlier, lib/xtime.h is included twice, 
  which breaks
  compiling on IRIX 5.3.
  The following patch prevents this:
  
  --- lib/xtime.h.orig2005-03-01 15:53:11.0 +0100
  +++ lib/xtime.h 2005-03-01 15:54:20.0 +0100
  @@ -12,6 +12,9 @@
* functions
*/
   
  +#ifndef _XTIME_H_
  +#define _XTIME_H_
 ISO C Standard reserves names beginning with underscore and an uppercase
 character, or beginning with two underscores. I recommend changing this to
 something like:
 
 #ifndef XTIME_HEADER_INCLUDEd
 #define XTIME_HEADER_INCLUDEd
 
 (note: the lower-case d at the end is deliberate - it's my technique to
 reduce the chances of a name collision.)
 
 -- 
 Jim Hyslop
 Senior Software Designer
 Leitch Technology International Inc. ( http://www.leitch.com )
 Columnist, C/C++ Users Journal ( http://www.cuj.com/experts )
 
 
 
 
 

-- 
Georg Schwarzhttp://home.pages.de/~schwarz/
 [EMAIL PROTECTED]  +49 178 8545053



___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


lib/xtime.h is included twice

2005-03-03 Thread Georg Schwarz
Dear cvs developers,

for cvs 1.11.19 and earlier, lib/xtime.h is included twice, which breaks
compiling on IRIX 5.3.
The following patch prevents this:

--- lib/xtime.h.orig2005-03-01 15:53:11.0 +0100
+++ lib/xtime.h 2005-03-01 15:54:20.0 +0100
@@ -12,6 +12,9 @@
  * functions
  */
 
+#ifndef _XTIME_H_
+#define _XTIME_H_
+
 #ifdef vms
 # include time.h
 #else /* vms */
@@ -55,3 +58,5 @@
 # endif /* !defined(HAVE_FTIME)  !defined(HAVE_TIMEZONE) */
 
 #endif /* !vms */
+
+#endif /* !_XTIME_H_ */



-- 
Georg Schwarzhttp://home.pages.de/~schwarz/
 [EMAIL PROTECTED] +49 178 8545053


___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs