[bug-gettext] [sr #108864] gettext-0.19.5.1 compiling problem

2015-08-17 Thread INVALID.NOREPLY
Follow-up Comment #2, sr #108864 (project gettext):

Removing the semicolon in file loadmsgcat.c line 788:
  __libc_lock_define_initialized_recursive (static, lock)
is fixing it for me.


___

Reply to this item at:

  http://savannah.gnu.org/support/?108864

___
  Message sent via/by Savannah
  http://savannah.gnu.org/




Re: [bug-gettext] [sr #108864] gettext-0.19.5.1 compiling problem

2015-08-15 Thread Siddhesh Poyarekar
On Sat, Aug 15, 2015 at 10:08:14AM +, Daiki Ueno wrote:
  When i move this line to the bottom of the definitions it compiles.
 
 Yes, this sounds like the right fix, which wouldn't break consistency with the
 Glibc style.

Thanks, can you please post the final fix you checked into gettext to
libc-alpha?

Siddhesh



[bug-gettext] [sr #108864] gettext-0.19.5.1 compiling problem

2015-08-15 Thread Daiki Ueno
Follow-up Comment #1, sr #108864 (project gettext):

Couldn't it also be fixed by removing the last semicolon of:

  __libc_lock_define_initialized_recursive (static, lock);

?

It is possible that the extra semicolon expands to an empty statement, which
pre-C99 compilers complain of. 

 When i move this line to the bottom of the definitions it compiles.

Yes, this sounds like the right fix, which wouldn't break consistency with the
Glibc style.

For reference, here is the original commit introduced this change:
http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=b0ca3de6

___

Reply to this item at:

  http://savannah.gnu.org/support/?108864

___
  Message sent via/by Savannah
  http://savannah.gnu.org/




[bug-gettext] [sr #108864] gettext-0.19.5.1 compiling problem

2015-08-12 Thread INVALID.NOREPLY
URL:
  http://savannah.gnu.org/support/?108864

 Summary: gettext-0.19.5.1 compiling problem
 Project: GNU gettext
Submitted by: pan7
Submitted on: Wed 12 Aug 2015 06:58:32 AM GMT
Category: None
Priority: 5 - Normal
Severity: 3 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
Operating System: None

___

Details:

gettext-runtime\intl\loadmsgcat.c(789): error C2143: syntax error : missing
';' before 'type'

When i move this line to the bottom of the definitions it compiles.
  __libc_lock_define_initialized_recursive (static, lock);

It can't initialize the static variable?





___

Reply to this item at:

  http://savannah.gnu.org/support/?108864

___
  Message sent via/by Savannah
  http://savannah.gnu.org/