relocatable-prog status
Hi, It's been a while (1 year 1/2) since http://lists.debian.org/debian-bsd/2012/05/msg00032.html and I still need to manually patch gnulib before releasing. If I assume the relocatable-prog module is not maintained, that I'm probably the only person on earth to use it, and that I should just drop it from my package, am I wrong? ;) Thanks! Sylvain
one more: error_tail needed printf attribute
FYI, I've just pushed this, too: From 53a617f5e118ec5642daa3da45fcef0bf5593b12 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@fb.com Date: Sun, 20 Oct 2013 11:32:58 -0700 Subject: [PATCH] error: add the printf attribute to a static function * lib/error.c (error_tail): Add the printf attribute, to placate gcc's -Werror=suggest-attribute=format option. --- ChangeLog | 6 ++ lib/error.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 77a1d0d..1855d16 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2013-10-20 Jim Meyering meyer...@fb.com + + error: add the printf attribute to a static function + * lib/error.c (error_tail): Add the printf attribute, to placate + gcc's -Werror=suggest-attribute=format option. + 2013-10-12 Jim Meyering meyer...@fb.com error: make the module depend on vfprintf-posix diff --git a/lib/error.c b/lib/error.c index 865b293..cdc3026 100644 --- a/lib/error.c +++ b/lib/error.c @@ -195,7 +195,7 @@ print_errno_message (int errnum) #endif } -static void +static void _GL_ATTRIBUTE_FORMAT_PRINTF (3, 0) _GL_ARG_NONNULL ((3)) error_tail (int status, int errnum, const char *message, va_list args) { #if _LIBC -- 1.8.4.299.gb3e7d24
Re: relocatable-prog status
Sylvain b...@beuc.net writes: It's been a while (1 year 1/2) since http://lists.debian.org/debian-bsd/2012/05/msg00032.html and I still need to manually patch gnulib before releasing. If I assume the relocatable-prog module is not maintained, that I'm probably the only person on earth to use it, and that I should just drop it from my package, am I wrong? ;) No, we use relocatable-prog in GNU PSPP as well. I build with it all the time. But I don't use Debian/kFreeBSD or Debian/Hurd, so I don't see this problem. I do read this list, and I am a maintainer of relocatable-prog, but somehow I missed the discussion. Maybe I thought that Bruno was going to take care of it, since he suggested the patch. Are you still happy with install-reloc with Bruno's patch? If so, then I will commit it to gnulib.