Re: bug#39652: SED preinstall check failed

[Assaf Gordon]

tag 39652 moreinfo
stop

(added bug-gnulib@)

Hello,

On 2020-02-17 8:12 p.m., Gopinath Sekar via wrote:

FAIL: test-rename

[...]


See gnulib-tests/test-suite.log
Please report to bug-...@gnu.org

Makefile:3038: recipe for target 'test-suite.log' failed
make[6]: *** [test-suite.log] Error 1
make[6]: Leaving directory '/home/sekar/sed-4.4/gnulib-tests'


Thank you for the report.
This failure is not in sed directly, but a library called "gnulib" 
(which GNU sed uses).


I've added the gnulib mailing list to this discussion.

To help us diagnose the issue, please attach the log file
( gnulib-tests/test-suite.log ), and the details of your system
(e.g. "uname -a" and "gcc --version" and "df -T").

Additionally, sed version 4.4 is three years old.
If possible, please test with the latest sed version 4.8.

regards,
 - assaf

[PATCH] users.txt: update cmogstored URL

[Eric Wong]

bogomips.org is expiring and .org is unlikely to be affordable
down the line, so it's on yhbt.net for now.
---
 It's also available for Tor users at
 http://cmogstored.ou63pmih66umazou.onion/
 but I guess .onions and Tor aren't as well known as it ought to be...

 users.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/users.txt b/users.txt
index 0377b7953..6798093fd 100644
--- a/users.txt
+++ b/users.txt
@@ -8,7 +8,7 @@ The following packages appear to be using gnulib and 
gnulib-tool:
   bison   https://git.sv.gnu.org/gitweb/?p=bison.git
   clisp   https://sourceforge.net/p/clisp/clisp/ci/default/tree/
   coreutils   https://git.sv.gnu.org/gitweb/?p=coreutils.git
-  cmogstored  https://bogomips.org/cmogstored/
+  cmogstored  https://yhbt.net/cmogstored/
   cpiohttps://git.sv.gnu.org/gitweb/?p=cpio.git
   CSSChttps://git.savannah.gnu.org/cgit/cssc.git
   cvs https://cvs.sv.gnu.org/viewcvs/cvs/ccvs/

Re: -Wmissing-prototypes triggers in uninorm/decompose-internal.c

[Bruno Haible]

Tim Rühsen wrote:
> There seems to be a prototype missing in uninorm/decompose-internal.h:
> 
> uninorm/decompose-internal.c:26:27: warning: no previous prototype for
> 'gl_uninorm_decompose_merge_sort_fromto' [-Wmissing-prototypes]
>26 | #define merge_sort_fromto gl_uninorm_decompose_merge_sort_fromto
>   |   ^~
> uninorm/decompose-internal.c:26:27: note: in definition of macro
> 'merge_sort_fromto'
>26 | #define merge_sort_fromto gl_uninorm_decompose_merge_sort_fromto

Thanks for the report. Fixed as follows:


2020-02-19  Bruno Haible  

uninorm/decompose-internal: Avoid "no previous prototype" warning.
Reported by Tim Rühsen  in
.
* lib/array-mergesort.h: Accept an optional macro definition
STATIC_FROMTO.
* lib/uninorm/decompose-internal.c (STATIC_FROMTO): New macro.

diff --git a/lib/array-mergesort.h b/lib/array-mergesort.h
index 3d363bb..bf86d64 100644
--- a/lib/array-mergesort.h
+++ b/lib/array-mergesort.h
@@ -29,6 +29,8 @@
   respectively, less, equal, or greater than the element
   pointed to by the second argument.
  STATIC   The storage class of the functions being defined.
+ STATIC_FROMTO  (Optional.) Overrides STATIC for the 'merge_sort_fromto'
+function.
Before including this file, you also need to include:
  #include 
  */
@@ -87,7 +89,12 @@ merge (const ELEMENT *src1, size_t n1,
 /* Sort src[0..n-1] into dst[0..n-1], using tmp[0..n/2-1] as temporary
(scratch) storage.
The arrays src, dst, tmp must not overlap.  */
-STATIC void
+#ifdef STATIC_FROMTO
+STATIC_FROMTO
+#else
+STATIC
+#endif
+void
 merge_sort_fromto (const ELEMENT *src, ELEMENT *dst, size_t n, ELEMENT *tmp)
 {
   switch (n)
diff --git a/lib/uninorm/decompose-internal.c b/lib/uninorm/decompose-internal.c
index 62a7046..e2c20e9 100644
--- a/lib/uninorm/decompose-internal.c
+++ b/lib/uninorm/decompose-internal.c
@@ -23,6 +23,7 @@
 #define ELEMENT struct ucs4_with_ccc
 #define COMPARE(a,b) ((a)->ccc - (b)->ccc)
 #define STATIC
+#define STATIC_FROMTO static
 #define merge_sort_fromto gl_uninorm_decompose_merge_sort_fromto
 #define merge_sort_inplace gl_uninorm_decompose_merge_sort_inplace
 #include "array-mergesort.h"

Re: fstrcmp: memory is not reclaimed on exit

[Akim Demaille]

Hi Bruno,

> Le 16 févr. 2020 à 13:52, Bruno Haible  a écrit :
> 
> Hi Akim,
> 
> Sorry for the delay.

You look busy :)


>> +void
>> +fstrcmp_free (void)
>> +{
>> +  gl_once (keys_init_once, keys_init);
>> +  gl_tls_key_destroy (buffer_key);
>> +  gl_tls_key_destroy (bufmax_key);
>> +}
> 
> This workaround is insufficient, since POSIX [2] says that
>   "It is the responsibility of the application to free any application
>storage or perform any cleanup actions for data structures related
>to the deleted key or associated thread-specific data in any threads"
> 
> In other words, pthread_key_delete is not guaranteed to call the destructor
> of 'buffer_key'. The gnulib test (tests/test-tls.c functions 
> test_tls_dtorcheck1
> and test_tls_dtorcheck2) verifies that the destructor gets called, but only
> for threads != main thread, and you are interested in the main thread
> particularly. Most likely, in this test, the destructor gets called when the
> thread exits [3], not when pthread_key_delete gets called.

Thanks for the details.  The main thread is really not like the others.

> This patch, however, should work.
> 
> 
> 2020-02-16  Bruno Haible  
> 
>   fstrcmp: Add API to clean up resources.
>   Reported by Akim Demaille  in
>   .
>   * lib/fstrcmp.h (fstrcmp_free_resources): New declaration.
>   * lib/fstrcmp.c (fstrcmp_free_resources): New function.

It looks good to me, thanks!

-Wmissing-prototypes triggers in uninorm/decompose-internal.c

[Tim Rühsen]

There seems to be a prototype missing in uninorm/decompose-internal.h:

uninorm/decompose-internal.c:26:27: warning: no previous prototype for
'gl_uninorm_decompose_merge_sort_fromto' [-Wmissing-prototypes]
   26 | #define merge_sort_fromto gl_uninorm_decompose_merge_sort_fromto
  |   ^~
uninorm/decompose-internal.c:26:27: note: in definition of macro
'merge_sort_fromto'
   26 | #define merge_sort_fromto gl_uninorm_decompose_merge_sort_fromto


Regards, Tim



signature.asc
Description: OpenPGP digital signature