Re: [PATCH v2] gnulib-tool: Download PO files
Thanks for applying. Best regards, Mathieu Le 6 sept. 2014 02:18, Ben Pfaff b...@cs.stanford.edu a écrit : On Thu, Sep 04, 2014 at 05:41:08PM +0200, Mathieu Anquetin wrote: On Thu, Sep 4, 2014 at 5:12 PM, Ben Pfaff b...@cs.stanford.edu wrote: On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: These two patches change the behavior of gnulib-tool for downloading PO files from the Translation Project. It synces it with what is being done by the build-aux/bootstrap script (falling back to wget when rsync isn't available and setting options) These look good to me. Have you tested them? rsync didn't work for me (don't know if it's a firewall or a server issue though), so yes I have tested them (at least, the wget part). I don't think there should be any problem since the code is similar to what build-aux/bootstrap does (I didn't reinvent the wheel). Do you have gnulib commit rights or do you need someone to commit them for you? Never commited before (first contribution) so I don't think I have commit rights. Maybe I am wrong though. Thanks, I applied these to the repository. I marked them as trivial changes in the change log. This does not mean that they were trivial problems or solutions but that we judged the changes to be small enough to be insignificant for copyright purposes.
Re: [PATCH v2] gnulib-tool: Download PO files
On Thu, Sep 04, 2014 at 05:41:08PM +0200, Mathieu Anquetin wrote: On Thu, Sep 4, 2014 at 5:12 PM, Ben Pfaff b...@cs.stanford.edu wrote: On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: These two patches change the behavior of gnulib-tool for downloading PO files from the Translation Project. It synces it with what is being done by the build-aux/bootstrap script (falling back to wget when rsync isn't available and setting options) These look good to me. Have you tested them? rsync didn't work for me (don't know if it's a firewall or a server issue though), so yes I have tested them (at least, the wget part). I don't think there should be any problem since the code is similar to what build-aux/bootstrap does (I didn't reinvent the wheel). Do you have gnulib commit rights or do you need someone to commit them for you? Never commited before (first contribution) so I don't think I have commit rights. Maybe I am wrong though. Thanks, I applied these to the repository. I marked them as trivial changes in the change log. This does not mean that they were trivial problems or solutions but that we judged the changes to be small enough to be insignificant for copyright purposes.
[PATCH v2] gnulib-tool: Download PO files
These two patches change the behavior of gnulib-tool for downloading PO files from the Translation Project. It synces it with what is being done by the build-aux/bootstrap script (falling back to wget when rsync isn't available and setting options) Best regards, Mathieu
Re: [PATCH v2] gnulib-tool: Download PO files
On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: These two patches change the behavior of gnulib-tool for downloading PO files from the Translation Project. It synces it with what is being done by the build-aux/bootstrap script (falling back to wget when rsync isn't available and setting options) These look good to me. Have you tested them? Do you have gnulib commit rights or do you need someone to commit them for you?
Re: [PATCH v2] gnulib-tool: Download PO files
On Thu, Sep 4, 2014 at 5:12 PM, Ben Pfaff b...@cs.stanford.edu wrote: On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: These two patches change the behavior of gnulib-tool for downloading PO files from the Translation Project. It synces it with what is being done by the build-aux/bootstrap script (falling back to wget when rsync isn't available and setting options) These look good to me. Have you tested them? rsync didn't work for me (don't know if it's a firewall or a server issue though), so yes I have tested them (at least, the wget part). I don't think there should be any problem since the code is similar to what build-aux/bootstrap does (I didn't reinvent the wheel). Do you have gnulib commit rights or do you need someone to commit them for you? Never commited before (first contribution) so I don't think I have commit rights. Maybe I am wrong though. Best regards, Mathieu
