Re: [bug-patch] GNU Patch 2.6.1 fails to build on Darwin

2010-01-13 Thread Andreas Gruenbacher 
Hello,

On Monday 11 January 2010 02:45:41 pm Ludovic Courtès wrote:
 Hello,
 
 Patch 2.6.1 fails to build on Darwin with Apple’s “GCC” [0]:

does the latest version on ftp://alpha.gnu.org/gnu/patch/ work for you?

Thanks,
Andreas

GNU Patch 2.6.1 fails to build on Darwin

2010-01-11 Thread Ludovic Courtès 
Hello,

Patch 2.6.1 fails to build on Darwin with Apple’s “GCC” [0]:

--8---cut here---start-8---
gcc -std=gnu99 -c  -DHAVE_CONFIG_H 
-Ded_PROGRAM=\/nix/store/1dk6yj85f9j1manfrd3001az2r7ggb8n-ed-1.4/bin/ed\ 
-DENABLE_MERGE -I. -I./src -I./gl/lib -g -O2 -o gl/lib/strndup.o 
gl/lib/strndup.c
gl/lib/strndup.c: In function 'strndup':
gl/lib/strndup.c:33: warning: implicit declaration of function 'rpl_strnlen'

[...]

gcc -std=gnu99 -o src/patch -g -O2  gl/lib/argmatch.o gl/lib/backupfile.o 
gl/lib/basename.o gl/lib/dirname.o gl/lib/stripslash.o gl/lib/error.o 
gl/lib/exitfail.o gl/lib/strndup.o gl/lib/strnlen.o gl/lib/getopt.o 
gl/lib/getopt1.o gl/lib/hash.o gl/lib/quote.o gl/lib/quotearg.o 
gl/lib/safe-write.o gl/lib/xmalloc.o gl/lib/xstrndup.o gl/lib/full-write.o 
src/merge.o src/inp.o src/maketime.o src/partime.o src/patch.o src/pch.o 
src/quotesys.o src/util.o src/version.o 
i686-apple-darwin9-gcc-4.0.1: gl/lib/strnlen.o: No such file or directory
--8---cut here---end---8---

Thanks,
Ludo’.

[0] http://hydra.nixos.org/build/216441/nixlog/1/raw

Re: GNU Patch 2.6.1 fails to build on Darwin

2010-01-11 Thread Eric Blake 
Ludovic Courtès ludo at gnu.org writes:

 Patch 2.6.1 fails to build on Darwin with Apple’s “GCC” [0]:
 
 --8---cut here---start-8---
 gcc -std=gnu99 -c  -DHAVE_CONFIG_H
 -Ded_PROGRAM=\/nix/store/1dk6yj85f9j1manfrd3001az2r7ggb8n-ed-1.4/bin/ed\ -
DENABLE_MERGE
 -I. -I./src -I./gl/lib -g -O2 -o gl/lib/strndup.o gl/lib/strndup.c
 gl/lib/strndup.c: In function 'strndup':
 gl/lib/strndup.c:33: warning: implicit declaration of function 'rpl_strnlen'
 
 [0] http://hydra.nixos.org/build/216441/nixlog/1/raw

I can't get it to fail for me, even when cross-compiling from cygwin to mingw.

Looking at that log, I don't see where the gnulib replacement string.h was 
built.  Are you using gnulib-tool --import, or are you pulling in modules 
manually?  My guess is that you are doing manual importing, and that you missed 
the step that builds the replacement string.h header, and thus putting the bug 
in patch's court rather than gnulib.

-- 
Eric Blake