[bug #52729] [GWorkspace] incompatible-pointer-types compiler warnings

2018-01-03 Thread Yavor Doganov 
Follow-up Comment #3, bug #52729 (project gnustep):

Thanks.  The casts are (and were) unnecessary.  I hesitated to remove them
because I saw id* was used and wondered why.

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
Bug-gnustep mailing list
Bug-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-gnustep

[bug #52793] autoreconf fails

2018-01-03 Thread Yavor Doganov 
URL:
  

 Summary: autoreconf fails
 Project: GNUstep
Submitted by: yavor
Submitted on: Wed 03 Jan 2018 02:11:55 PM EET
Category: Backend
Severity: 3 - Normal
  Item Group: Bug
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

This is similar to Bug#52779 but not identical, so I'm reporting it as a
separate bug.


$ autoreconf -fi
configure.ac:275: error: possibly undefined macro: PKG_XFT
  If this token and others are legitimate, please use m4_pattern_allow.
  See the Autoconf documentation.
configure.ac:455: error: possibly undefined macro: PKG_CAIRO
configure.ac:457: error: possibly undefined macro: PKG_CAIRO_FT
configure.ac:459: error: possibly undefined macro: PKG_CAIRO_XLIB
configure.ac:463: error: possibly undefined macro: PKG_CAIRO_GLITZ
configure.ac:465: error: possibly undefined macro: PKG_FONTCONFIG
autoreconf: /usr/bin/autoconf failed with exit status: 1
$ cp ../libs-gui/config/pkg.m4 .
$ rm aclocal.m4
$ autoreconf -fi
configure.ac:275: error: possibly undefined macro: PKG_XFT
  If this token and others are legitimate, please use m4_pattern_allow.
  See the Autoconf documentation.
configure.ac:455: error: possibly undefined macro: PKG_CAIRO
configure.ac:457: error: possibly undefined macro: PKG_CAIRO_FT
configure.ac:459: error: possibly undefined macro: PKG_CAIRO_XLIB
configure.ac:463: error: possibly undefined macro: PKG_CAIRO_GLITZ
configure.ac:465: error: possibly undefined macro: PKG_FONTCONFIG
autoreconf: /usr/bin/autoconf failed with exit status: 1


This is because newer pkg.m4 macros now use m4_pattern_forbid to reserve their
own namespace.  Proposed patch attached.

P.S. PKG_PROG_PKG_CONFIG is AC_REQUIREd by PKG_CHECK_MODULES and generally
shouldn't be necessary to be called explicitly.  However, the first call to
PKG_CHECK_MODULES (for xext) is conditional and that's why the macro is not
expanded and later it fails to detect cairo.  If you use AS_IF instead of
plain "if" autoconf would be able to "see" that and the AC_REQUIRE machinery
would work.  So, either an explicit call to PKG_PROG_PKG_CONFIG is neeeded, or
rewrite the if statement as

AS_IF([test "$HAVE_LIBXext" = no], [PKG_CHECK_MODULES([XEXT], [xext])])



___

File Attachments:


---
Date: Wed 03 Jan 2018 02:11:55 PM EET  Name: 0001-Fix-autoreconf-failure.patch
 Size: 101KiB   By: yavor



___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/


___
Bug-gnustep mailing list
Bug-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-gnustep