[bug #54307] Wrong margins especially when printing one page

2018-07-14 Thread Yavor Doganov
Follow-up Comment #2, bug #54307 (project gnustep):

I thought the margins are always symmetrical, but anyway, your approach is
clearly better.

You are right that the NSPrintOperation change is just a dirty workaround and
apparently I haven't considered all subsequences.  I hope some solution can be
found.  Thanks for looking into this.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/


___
Bug-gnustep mailing list
Bug-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-gnustep


[bug #54307] Wrong margins especially when printing one page

2018-07-14 Thread Fred Kiefer
Update of bug #54307 (project gnustep):

  Status:None => Confirmed  
 Assigned to:None => FredKiefer 

___

Follow-up Comment #1:

Hi Yavor,

thank you for this bug report and the patch. I already had some similar
changes to NSPrinter implemented after the discussion on the mailing list.
That should be similar to your code but tries to unify different code paths.

As for NSPageLayout clearly the conversion was missing. I didn't like the way
you set the margins on both sides to the same values. So I just added the
corrected computation.

I also tried to add the same logic to the NSPrintInfo code.

Now with the NSPrintOperations change I understand which case you try to fix.
But the patch would break scaling and a lot of other stuff. And it does not
address the real issue here, just tries to work around in one special case. I
will try to experiment with the printing code a bit and see whether I can come
up woth something better.


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/


___
Bug-gnustep mailing list
Bug-gnustep@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-gnustep