bug#54064: Packaging request: Ultimaker Cura

[Jacob Hrbek]

> For packaging requests, please use the Libreplanet Guix/Wishlist page
at https://libreplanet.org/wiki/Group:Guix/Wishlist. This tracker is for
bugs. -- Maxim

The LP wiki is terrible for packaging request tracking especially when
guix has multiple issues with packaging of some software e.g.
element-desktop or in this case there is a need to inform the used to
put themselves in the `dialout` group in order to use the `print via
USB` feature.

Please mark as wishlist same as https://issues.guix.gnu.org/51643#3 so
that the reasoning is available to the users and can be worked on in a
controlled manner.

---

nckx's trolling is ignored

--
Jacob Hrbek, In support of ukraine sovereignty #supportUkraine



publickey - kreyren@rixotstudio.cz - 1677db82.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

bug#54064: Packaging request: Ultimaker Cura

[Jacob Hrbek]

> For packaging requests, please use the Libreplanet Guix/Wishlist page
at https://libreplanet.org/wiki/Group:Guix/Wishlist. This tracker is for
bugs. -- Maxim

The LP wiki is terrible for packaging request tracking especially when
guix has multiple issues with packaging of some software e.g.
element-desktop or in this case there is a need to inform the used to
put themselves in the `dialout` group in order to use the `print via
USB` feature.

Please mark as wishlist same as https://issues.guix.gnu.org/51643#3 so
that the reasoning is available to the users and can be worked on in a
controlled manner.

--
Jacob Hrbek, In support of ukraine sovereignty #supportUkraine



publickey - kreyren@rixotstudio.cz - 1677db82.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

bug#53368: .guix-authorizations 'version' field documentation

[Maxim Cournoyer]

Hi Christopher,

Christopher Rodriguez  writes:

> Maxime,
>
> Thank You for the explanation. I think I understand that mechanism
> better now.
>
>> While it is the version of the file format, it is not the version of
>> the file, which I believe is were the confusion came from?
>
> This is exactly right, that's where my confusion came from.
>
> Ludovic: I'll amend my patch to more explicitly document the version
> field in this way.
>
> Hopefully, it will be sent here by the end of the day. Thank You both
> for Your help!

Gentle ping.  If you follow-up, I'll close this in 2 weeks time.

Thank you!

Maxim

bug#54247: "guix pull error: You found a bug"

[Maxim Cournoyer]

Hi Pierre,

Pierre-Henry Fröhring  writes:

> Hello,
>
> I've done as the comment says i.e. reporting the bug.
>
> # guix pull
> Updating channel 'guix' from Git repository at
> 'https://git.savannah.gnu.org/git/guix.git'...
> Authenticating channel 'guix', commits 9edb3f6 to d049ff1 (3 new
> commits)...
> Building from this channel:
>   guix  https://git.savannah.gnu.org/git/guix.git d049ff1
> substitute: updating substitutes from 'https://ci.guix.gnu.org'...
> 100.0%
> substitute: updating substitutes from
> 'https://bordeaux.guix.gnu.org'... 100.0%
> building /gnu/store/23f7vvgb33h19h89j01jqiz86c6indy2-compute-guix-
> derivation.drv...
> Computing Guix derivation for 'x86_64-linux'... \guix pull: error: You
> found a bug: the program '/gnu/store/6yhwysy1x5zc5s4xbdar2sayqc20fwdl-
> compute-guix-derivation'
> failed to compute the derivation for Guix (version:
> "d049ff159980954dccb6bc578b1df1efbc408e92"; system: "x86_64-linux";
> host version: "218400c0f7d754467eac20bbdea3c5282efe7b2e"; pull-version:
> 1).
> Please report the COMPLETE output above by email to .

Thanks for the report.

It appears this happened while ci.guix.gnu.org (Cuirass) was down; I
wonder what the error was though.  Could you please try the following:

--8<---cut here---start->8---
$ guix build /gnu/store/6yhwysy1x5zc5s4xbdar2sayqc20fwdl-compute-guix-derivation
--8<---cut here---end--->8---

To retry building the problematic derivation?  And attach the full
compressed log here.

Thank you,

Maxim

bug#54222: I found a bug I guess

[Maxim Cournoyer]

Hi,

T T  writes:

> I installed guix on top of debian unstable using the package from the
> debian repo. As soon as I ran guix pull for the first time, the pull
> fails. Here is the session:
>
>
>
> $ guix pull
> Updating channel 'guix' from Git repository at 
> 'https://git.savannah.gnu.org/git/guix.git'...
> Authenticating channel 'guix', commits 9edb3f6 to 8e00050 (32,780 new 
> commits)...
> Building from this channel:
>   guix  https://git.savannah.gnu.org/git/guix.git 8e00050
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
>  libtiff-4.2.0-doc  358KiB  155KiB/s 00:02 [##] 
> 100.0%
>  bash-static-5.0.16  625KiB 440KiB/s 00:01 [##] 
> 100.0%
>  glibc-2.31  8.2MiB 1.6MiB/s 00:05 [##] 
> 100.0%
>  bash-minimal-5.0.16  559KiB604KiB/s 00:01 [##] 
> 100.0%
>  gcc-7.5.0-lib  4.5MiB  2.2MiB/s 00:02 [##] 
> 100.0%
>  libjpeg-turbo-2.0.5  380KiB759KiB/s 00:01 [##] 
> 100.0%
>  xz-5.2.4  246KiB   259KiB/s 00:01 [##] 
> 100.0%
>  zlib-1.2.11  82KiB 168KiB/s 00:00 [##] 
> 100.0%
>  libtiff-4.2.0  391KiB  334KiB/s 00:01 [##] 
> 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
>  bdb-5.3.28  945KiB 313KiB/s 00:03 [##] 
> 100.0%
>  bash-minimal-5.0.16  559KiB400KiB/s 00:01 [##] 
> 100.0%
>  gdbm-1.18.1  171KiB335KiB/s 00:01 [##] 
> 100.0%
>  gmp-6.2.0  583KiB  436KiB/s 00:01 [##] 
> 100.0%
>  libffi-3.3  54KiB  1.1MiB/s 00:00 [##] 
> 100.0%
>  libgc-8.0.4  224KiB239KiB/s 00:01 [##] 
> 100.0%
>  libltdl-2.4.6  37KiB76KiB/s 00:00 [##] 
> 100.0%
>  libtasn1-4.16.0  104KiB151KiB/s 00:01 [##] 
> 100.0%
>  libunistring-0.9.10  500KiB360KiB/s 00:01 [##] 
> 100.0%
>  mit-krb5-1.18  1.1MiB  721KiB/s 00:02 [##] 
> 100.0%
>  libidn2-2.3.0  120KiB  228KiB/s 00:01 [##] 
> 100.0%
>  nettle-3.5.1  285KiB   301KiB/s 00:01 [##] 
> 100.0%
>  openssl-1.1.1j  2.1MiB 1.5MiB/s 00:01 [##] 
> 100.0%
>  pkg-config-0.29.2  202KiB  396KiB/s 00:01 [##] 
> 100.0%
>  cyrus-sasl-2.1.27  234KiB  247KiB/s 00:01 [##] 
> 100.0%
>  guile-3.0.2  6.9MiB2.3MiB/s 00:03 [##] 
> 100.0%
>  gnutls-3.6.15  1.7MiB  1.7MiB/s 00:01 [##] 
> 100.0%
>  openldap-2.4.57  1.2MiB1.2MiB/s 00:01 [##] 
> 100.0%
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> 

bug#40999: GRUB prevents booting a degraded RAID1 array atop LUKS

[Maxim Cournoyer]

Hi,

I'm writing here because I just found a much easier way to trigger this
than by opening the case of my desktop and pulling a drive out with this
QEMU script:

--8<---cut here---start->8---
#!/usr/bin/env bash

devices=(sda sdb sdc)
args=(-enable-kvm -snapshot -m 2G)

i=0
for d in "${devices[@]}"; do
args+=(-drive file=/dev/$d,index=$i,media=disk)
let i++
done

qemu-system-x86_64 "${args[@]}" "$@"
--8<---cut here---end--->8---

This attempts to boot the drives of the *live* system in QEMU; don't
fret, it's not dangerous as the '-snapshot' option ensure no actual
writes reach the drives.  It seems to fail at the mount command in our
initrd, but it at least allow testing GRUB easily.

With the above script and my Btrfs RAIDc3 array on drives /dev/sda,
/dev/sdb and /dev/sdc, after removing 'sdb' from the devices list for
example I get:

--8<---cut here---start->8---
Booting from Hard Disk...
GRUB loading...
Welcome to GRUB!

Attempting to decrypt master key...
Enter passphrase for hd0,gpt2 (0792432c78d84dcc87c530200c3d02db):
Slot 0 opened
error: failure reading sector 0x0 from `fd0'.
error: no such cryptodisk found.
Attempting to decrypt master key...
Enter passphrase for hd1,gpt2 (f0afd5c9da7046a79c6f5d22913638bf):
Slot 0 opened
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
error: failure reading sector 0x80 from `fd0'.
--8<---cut here---end--->8---

Dropping just sdc instead, I get:

--8<---cut here---start->8---
Booting from Hard Disk...
GRUB loading...
Welcome to GRUB!

Attempting to decrypt master key...
Enter passphrase for hd0,gpt2 (0792432c78d84dcc87c530200c3d02db): 
Slot 0 opened
Attempting to decrypt master key...
Enter passphrase for hd1,gpt2 (a9aead409d014f7abb83be70dd192b7b): 
Slot 0 opened
error: failure reading sector 0x0 from `fd0'.
error: no such cryptodisk found.
error: failure reading sector 0x80 from `fd0'.
error: unknown filesystem.
Entering rescue mode...
--8<---cut here---end--->8---

This should make a future fix cheaper to try (but a system test will be
best anyway :-)).

Thanks,

Maxim

bug#54247: "guix pull error: You found a bug"

[Pierre-Henry Fröhring]

Hello,

I've done as the comment says i.e. reporting the bug.

# guix pull
Updating channel 'guix' from Git repository at
'https://git.savannah.gnu.org/git/guix.git'...
Authenticating channel 'guix', commits 9edb3f6 to d049ff1 (3 new
commits)...
Building from this channel:
  guix  https://git.savannah.gnu.org/git/guix.git   d049ff1
substitute: updating substitutes from 'https://ci.guix.gnu.org'...
100.0%
substitute: updating substitutes from
'https://bordeaux.guix.gnu.org'... 100.0%
building /gnu/store/23f7vvgb33h19h89j01jqiz86c6indy2-compute-guix-
derivation.drv...
Computing Guix derivation for 'x86_64-linux'... \guix pull: error: You
found a bug: the program '/gnu/store/6yhwysy1x5zc5s4xbdar2sayqc20fwdl-
compute-guix-derivation'
failed to compute the derivation for Guix (version:
"d049ff159980954dccb6bc578b1df1efbc408e92"; system: "x86_64-linux";
host version: "218400c0f7d754467eac20bbdea3c5282efe7b2e"; pull-version:
1).
Please report the COMPLETE output above by email to .


Regards,
phf

bug#54033: Calibre's ebook-viewer only shows white-on-white or dark-on-dark.

[bdju]

On Fri Mar 4, 2022 at 8:07 AM CST, Guillaume Le Vaillant wrote:
> Hi,
>
> FreeCAD also has some issues with the rendering of its "start page"
> where the text is missing.
> And as Calibre and FreeCAD are apparently both Python applications using
> QtWebEngine, it may indicate that there is something not working
> correctly in QtWebEngine or in the Python bindings to QtWebEngine.

qutebrowser and anki are also affected. There's an issue somewhere about
it already.

bug#54033: Calibre's ebook-viewer only shows white-on-white or dark-on-dark.

[Jacob MacDonald]

On Fri, Mar 4, 2022 at 7:19 AM Leo Famulari  wrote:
> I think we'll have to fix this bug the old-fashioned way: ... debugging

I tried a little stracing, which didn't illuminate anything.

The results of my attempt at diffing are described above; I intend to
try modifying the build steps, but if there's any advice for debugging
Python builds I'll gladly accept it.

The changes to the Python build system between the working commit and
the broken merge seem moderate, but I've only skimmed them. I haven't
dived into changes to dependencies yet.

When I installed the working version as described above, my desktop
shortcut stayed broken until I relogged or started it from a fresh
terminal. This seems like an environment issue to me, but the desktop
files didn't change in relevant ways.

> reporting it upstream

Given the similarity in the breakage over versions, it seems unlike an
upstream bug to me. The only similar issue I can find is the font one,
and the fonts are properly installed in the broken tree.

bug#54238: Fw: missing files from aspell-dict package

[vapnik spaknik via Bug reports for GNU Guix]

I have installed the latest versions of aspell & aspell-dict-en via guix on a 
foreign distro:

> guix package --list-installed=aspell\*
aspell                0.60.8               out
/gnu/store/xyz0ljdw4m25k8vhnl8261ywq7dvmr49-aspell-0.60.8
aspell-dict-en2020.12.07-0out
/gnu/store/v90ifhzvln0p61i6xpadjj6qvjqvr4sb-aspell-dict-en-2020.12.07-0 

However, when recollindex tries to run this aspell command it emits an error:

> aspell --lang=en --encoding=utf-8 create master ~/recoll/aspdict.en.rws
Error: The language "en" is not known. This is probably because: the file 
"/gnu/store/xyz0ljdw4m25k8vhnl8261ywq7dvmr49-aspell-0.60.8/lib/aspell-0.60/en.dat"
 can not be opened for reading.

If I add a --data-dir option to point to the aspell-dict-en dir which contains 
en.dat I get a different error:
> aspell --data-dir=~/.guix-profile/lib/aspell --lang=en --encoding=utf-8 
> create master ~/recoll/aspdict.en.rws
Error: The file "~/.guix-profile/lib/aspell/iso-8859-1.cset" can not be opened 
for reading. 

The aspell installation contains cset & cmap files in its lib/aspell-0.60/ 
subdir, but no dat files, whereas the aspell-dict-en contains dat files but not 
cset or cmap files. However, aspell expects them to be in the same directory, 
as they are in the debian aspell package (in /usr/lib/aspell).

Joe 

p.s. "vapnik spaknik" is a randomly chosen email name for the sake of 
anonymity, not a shady Russian cracker. I prefer to (try to) stay anonymous 
online because I took heed of Richard Stallmans warnings about the internet, 
not because I'm doing anything dodgy. I say these things because I worry that 
the current political situation may invoke a negative reaction to the name in 
the From field of this message, and reduce its chances of being answered.

bug#54033: Calibre's ebook-viewer only shows white-on-white or dark-on-dark.

[Guillaume Le Vaillant]

Hi,

FreeCAD also has some issues with the rendering of its "start page"
where the text is missing.
And as Calibre and FreeCAD are apparently both Python applications using
QtWebEngine, it may indicate that there is something not working
correctly in QtWebEngine or in the Python bindings to QtWebEngine.

I tried printing some debug traces with:
--8<---cut here---start->8---
QTWEBENGINE_CHROMIUM_FLAGS="--enable-logging -v=1" ebook-viewer
QTWEBENGINE_CHROMIUM_FLAGS="--enable-logging -v=1" FreeCAD
--8<---cut here---end--->8---

In both cases the same error message was printed several times:
--8<---cut here---start->8---
[7052:1:0304/150130.882217:ERROR:paint_controller.cc(646)] 
PaintController::FinishCycle() completed
--8<---cut here---end--->8---

But so far I don't know what it means, or even if it's related to the
rendering issue...


signature.asc
Description: PGP signature

bug#54033: Calibre's ebook-viewer only shows white-on-white or dark-on-dark.

[Leo Famulari]

It's not easy (perhaps impossible) to bisect the core-updates branch. That's 
because most commits on the branch are not expected to build. For most of the 
branch's lifetime, it's merely a place to dump patches that cause rebuilds of 
the entire distro (e.g. a glibc update). It's only in the final stages of the 
core-updates cycle that we integrate those core changes into a working codebase.

I think we'll have to fix this bug the old-fashioned way: debugging, or 
reporting it upstream.

On Thu, Mar 3, 2022, at 23:07, Jacob MacDonald wrote:
> Jesse wrote:
>> I do not know if this is specific to guix or a problem generally with 
>> Calibre 5.36.
>
> As far as I can tell, it's a problem introduced by Guix, as I noticed
> it occurring with Calibre 5.21. For what it's worth, I have the latest
> working version that I can find installed.
>
> guix time-machine --commit=b603554ed044638dd40b6863d5dada59eefe03b8 --
> package -i calibre
>
> Leo:
>
> I've continued to attempt the last bisect I mentioned, but I'm bogged
> down by repeated build errors that force me to skip more commits than
> I can test. Is there a trick to building the commits which got merged
> in; Do they not work with time-machine? The errors I'm seeing are of
> the form:
>
> guix time-machine: error: You found a bug: the program
> '/gnu/store/mqhfdbrl834biajwq667fzsck344g09s-compute-guix-derivation'
> failed to compute the derivation for Guix (version:
> "b2b799e2d8330af934f48bf66afb5114addb4dd7"; system: "x86_64-linux";
> host version: "1af78ab5e80b98d1914b85709c60fa7f9782e1db"; pull-version: 1).
> Please report it by email to .
>
> That latest failure seems to be related to tcsh, but that's not the
> only derivation which has failed for me in the same way.

bug#50299: [PATCH v5 21/24] gnu: belcard: Run tests conditionally.

[Maxime Devos]

* gnu/packages/linphone.scm (belcard)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.
---
 gnu/packages/linphone.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
index 709013f061..504b494563 100644
--- a/gnu/packages/linphone.scm
+++ b/gnu/packages/linphone.scm
@@ -259,8 +259,7 @@ IETF.")
 (build-system cmake-build-system)
 (outputs '("out" "debug" "tester"))
 (arguments
- `(#:tests? #t
-   #:configure-flags '("-DENABLE_STATIC=OFF")
+ `(#:configure-flags '("-DENABLE_STATIC=OFF")
#:phases
(modify-phases %standard-phases
  (add-after 'unpack 'patch-vcard-grammar-location
-- 
2.30.2

bug#50299: [PATCH v5 19/24] gnu: python2-promise: Run tests conditionally.

[Maxime Devos]

* gnu/packages/python-xyz.scm (python2-promise)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.
---
 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 29df43c03d..227f63c65d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -13916,8 +13916,8 @@ concurrent.futures package from Python 3.2")
   (let ((promise (package-with-python2
(strip-python2-variant python-promise
 (package/inherit promise
-  (arguments (substitute-keyword-arguments (package-arguments promise)
-   ((#:tests? _) #t)))
+  (arguments (strip-keyword-arguments '(#:tests?)
+  (package-arguments promise)))
   (native-inputs
`(("python2-futures" ,python2-futures)
  ("python2-pytest" ,python2-pytest)
-- 
2.30.2

bug#50299: [PATCH v5 24/24] gnu: ghc-bsb-http-chunked: Don't run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/haskell-web.scm
  (ghc-bsb-http-chunked)[arguments]<#:tests?>: Set to #false when
  cross-compiling.
---
 gnu/packages/haskell-web.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/haskell-web.scm b/gnu/packages/haskell-web.scm
index 34dd2556be..70a4eccce6 100644
--- a/gnu/packages/haskell-web.scm
+++ b/gnu/packages/haskell-web.scm
@@ -603,8 +603,9 @@ Haskell's Web Application Interface (WAI).")
 (arguments
  `(;; XXX: As of 0.0.4, one property test ("Identical output as Blaze")
;; fails on i686-linux.
-   #:tests? ,(not (string-prefix? "i686" (or (%current-target-system)
- (%current-system
+   #:tests? ,(and (not (%current-target-system))
+  (not (string-prefix? "i686" (or (%current-target-system)
+  (%current-system)
#:cabal-revision
("3" "15hg352id2f4x0dnvv47bdiz6gv5hp5a2mki9yzmhc7ajpk31mdd")))
 (native-inputs
-- 
2.30.2

bug#50299: [PATCH v5 11/24] gnu: ruby-yard-with-tests: Run tests conditionally.

[Maxime Devos]

* gnu/packages/ruby.scm (ruby-yard-with-tests)[arguments]:
  Remove #:tests? instead of setting unconditionally setting it to #t.
---
 gnu/packages/ruby.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 121948b4fc..59912fd795 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -8265,8 +8265,8 @@ definitions.")
 (inherit ruby-yard)
 (name "ruby-yard-with-tests")
 (arguments
- (substitute-keyword-arguments (package-arguments ruby-yard)
-   ((#:tests? _ #t) #t)
+ (substitute-keyword-arguments
+ (strip-keyword-arguments '(#:tests?) (package-arguments ruby-yard))
((#:test-target _ "default") "default")
((#:phases phases '%standard-phases)
 `(modify-phases ,phases
-- 
2.30.2

bug#50299: [PATCH v5 16/24] gnu: perl-unicode-utf8: Run tests conditionally.

[Maxime Devos]

* gnu/packages/perl.scm (perl-unicode-utf8)[arguments]<#:tests?>:
  Set to #false when cross-compiling.
---
 gnu/packages/perl.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index d6ca055147..ba65cc6e6d 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -11007,7 +11007,8 @@ defined by Annex #11 is used to determine breaking 
positions.")
 (build-system perl-build-system)
 ;; FIXME: Tests fail on 32-bit architectures:
 ;; .
-(arguments `(#:tests? ,(target-64bit?)))
+(arguments `(#:tests? ,(and (not (%current-target-system))
+(target-64bit?
 (native-inputs
  (list perl-test-fatal perl-test-leaktrace perl-variable-magic
perl-test-pod))
-- 
2.30.2

bug#50299: [PATCH v5 13/24] gnu: ruby-ffi-rzmq: Respect #:tests?.

[Maxime Devos]

* gnu/packages/ruby.scm (ruby-ffi-rzmq)[arguments]<#:phases>:
  Only invoke "rspec" if #:tests? is true.
---
 gnu/packages/ruby.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 306b07ea68..ec557d1afa 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -7360,8 +7360,9 @@ library.")
 (build-system ruby-build-system)
 (arguments '(#:phases (modify-phases %standard-phases
 (replace 'check
-  (lambda _
-(invoke "rspec"))
+  (lambda* (#:key tests? #:allow-other-keys)
+(when tests?
+  (invoke "rspec")))
 (native-inputs
  (list ruby-rspec))
 (propagated-inputs
-- 
2.30.2

bug#50299: [PATCH v5 15/24] gnu: ecl: Run tests conditionally.

[Maxime Devos]

* gnu/packages/lisp.scm
  (ecl)[arguments]<#:tests?>: Move comment about failing tests to ...
  (ecl)[arguments]<#:phases>{check}: ... this deleted phase.
  (ecl)[arguments]: Remove #:tests? instead of unconditionally setting it to
  #t.
---
 gnu/packages/lisp.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 82fbd15381..c7b526d550 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -269,12 +269,11 @@ interface to the Tk widget system.")
  (list gmp libatomic-ops libgc libffi))
 (arguments
  `(#:configure-flags '("--without-rt")
-   ;; FIXME: As of version 20.4.24, we pass 17995 tests and fail 7.
-   ;; 2-3 tests may be due to FHS assumptions.
-   #:tests? #t
#:parallel-tests? #f
#:phases
(modify-phases %standard-phases
+ ;; FIXME: As of version 20.4.24, we pass 17995 tests and fail 7.
+ ;; 2-3 tests may be due to FHS assumptions.
  (delete 'check)
  (add-after 'unpack 'replace-asdf
;; Use system ASDF instead of bundled one.
-- 
2.30.2

bug#50299: [PATCH v5 00/24] Fix 'check-tests-true' linter and some packages

[Maxime Devos]

This is the v4 patch, rebased.  No other changes.

bug#50299: [PATCH v5 14/24] gnu: go-1.16: Don't run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/golang.scm (go-1.16)[arguments]:
  Remove #:tests? instead of unconditionally setting it to #t.
---
 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 4471fea19d..eed15f4dd8 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -478,8 +478,8 @@ in the style of communicating sequential processes 
(@dfn{CSP}).")
 (base32
  "03f37dspn4h5kqf0nqwmnl858wx6hngnlvbnrjl1ll6ihc5j66jz"
 (arguments
- (substitute-keyword-arguments (package-arguments go-1.14)
-   ((#:tests? _) #t)
+ (substitute-keyword-arguments
+ (strip-keyword-arguments '(#:tests?) (package-arguments go-1.14))
((#:phases phases)
 `(modify-phases ,phases
(add-after 'unpack 'remove-unused-sourcecode-generators
-- 
2.30.2

bug#50299: [PATCH v5 06/24] gnu: swi-prolog: Make configuration wok when cross-compiling.

[Maxime Devos]

* gnu/packages/prolog.scm
  (swi-prolog)[arguments]<#:configure-flags>: Set BSD_SIGNALS and QSORT_R_GNU
  when cross-compiling.
---
 gnu/packages/prolog.scm | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index be5a3c5bf8..8d940530d8 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2013 Mark H Weaver 
 ;;; Copyright © 2020 Brett Gilio 
 ;;; Copyright © 2021 Efraim Flashner 
+;;; Copyright © 2021 Maxime Devos 
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -98,7 +99,13 @@ manner.  It also features an interactive interpreter.")
 (arguments
  `(#:parallel-build? #t
#:configure-flags
-   (list "-DINSTALL_DOCUMENTATION=ON"
+   (list ,@(if (%current-target-system)
+   ;; Set this manually, otherwise CMake would need to
+   ;; run a cross-compiled binary, which it can't do.
+   ;; These values were found on a Linux system.
+   '("-DBSD_SIGNALS=1" "-DQSORT_R_GNU=1")
+   '())
+ "-DINSTALL_DOCUMENTATION=ON"
  "-DSWIPL_INSTALL_IN_LIB=OFF") ; FIXME: Breaks RUNPATH validation.
#:phases
(modify-phases %standard-phases
-- 
2.30.2

bug#50299: [PATCH v5 04/24] gnu: swi-prolog: Move native-inputs to inputs where appropriate.

[Maxime Devos]

* gnu/package/prolog.scm (swi-prolog)
  [native-inputs]: Keep 'texinfo', 'perl' and 'pkg-config' and move the rest
  to ...
  [inputs]: ... here.
---
 gnu/packages/prolog.scm | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index 4eb0f4d3b6..7857fdff68 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -116,17 +116,18 @@ manner.  It also features an interactive interpreter.")
  '("save")))
  #t)
 (native-inputs
+ `(("texinfo" ,texinfo)
+   ("perl" ,perl)
+   ("pkg-config" ,pkg-config)))
+(inputs
  `(("zlib" ,zlib)
("gmp" ,gmp)
("readline" ,readline)
-   ("texinfo" ,texinfo)
("libarchive" ,libarchive)
("libunwind" ,libunwind)
("libjpeg" ,libjpeg-turbo)
("libxft" ,libxft)
("fontconfig" ,fontconfig)
-   ("perl" ,perl)
-   ("pkg-config" ,pkg-config)
("openssl" ,openssl)))
 (home-page "https://www.swi-prolog.org/;)
 (synopsis "ISO/Edinburgh-style Prolog interpreter")
-- 
2.30.2

bug#50299: [PATCH v5 08/24] gnu: swi-prolog: Use cross-compiled bash in shebangs.

[Maxime Devos]

* gnu/packages/prolog.scm (swi-prolog)[inputs]: Add 'bash-minimal'.
---
 gnu/packages/prolog.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index fc3956b17b..3eaec533d7 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -28,6 +28,7 @@
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages backup)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages image)
@@ -128,7 +129,8 @@ manner.  It also features an interactive interpreter.")
("perl" ,perl)
("pkg-config" ,pkg-config)))
 (inputs
- `(("zlib" ,zlib)
+ `(("bash-minimal" ,bash-minimal) ; for some scripts in 'lib'
+   ("zlib" ,zlib)
("gmp" ,gmp)
("readline" ,readline)
("libarchive" ,libarchive)
-- 
2.30.2

bug#50299: [PATCH v5 10/24] gnu: swi-prolog: Correct reference to 'bin/swi-prolog'.

[Maxime Devos]

* gnu/packages/prolog.scm
  (swi-prolog)[arguments]<#:phases>{fix-cross-references}: New phase.
---
 gnu/packages/prolog.scm | 37 -
 1 file changed, 24 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index 00f09b49cc..86ac2c2bb1 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -120,19 +120,30 @@ manner.  It also features an interactive interpreter.")
"-DINSTALL_DOCUMENTATION=ON"
"-DSWIPL_INSTALL_IN_LIB=OFF") ; FIXME: Breaks RUNPATH validation.
#:phases
-   (modify-phases %standard-phases
- ;; XXX: Delete the test phase that attempts to write to the
- ;; immutable store.
- (add-after 'unpack 'delete-failing-tests
-   (lambda _
- (substitute* "src/CMakeLists.txt"
-   ((" save") ""))
- (substitute* "src/test.pl"
-   (("testdir\\('Tests/save'\\).") ""))
- (with-directory-excursion "src/Tests"
-   (for-each delete-file-recursively
- '("save")))
- #t)
+   ,#~(modify-phases %standard-phases
+;; XXX: Delete the test phase that attempts to write to the
+;; immutable store.
+(add-after 'unpack 'delete-failing-tests
+  (lambda _
+(substitute* "src/CMakeLists.txt"
+  ((" save") ""))
+(substitute* "src/test.pl"
+  (("testdir\\('Tests/save'\\).") ""))
+(with-directory-excursion "src/Tests"
+  (for-each delete-file-recursively
+'("save")))
+#t))
+#$@(if (%current-target-system)
+   ;; Prevent man_server.pl and swipl-lfr.pl from keeping a
+   ;; reference to the native swi-prolog.
+   ;; FIXME: libswipl.so and swipl-ld keep a reference to the
+   ;; cross-compiler.
+   #~((add-after 'install 'fix-cross-references
+(lambda _
+  (define bin `(,(string-append #$output "/bin")))
+  (for-each (lambda (file) (patch-shebang file bin))
+(find-files #$output ".pl$")
+   #~()
 (native-inputs
  `(,@(if (%current-target-system)
  (begin
-- 
2.30.2

bug#50299: [PATCH v5 20/24] gnu: lablgtk: Run tests conditionally.

[Maxime Devos]

* gnu/packages/ocaml.scm (lablgtk)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.
---
 gnu/packages/ocaml.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index b34013cc31..bf378be89e 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -7117,8 +7117,7 @@ support for Mparser.")))
 "11qfc39cmwfwfpwmjh6wh98zwdv6p73bv8hqwcsss869vs1r7gmn"
 (build-system dune-build-system)
 (arguments
- `(#:tests? #t
-   #:test-target "."
+ `(#:test-target "."
#:phases
(modify-phases %standard-phases
  (add-before 'build 'make-writable
-- 
2.30.2

bug#50299: [PATCH v5 07/24] gnu: swi-prolog: Don't use 'cc'.

[Maxime Devos]

* gnu/packages/prolog.scm
  (swi-prolog)[arguments]<#:configure-flags>: Set CMAKE_HOST_CC to gcc when
  cross-compiling.
---
 gnu/packages/prolog.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index 8d940530d8..fc3956b17b 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -103,7 +103,9 @@ manner.  It also features an interactive interpreter.")
;; Set this manually, otherwise CMake would need to
;; run a cross-compiled binary, which it can't do.
;; These values were found on a Linux system.
-   '("-DBSD_SIGNALS=1" "-DQSORT_R_GNU=1")
+   '("-DBSD_SIGNALS=1" "-DQSORT_R_GNU=1"
+ ;; If absent, the non-existent 'cc' is used.
+ "-DCMAKE_HOST_CC=gcc"
'())
  "-DINSTALL_DOCUMENTATION=ON"
  "-DSWIPL_INSTALL_IN_LIB=OFF") ; FIXME: Breaks RUNPATH validation.
-- 
2.30.2

bug#50299: [PATCH v5 18/24] gnu: python2-empy: Run tests conditionally.

[Maxime Devos]

* gnu/packages/python-xyz.scm (python2-empy)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.
---
 gnu/packages/python-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 21e6a7755b..29df43c03d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2768,8 +2768,8 @@ commands.")
 (define-public python2-empy
   (let ((base (package-with-python2 (strip-python2-variant python-empy
 (package/inherit base
-  (arguments `(,@(package-arguments base)
-   #:tests? #t)
+  (arguments (strip-keyword-arguments '(#:tests?)
+  (package-arguments base))
 
 (define-public python2-element-tree
   (package
-- 
2.30.2

bug#50299: [PATCH v5 09/24] gnu: swi-prolog: Set PROG_SWIPL when cross-compiling.

[Maxime Devos]

* gnu/packages/prolog.scm
  (swi-prolog)[arguments]<#:configure-flags>: Set PROG_SWIPL and
  SWIPL_NATIVE_FRIEND when cross-compiling and make this a G-expression.
  (swi-prolog)[native-inputs]: Add 'this-package' when cross-compiling.
---
 gnu/packages/prolog.scm | 35 ++-
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index 3eaec533d7..00f09b49cc 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -22,11 +22,13 @@
 
 (define-module (gnu packages prolog)
   #:use-module (guix download)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix utils)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages compression)
@@ -100,16 +102,23 @@ manner.  It also features an interactive interpreter.")
 (arguments
  `(#:parallel-build? #t
#:configure-flags
-   (list ,@(if (%current-target-system)
-   ;; Set this manually, otherwise CMake would need to
-   ;; run a cross-compiled binary, which it can't do.
-   ;; These values were found on a Linux system.
-   '("-DBSD_SIGNALS=1" "-DQSORT_R_GNU=1"
+   ,#~(list
+   #$@(if (%current-target-system)
+  ;; Set this manually, otherwise CMake would need to
+  ;; run a cross-compiled binary, which it can't do.
+  ;; These values were found on a Linux system.
+  #~("-DBSD_SIGNALS=1" "-DQSORT_R_GNU=1"
  ;; If absent, the non-existent 'cc' is used.
  "-DCMAKE_HOST_CC=gcc"
-   '())
- "-DINSTALL_DOCUMENTATION=ON"
- "-DSWIPL_INSTALL_IN_LIB=OFF") ; FIXME: Breaks RUNPATH validation.
+ ;; swi-prolog needs a native copy of itself for
+ ;; cross-compilation.
+ "-DSWIPL_NATIVE_FRIEND=/nowhere"
+ (string-append "-DPROG_SWIPL="
+#+(this-package-native-input "swi-prolog")
+"/bin/swipl"))
+  #~())
+   "-DINSTALL_DOCUMENTATION=ON"
+   "-DSWIPL_INSTALL_IN_LIB=OFF") ; FIXME: Breaks RUNPATH validation.
#:phases
(modify-phases %standard-phases
  ;; XXX: Delete the test phase that attempts to write to the
@@ -125,7 +134,15 @@ manner.  It also features an interactive interpreter.")
  '("save")))
  #t)
 (native-inputs
- `(("texinfo" ,texinfo)
+ `(,@(if (%current-target-system)
+ (begin
+   (unless (equal? (target-64bit?)
+   (target-64bit? (%current-system)))
+ (error "swi-prolog requires --system and --target to have \
+the same word size"))
+   `(("swi-prolog" ,this-package)))
+ '())
+   ("texinfo" ,texinfo)
("perl" ,perl)
("pkg-config" ,pkg-config)))
 (inputs
-- 
2.30.2

bug#50299: [PATCH v5 12/24] gnu: ruby-ffi-rzmq: Run tests conditionally.

[Maxime Devos]

* gnu/packages/ruby.scm (ruby-ffi-rzmq)[arguments]:
  Remove #:tests? instead of setting unconditionally setting it to #t.
---
 gnu/packages/ruby.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 59912fd795..306b07ea68 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -7358,8 +7358,7 @@ library.")
 (base32
  "14a5kxfnf8l3ngyk8hgmk30z07aj1324ll8i48z67ps6pz2kpsrg"
 (build-system ruby-build-system)
-(arguments '(#:tests? #t
- #:phases (modify-phases %standard-phases
+(arguments '(#:phases (modify-phases %standard-phases
 (replace 'check
   (lambda _
 (invoke "rspec"))
-- 
2.30.2

bug#50299: [PATCH v5 01/24] lint: check-tests-true: Allow #:tests? #t for some build systems.

[Maxime Devos]

emacs-build-system sets #:tests? #f by default, so the linter
shouldn't warn if #:tests? #t is set for packages using
emacs-build-system.  Likewise for texlive-build-system

* guix/lint.scm (check-tests-true): Do not warn if the build system
  is emacs-build-system or texlive-build-system.
* tests/lint.scm
  ("tests-true: #:tests? #t acceptable for emacs packages")
  ("tests-true: #:tests? #t acceptable for texlive packages"): New tests.

Fixes: 
Reported-by: Maxim Cournoyer 
---
 guix/lint.scm  | 11 +++
 tests/lint.scm | 21 +
 2 files changed, 32 insertions(+)

diff --git a/guix/lint.scm b/guix/lint.scm
index 3ca7a0b608..e535eb8158 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -34,6 +34,7 @@
   #:use-module (guix store)
   #:autoload   (guix base16) (bytevector->base16-string)
   #:use-module (guix base32)
+  #:use-module (guix build-system)
   #:use-module (guix diagnostics)
   #:use-module (guix download)
   #:use-module (guix ftp-client)
@@ -279,6 +280,16 @@ superfluous when building natively and incorrect when 
cross-compiling."
  (eq? tests? #t))
(package-arguments package)))
   (if (and (tests-explicitly-enabled?)
+   ;; emacs-build-system sets #:tests? #f by default, therefore
+   ;; writing #:tests? #t in package definitions using
+   ;; emacs-build-system is reasonable.  Likewise for
+   ;; texlive-build-system.
+   ;;
+   ;; Compare the name of the build system instead of the build system
+   ;; itself to avoid loading unnecessary modules when only a few
+   ;; modules are linted.
+   (not (memq (build-system-name (package-build-system package))
+  '(emacs texlive)))
;; Some packages, e.g. gnutls, set #:tests?
;; differently depending on whether it is being
;; cross-compiled.
diff --git a/tests/lint.scm b/tests/lint.scm
index 76c2a70b3a..6bb24370da 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -35,6 +35,8 @@
   #:use-module (guix tests http)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix build-system texlive)
+  #:use-module (guix build-system emacs)
   #:use-module (guix build-system gnu)
   #:use-module (guix packages)
   #:use-module (guix lint)
@@ -338,6 +340,25 @@
  `(#:tests? ,(not (%current-target-system)))
 (check-tests-true pkg)))
 
+;; The emacs-build-system sets #:tests? #f by default.
+(test-equal "tests-true: #:tests? #t acceptable for emacs packages"
+  '()
+  (let ((pkg (dummy-package "x"
+(build-system emacs-build-system)
+(arguments
+ `(#:tests? #t)
+(check-tests-true pkg)))
+
+;; Likewise, though the 'check' phase is deleted by default,
+;; so #:tests? #t won't be useful by itself.
+(test-equal "tests-true: #:tests? #t acceptable for texlive packages"
+  '()
+  (let ((pkg (dummy-package "x"
+(build-system texlive-build-system)
+(arguments
+ `(#:tests? #t)
+(check-tests-true pkg)))
+
 (test-equal "inputs: pkg-config is probably a native input"
   "'pkg-config' should probably be a native input"
   (single-lint-warning-message

base-commit: 29091731a0c6cb649cdfd72297575fe2bb2a9591
-- 
2.30.2

bug#50299: [PATCH v5 03/24] gnu: lean: Add bash-minimal.

[Maxime Devos]

Explicitely adding this input is required for cross-compilation.

* gnu/packages/lean.scm (lean)[inputs]: Add 'bash-minimal'.
---
 gnu/packages/lean.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lean.scm b/gnu/packages/lean.scm
index fa36d282d7..7f4cd507f8 100644
--- a/gnu/packages/lean.scm
+++ b/gnu/packages/lean.scm
@@ -19,6 +19,7 @@
 ;;; along with GNU Guix.  If not, see .
 
 (define-module (gnu packages lean)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages multiprecision)
   #:use-module (guix build-system cmake)
   #:use-module ((guix licenses) #:prefix license:)
@@ -40,7 +41,7 @@
 "09mklc1p6ms1jayg2f89hqfmhca3h5744lli936l38ypn1d00sxx"
 (build-system cmake-build-system)
 (inputs
- (list gmp))
+ (list bash-minimal gmp))
 (arguments
  `(#:build-type "Release"   ; default upstream build type
;; XXX: Test phases currently fail on 32-bit sytems.
-- 
2.30.2

bug#50299: [PATCH v5 17/24] gnu: libicns: Run tests conditionally.

[Maxime Devos]

The #:tests? #t is actually harmless here, because there are no
tests (though there is a trivial 'check' target).  The ‘; No tests.’
comment might be confusing though.

* gnu/packages/image.scm (libicns)[arguments]: Remove.
---
 gnu/packages/image.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index b9c780fa69..46b64cc2ed 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -564,8 +564,6 @@ maximum quality factor.")
 (build-system gnu-build-system)
 (inputs
  (list libpng jasper))
-(arguments
- `(#:tests? #t)) ; No tests.
 (home-page "http://icns.sourceforge.net/;)
 (synopsis "Library for handling Mac OS icns resource files")
 (description
-- 
2.30.2

bug#50299: [PATCH v5 05/24] gnu: swi-prolog: Run tests conditionally.

[Maxime Devos]

Tests are enabled by default (except when cross-compiling).
Running tests when cross-compiling is rarely possible.

* gnu/packages/prolog.scm (swi-prolog)[arguments]<#:tests>: Remove it.
---
 gnu/packages/prolog.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/prolog.scm b/gnu/packages/prolog.scm
index 7857fdff68..be5a3c5bf8 100644
--- a/gnu/packages/prolog.scm
+++ b/gnu/packages/prolog.scm
@@ -97,7 +97,6 @@ manner.  It also features an interactive interpreter.")
 (build-system cmake-build-system)
 (arguments
  `(#:parallel-build? #t
-   #:tests? #t
#:configure-flags
(list "-DINSTALL_DOCUMENTATION=ON"
  "-DSWIPL_INSTALL_IN_LIB=OFF") ; FIXME: Breaks RUNPATH validation.
-- 
2.30.2

bug#50299: [PATCH v5 02/24] gnu: lean: Don't run tests when cross-compiling.

[Maxime Devos]

It still fails to cross-compile though.

* gnu/packages/lean.scm (lean)[arguments]<#:tests?>: Set to #false
  when cross-compiling.
---
 gnu/packages/lean.scm | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lean.scm b/gnu/packages/lean.scm
index 6ac7f1668a..fa36d282d7 100644
--- a/gnu/packages/lean.scm
+++ b/gnu/packages/lean.scm
@@ -46,10 +46,10 @@
;; XXX: Test phases currently fail on 32-bit sytems.
;; Tests for those architectures have been temporarily
;; disabled, pending further investigation.
-   #:tests? ,(let ((arch (or (%current-target-system)
-  (%current-system
-   (not (or (string-prefix? "i686" arch)
-(string-prefix? "armhf" arch
+   #:tests? ,(and (not (%current-target-system))
+  (let ((arch (%current-system)))
+(not (or (string-prefix? "i686" arch)
+ (string-prefix? "armhf" arch)
#:phases
(modify-phases %standard-phases
  (add-after 'patch-source-shebangs 'patch-tests-shebangs
-- 
2.30.2

bug#50299: [PATCH v5 23/24] gnu: extra-cmake-modules: Don't run tests when cross-compiling.

[Maxime Devos]

* gnu/packages/kde-frameworks.scm
  (extra-cmake-modules)[arguments]<#:tests?>: Set to #false when
  cross-compiling.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 65937f8970..aa88d140f5 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -106,7 +106,8 @@
  '()
  `(("qtbase" ,qtbase-5;for tests (needs qmake)
 (arguments
- `(#:tests? ,(not (null? (package-native-inputs this-package)))
+ `(#:tests? ,(and (not (%current-target-system))
+  (not (null? (package-native-inputs this-package
#:phases
(modify-phases %standard-phases
  (add-after 'unpack 'fix-lib-path
-- 
2.30.2

bug#50299: [PATCH v5 22/24] gnu: tdlib: Run tests conditionally.

[Maxime Devos]

* gnu/packages/messaging.scm (tdlib)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.
---
 gnu/packages/messaging.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 779d37fdd7..14657facd1 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2625,8 +2625,7 @@ replacement.")
(file-name (git-file-name name version
 (build-system cmake-build-system)
 (arguments
- `(#:tests? #t
-   #:configure-flags
+ `(#:configure-flags
(list "-DCMAKE_BUILD_TYPE=Release"
  "-DTD_ENABLE_LTO=OFF") ; FIXME: Get LTO to work.
#:phases
-- 
2.30.2