bug#64015: guix refresh fails to find latest version for libuv

[Maxim Cournoyer]

Ludovic Courtès  writes:

> Hi,
>
> Maxim Cournoyer  skribis:
>
>> Attempting to use 'guix refresh libuv' says:
>>
>> $ LANG=C guix refresh libuv
>> gnu/packages/libevent.scm:117:13: 1.44.2 is already the latest version of 
>> libuv
>>
>> The release form is here: https://dist.libuv.org/dist/v1.45.0/; there's
>> also a release tag in git: https://github.com/libuv/libuv/tree/v1.45.0.
>
> Because the package currently gets its source from dist.libuv.org, the
> ‘generic-html’ updater is picked; it browses
>  and concludes that there’s no
> newer release.  (Currently it doesn’t recurse so there’s no way it could
> find the new release.)

It'd have value to try to recurse the URL when the version string (full,
major-minor, or minor) appears in the URL, but it seems it'd be fragile
(we can't test all possibilities, and upstream may have jumped version
numbers)...

> We could fetch the code with ‘git-fetch’, in which case the ‘github’ or
> ‘generic-git’ updater would fire.

That seems more actionable, good idea!

-- 
Thanks,
Maxim

bug#64074: guix [COMMAND] --load-path does not check if path is valid

[Csepp]

Christian Miller via Bug reports for GNU Guix  writes:

> Hello,
>
> well in that case, if it is consistent with other GNU tools, it makes
> sense and this can be closed.  Though before closing, do you may have
> an example for invalid paths that could be useful?
>
> Best Regards
> Christian Miller

If I add ~/.local/bin to my $PATH and then delete that directory, I
don't want my shell to abort with an error.
I've also seen configure scripts add /usr/include, which doesn't exist
on Guix.

bug#64073: libvirtd requires restart to function

[Christian Miller via Bug reports for GNU Guix]

Hi,

there is not an error message upon starting it but by stopping it:
Jun 14 23:52:18 localhost shepherd[1]: Stopping service libvirtd... 
Jun 14 23:52:18 localhost libvirtd: 157: error : virGDBusGetSystemBus:99 : 
internal error: Unable to get system bus connection: Could not connect: No such 
file or directory 

I have added the command output of "grep -i libvirt /var/log/messages" as 
attachment.

NOTE: That permission denied error on the ISO is happening since I copied 
/etc/libvirt from my old system.  I have 10+ VMs and thought this works as well 
as of re importing every vm.

PS:
I wanted to create a VM to not taint logs but since I upgraded the VM I just 
have a black screen.  It was a Guix VM installed through the installer with 
GNOME.  I ran guix pull and added spice, libvirt and virtlog to the config.  
After guix system reconfigure config.scm I know have a black screen upon 
logging in to the system.  This was only after reconfiguring the system.  
Before it worked normally.  I used the ISO that reports a permission denied 
error in the logs I attached.  GDM works fine but after logging it is just a 
black screen.  Also my mouse cursor changes from a arrow pointer to the default 
cross cursor from x11.  I guess something is broken on latest?

Best Regards
Christian MillerJun 12 16:20:35 localhost vmunix: [1.669057] shepherd[1]: Starting service 
libvirtd...
Jun 12 16:20:35 localhost vmunix: [1.690558] shepherd[1]: Service libvirtd 
started.
Jun 12 16:20:35 localhost vmunix: [1.696205] shepherd[1]: Service libvirtd 
running with value 155.
Jun 12 16:20:35 localhost vmunix: [1.696425] shepherd[1]: Service libvirtd 
has been started.
Jun 13 11:38:06 localhost vmunix: [1.687605] shepherd[1]: Starting service 
libvirtd...
Jun 13 11:38:06 localhost vmunix: [1.708965] shepherd[1]: Service libvirtd 
started.
Jun 13 11:38:06 localhost vmunix: [1.714310] shepherd[1]: Service libvirtd 
running with value 155.
Jun 13 11:38:06 localhost vmunix: [1.714578] shepherd[1]: Service libvirtd 
has been started.
Jun 13 17:42:57 localhost shepherd[1]: Stopping service libvirtd... 
Jun 13 17:42:57 localhost libvirtd: 155: error : virGDBusGetSystemBus:99 : 
internal error: Unable to get system bus connection: Could not connect: No such 
file or directory 
Jun 13 17:42:57 localhost shepherd[1]: Service libvirtd stopped. 
Jun 13 17:42:57 localhost shepherd[1]: Service libvirtd is now stopped. 
Jun 13 17:42:57 localhost shepherd[1]: Starting service libvirtd... 
Jun 13 17:42:57 localhost shepherd[1]: Service libvirtd has been started. 
Jun 13 17:42:57 localhost shepherd[1]: Service libvirtd started. 
Jun 13 17:42:57 localhost shepherd[1]: Service libvirtd running with value 
9832. 
Jun 13 17:42:57 localhost dnsmasq[361]: read 
/var/lib/libvirt/dnsmasq/network.addnhosts - 0 names
Jun 13 17:42:57 localhost dnsmasq-dhcp[361]: read 
/var/lib/libvirt/dnsmasq/network.hostsfile
Jun 14 05:10:37 localhost shepherd[1]: Respawning libvirtd. 
Jun 14 05:10:37 localhost shepherd[1]: Starting service libvirtd... 
Jun 14 05:10:37 localhost shepherd[1]: Service libvirtd started. 
Jun 14 05:10:37 localhost shepherd[1]: Service libvirtd running with value 
27278. 
Jun 14 05:10:37 localhost shepherd[1]: Service libvirtd has been started. 
Jun 14 16:00:12 localhost vmunix: [1.662704] shepherd[1]: Starting service 
libvirtd...
Jun 14 16:00:12 localhost vmunix: [1.684551] shepherd[1]: Service libvirtd 
started.
Jun 14 16:00:12 localhost vmunix: [1.689707] shepherd[1]: Service libvirtd 
running with value 159.
Jun 14 16:00:12 localhost vmunix: [1.689941] shepherd[1]: Service libvirtd 
has been started.
Jun 14 22:01:48 localhost vmunix: [1.672804] shepherd[1]: Starting service 
libvirtd...
Jun 14 22:01:48 localhost vmunix: [1.694130] shepherd[1]: Service libvirtd 
started.
Jun 14 22:01:48 localhost vmunix: [1.699300] shepherd[1]: Service libvirtd 
running with value 158.
Jun 14 22:01:48 localhost vmunix: [1.699497] shepherd[1]: Service libvirtd 
has been started.
Jun 14 22:31:32 localhost vmunix: [1.748114] shepherd[1]: Starting service 
libvirtd...
Jun 14 22:31:32 localhost vmunix: [1.769690] shepherd[1]: Service libvirtd 
started.
Jun 14 22:31:32 localhost vmunix: [1.774882] shepherd[1]: Service libvirtd 
running with value 157.
Jun 14 22:31:32 localhost vmunix: [1.775099] shepherd[1]: Service libvirtd 
has been started.
Jun 14 23:52:18 localhost shepherd[1]: Stopping service libvirtd... 
Jun 14 23:52:18 localhost libvirtd: 157: error : virGDBusGetSystemBus:99 : 
internal error: Unable to get system bus connection: Could not connect: No such 
file or directory 
Jun 14 23:52:18 localhost shepherd[1]: Service libvirtd stopped. 
Jun 14 23:52:18 localhost shepherd[1]: Service libvirtd is now stopped. 
Jun 14 23:52:18 localhost shepherd[1]: Starting service libvirtd... 
Jun 14 23:52:18 localhost shepherd[1]: Service libvirtd has been started. 
Jun 14 23:52:18 

bug#64074: guix [COMMAND] --load-path does not check if path is valid

[Christian Miller via Bug reports for GNU Guix]

Hello,

well in that case, if it is consistent with other GNU tools, it makes sense and 
this can be closed.  Though before closing, do you may have an example for 
invalid paths that could be useful?

Best Regards
Christian Miller

bug#64112: greetd-wlgreet-session doesn't source .bash_profile

[ytc]

Hello everyone.

I've noticed that when I started a Wayland session with a
greetd-terminal whose default-session-command is
greetd-wlgreet-sway-session or greetd-wlgreet-session, enviromental
variables set in .bash_profile doesn't seem to be set.

I don't know if this is a bug or feature but it doesn't seem right to
me.  I would be glad if you handle it.

Thanks in advance.

bug#64106: `modify-services` no longer affects multiple instances of the same service

[David Wilson]

Hi Guix!

Recently there was a change to the behavior of `modify-services` that adds 
logic to check for any unused clauses so that an exception can be raised to 
alert the user of this case.

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=181951207339508789b28ba7cb914f983319920f

It seems that the new logic has a bug that prevents a used clause from being 
executed on more than one instance of a compatible service in a single 
execution of `modify-services`.  Here's a new test case for 
`gnu/tests/services.scm` that exhibits the issue:

```
(test-equal "modify-services: delete multiple services of the same type"
  '(1 3)
  (let* ((t1 (service-type (name 't1)
   (extensions '())
   (description "")))
 (t2 (service-type (name 't2)
   (extensions '())
   (description "")))
 (t3 (service-type (name 't3)
   (extensions '())
   (description "")))
 (services (list (service t1 1) (service t2 2)
 (service t2 2) (service t3 3
(map service-value
 (modify-services services
   (delete t2)
```

Here's the output of the test:

```
test-name: modify-services: delete multiple services of the same type
location: /home/daviwil/Projects/Code/guix/tests/services.scm:325
source:
+ (test-equal
+   "modify-services: delete multiple services of the same type"
+   '(1 3)
+   (let* ((t1 (service-type
+(name 't1)
+(extensions '())
+(description "")))
+  (t2 (service-type
+(name 't2)
+(extensions '())
+(description "")))
+  (t3 (service-type
+(name 't3)
+(extensions '())
+(description "")))
+  (services
+(list (service t1 1)
+  (service t2 2)
+  (service t2 2)
+  (service t3 3
+ (map service-value
+  (modify-services services (delete t2)
expected-value: (1 3)
actual-value: (1 2 3)
result: FAIL
```

The problem occurs because of this `fold2` logic in `apply-clauses` of 
gnu/services.scm`:

```
  (fold2 (lambda (clause service remainder)
   (if service
   (match clause
 ((kind proc properties)
  (if (eq? kind (service-kind service))
  (values (proc service) remainder)
  (values service
  (cons clause remainder)
   (values #f (cons clause remainder
 head
 '()
 clauses)))
```

In the #t case of checking the service kind, `(values (proc service remainder)` 
is returned, meaning the successful clause is not being added back to the list 
of clauses as `fold2` continues.  Any subsequent items of the service list will 
no longer be tested against the removed clause.

I believe this function's logic needs to be updated to keep a list of 
successful clauses to be diffed against the full clause list at the end of 
`apply-clauses` so that the unapplied clause list can be determined without 
having to remove successful clauses in-flight.

If anyone has any pointers on the best way to approach this, I'll be happy to 
submit a patch!

David