bug#43151: Resolve Calibre run-time dependency

2020-09-09 Thread Prafulla Giri
I see. Thank you for the update.

Hopefully (wrap-program) will be fixed soon. That should save us a lot of
code-duplication.

Congratulations, Mr. Tildesley! (:


bug#43151: Resolve Calibre run-time dependency

2020-09-08 Thread Andreas Enge
Hello,

On Mon, Sep 07, 2020 at 06:15:15PM +1000, Brendan Tildesley wrote:
> Your patch also works I think but it will wrap the programs twice, so
> you will get calibre, .calibre-real, and ..calibre-real-real, etc for
> every program, which seems ugly. My patch reproduces the same PYTHONPATH
> that is set in python-build-system in addition to wrapping PYTHONPATH
> (unless I made a mistake), although at the cost of code duplication. I
> leave it to you and who ever is reviewing this to decide which way is
> more correct and push one, haha.

thanks to both of your for your patches! I just pushed Brendan's, which
wraps only once at the price of copy-pasting from another package. I confirm
that it works, also to click on an epub file from within calibre. Closing
the two bugs asking about qtwebengine.

Concerning the update, is mathjax a required input now, or could we just
leave it out and update nevertheless?

Andreas






bug#43151: Resolve Calibre run-time dependency

2020-09-07 Thread Brendan Tildesley
Sorry I tried sending this with a typo in your gmail address so I'm 
resending just for you:


On 7/9/20 6:12 pm, Brendan Tildesley wrote:
There is actually a Bug report by Andreas for this very issue. I 
created a bug report just for updating, and fixed this issue after it 
while I could, without realising. Sorry for all the confusion with 
things happening in 3 different threads.


I created an updated patch just for this one here. 
https://issues.guix.gnu.org/43151#5


Your patch also works I think but it will wrap the programs twice, so 
you will get calibre, .calibre-real, and ..calibre-real-real, etc for 
every program, which seems ugly. My patch reproduces the same 
PYTHONPATH that is set in python-build-system in addition to wrapping 
PYTHONPATH (unless I made a mistake), although at the cost of code 
duplication. I leave it to you and who ever is reviewing this to 
decide which way is more correct and push one, haha.



Please continue any discussion of the QtWebEngine bug on issue 43121: 
43...@debbugs.gnu.org / https://issues.guix.gnu.org/43151








bug#43151: Resolve Calibre run-time dependency

2020-09-07 Thread Brendan Tildesley
There is actually a Bug report by Andreas for this very issue. I created 
a bug report just for updating, and fixed this issue after it while I 
could, without realising. Sorry for all the confusion with things 
happening in 3 different threads.


I created an updated patch just for this one here. 
https://issues.guix.gnu.org/43151#5


Your patch also works I think but it will wrap the programs twice, so 
you will get calibre, .calibre-real, and ..calibre-real-real, etc for 
every program, which seems ugly. My patch reproduces the same PYTHONPATH 
that is set in python-build-system in addition to wrapping PYTHONPATH 
(unless I made a mistake), although at the cost of code duplication. I 
leave it to you and who ever is reviewing this to decide which way is 
more correct and push one, haha.



Please continue any discussion of the QtWebEngine bug on issue 43121: 
43...@debbugs.gnu.org / https://issues.guix.gnu.org/43151