bug#63371: [bug#63534] [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1
Hello,
Nicolas Goaziou writes:
[...]
> Nitpick: missing full stops at the end of sentences.
OK, I'll prepare a V2 patch ASAP
>> [arguments]: Fix quazip and poppler library path
sorry: maybe this description is a little bit misleading
> [...]
>
>> (substitute* "OpenBoard.pro"
>> - (("/usr/include/quazip")
>> - (search-input-directory inputs "/include/quazip5"))
>> + (("/usr/include/quazip5")
This one is important, it fixes quazip include path (/usr/include/quazip
-> /usr/include/quazip5)
>> + (search-input-directory inputs "include/quazip5"))
>>(("/usr/include/poppler")
>> - (search-input-directory inputs "/include/poppler")
>> + (search-input-directory inputs "include/poppler")
>
> I don't think these changes are warranted. Do they fix something?
No [1], I'll strip this changes from the V2 of this patch
> Otherwise LGTM.
Thanks! Gio'
--
Giovanni Biscuolo
Xelera IT Infrastructures
signature.asc
Description: PGP signature
bug#63371: [bug#63534] [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1
Hello,
Giovanni Biscuolo writes:
> From c0405d2762eb173fb7357de700f1aefc606682f6 Mon Sep 17 00:00:00 2001
> Message-Id:
>
> From: Giovanni Biscuolo
> Date: Tue, 16 May 2023 08:08:56 +0200
> Subject: [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1
>
> * gnu/packages/education.scm (openboard)[version]: Update to
> 1.7-dev-0.47a96e1
Nitpick: missing full stops at the end of sentences.
> [arguments]: Fix quazip and poppler library path
[...]
> (substitute* "OpenBoard.pro"
> - (("/usr/include/quazip")
> - (search-input-directory inputs "/include/quazip5"))
> + (("/usr/include/quazip5")
> + (search-input-directory inputs "include/quazip5"))
>(("/usr/include/poppler")
> - (search-input-directory inputs "/include/poppler")
> + (search-input-directory inputs "include/poppler")
I don't think these changes are warranted. Do they fix something?
Otherwise LGTM.
Regards,
--
Nicolas Goaziou
