bug#67565: shepherd: FAIL: tests/close-on-exec.sh

[Attila Lendvai]

> > this log file is with my shepherd branch, i.e. it contains much more log.
> 
> 
> Could you check whether it happens with current ‘main’?


i ran a `make check` recently on main, and it ran clean.

it doesn't mean much, though, because it only failed sporadically.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“The worst enemy of clear thinking is the propensity to hypostatize, i.e. to 
ascribe substance or real existence to mental constructs or concepts.”
— Ludwig von Mises (1881–1973), 'The Ultimate Foundations of Economic 
Science' (1962)

bug#67565: shepherd: FAIL: tests/close-on-exec.sh

[Ludovic Courtès]

Hi,

Attila Lendvai  skribis:

> this log file is with my shepherd branch, i.e. it contains much more log.

Could you check whether it happens with current ‘main’?

The test is quite sensitive to anything that would open file
descriptors, as you can imagine.

Thanks,
Ludo’.

bug#67565: shepherd: FAIL: tests/close-on-exec.sh

[Attila Lendvai]

make check TESTS="tests/close-on-exec.sh"

fails for me in shepherd.

it's the same with master, with v0.10.2, and with v0.10.1.

i didn't check other revisions.

the log file is attached.

HTH,

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
You cannot enslave a mind that knows itself, that values itself, that 
understands itself.
+ shepherd --version
shepherd (GNU Shepherd) 0.10.2
Copyright (C) 2023 the Shepherd authors
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
+ herd --version
herd (GNU Shepherd) 0.10.2
Copyright (C) 2023 the Shepherd authors
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
+ socket=t-socket-12913
+ conf=t-conf-12913
+ log=t-log-12913
+ pid=t-pid-12913
+ c_file=t-count-file-descriptors-12913.c
+ exe=/home/alendvai/workspace/guix/shepherd/t-count-file-descriptors-12913
+ fd_count=/home/alendvai/workspace/guix/shepherd/t-fd-count-12913
+ herd='herd -s t-socket-12913'
+ trap 'cat t-log-12913 || true; rm -f t-socket-12913 t-conf-12913 t-log-12913 /home/alendvai/workspace/guix/shepherd/t-fd-count-12913 t-count-file-descriptors-12913.c /home/alendvai/workspace/guix/shepherd/t-count-file-descriptors-12913;
  test -f t-pid-12913 && kill `cat t-pid-12913` || true; rm -f t-pid-12913' EXIT
+ '[' -d /proc/self/fd ']'
+ cat
+ gcc -Wall t-count-file-descriptors-12913.c -o /home/alendvai/workspace/guix/shepherd/t-count-file-descriptors-12913
+ /home/alendvai/workspace/guix/shepherd/t-count-file-descriptors-12913
0 -> /dev/pts/1
1 -> /home/alendvai/workspace/guix/shepherd/tests/close-on-exec.log
2 -> /home/alendvai/workspace/guix/shepherd/tests/close-on-exec.log
3 -> /proc/12945/fd
+ cat
++ type -P sleep
+ rm -f t-pid-12913 /home/alendvai/workspace/guix/shepherd/t-fd-count-12913
+ test -f t-pid-12913
+ sleep 0.3
+ shepherd -I -s t-socket-12913 -c t-conf-12913 -l t-log-12913 --pid=t-pid-12913
Starting service root...
Service root started.
Service root running with value #t.
Service root has been started.
Configuration successfully loaded from 't-conf-12913'.
+ test -f t-pid-12913
++ cat t-pid-12913
+ shepherd_pid=12949
+ kill -0 12949
+ herd -s t-socket-12913 start inetd-ctor
Starting service inetd-ctor...
Service inetd-ctor started.
Service inetd-ctor running with value (#).
Service inetd-ctor has been started.
+ ls -l /proc/12949/fd
total 0
lr-x-- 1 alendvai users 64 Nov 17 21:46 0 -> /dev/null
l-wx-- 1 alendvai users 64 Nov 17 21:46 1 -> /home/alendvai/workspace/guix/shepherd/tests/close-on-exec.log
lrwx-- 1 alendvai users 64 Nov 17 21:46 10 -> anon_inode:[signalfd]
l-wx-- 1 alendvai users 64 Nov 17 21:46 11 -> pipe:[16921055]
lr-x-- 1 alendvai users 64 Nov 17 21:46 12 -> pipe:[16920173]
l-wx-- 1 alendvai users 64 Nov 17 21:46 13 -> pipe:[16920173]
lrwx-- 1 alendvai users 64 Nov 17 21:46 14 -> anon_inode:[eventpoll]
lrwx-- 1 alendvai users 64 Nov 17 21:46 15 -> socket:[16920174]
lrwx-- 1 alendvai users 64 Nov 17 21:46 17 -> socket:[16920178]
l-wx-- 1 alendvai users 64 Nov 17 21:46 2 -> /home/alendvai/workspace/guix/shepherd/tests/close-on-exec.log
lr-x-- 1 alendvai users 64 Nov 17 21:46 3 -> pipe:[16918174]
l-wx-- 1 alendvai users 64 Nov 17 21:46 4 -> pipe:[16918174]
lr-x-- 1 alendvai users 64 Nov 17 21:46 5 -> /home/alendvai/workspace/guix/shepherd/shepherd
l-wx-- 1 alendvai users 64 Nov 17 21:46 6 -> /home/alendvai/workspace/guix/shepherd/t-log-12913
lr-x-- 1 alendvai users 64 Nov 17 21:46 7 -> pipe:[16920172]
l-wx-- 1 alendvai users 64 Nov 17 21:46 8 -> pipe:[16920172]
lr-x-- 1 alendvai users 64 Nov 17 21:46 9 -> pipe:[16921055]
+ herd -s t-socket-12913 start system-ctor
Starting service system-ctor...
Service system-ctor has been started.
+ herd -s t-socket-12913 status system-ctor
Status of system-ctor:
  It is stopped (one-shot).
  It is enabled.
  Provides (system-ctor).
  Requires ().
  Will not be respawned.
+ test -f /home/alendvai/workspace/guix/shepherd/t-fd-count-12913
++ cat /home/alendvai/workspace/guix/shepherd/t-fd-count-12913
+ test 4 -eq 4
+ herd -s t-socket-12913 start forkexec-ctor
Starting service forkexec-ctor...
Service forkexec-ctor started.
Service forkexec-ctor running with value 13000.
Service forkexec-ctor has been started.
+ herd -s t-socket-12913 status forkexec-ctor
Status of forkexec-ctor:
  It is running since 21:46:15 (0 seconds ago).
  Running value is 13000.
  It is enabled.
  Provides (forkexec-ctor).
  Requires ().
  Will not be respawned.
++ herd -s t-socket-12913 status forkexec-ctor
++ grep 'Running value'
++ sed '-es/^.* \([0-9]\+\)\.$/\1/g'
+ pid=13000
+ kill -0 13000
+ ls -l /proc/13000/fd
total 0
lr-x-- 1 alendvai users 64 Nov 17 21:46 0 -> /dev/null
l-wx-- 1