bug#67629: [Cuirass] ‘remote-server’ wrecks havoc when misbehaving clients connect
Ludovic Courtès skribis:
> The ‘cuirass remote-server’ process goes awry when misbehaved clients
> connect; specifically, some of its fibers crash, leaving it running but
> inactive:
>
> 2023-12-04 10:13:14 periodic update: 0 resumable, 0 failed builds
> 2023-12-04 10:13:28 error: Connection reset by peer when replying to
> xx.xx.xx.254.
> 2023-12-04 10:13:42 error: invalid log received from xx.xx.xx.254
> 2023-12-04 10:13:42 error: EOF while receiving log from xx.xx.xx.254
> 2023-12-04 10:13:48 Uncaught exception in task:
> 2023-12-04 10:13:48 In fibers.scm:
> 2023-12-04 10:13:48186:20 8 (_)
> 2023-12-04 10:13:48145:21 7 (_)
> 2023-12-04 10:13:48 In ice-9/boot-9.scm:
> 2023-12-04 10:13:48 1752:10 6 (with-exception-handler _ _ #:unwind? _
> #:unwind-for-type _)
> 2023-12-04 10:13:48 In cuirass/scripts/remote-server.scm:
> 2023-12-04 10:13:48695:11 5 (_)
> 2023-12-04 10:13:48 In ice-9/boot-9.scm:
> 2023-12-04 10:13:48 1747:15 4 (with-exception-handler # 7f982c2abd50 at ice-9/boot-9.scm:1831:7 (exn)> _ #:unwind? _
> #:unwind-for-type _)
> 2023-12-04 10:13:48 In cuirass/scripts/remote-server.scm:
> 2023-12-04 10:13:48437:23 3 (serve-build-requests _ #< getq:
> #
> #))> getq-gc-co
> unter: # putq: # value: (())> putq-gc-counter: #>)
> 2023-12-04 10:13:48 In cuirass/remote.scm:
> 2023-12-04 10:13:48 466:6 2 (receive-message _ #:router? _)
> 2023-12-04 10:13:48 In ice-9/boot-9.scm:
> 2023-12-04 10:13:48 1685:16 1 (raise-exception _ #:continuable? _)
> 2023-12-04 10:13:48 1685:16 0 (raise-exception _ #:continuable? _)
> 2023-12-04 10:13:48 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> 2023-12-04 10:13:48 Throw to key `match-error' with args `("match" "no
> matching pattern" (# #
> #))'.
With commit 9a1452ee021c9f773424961cfeef47ca0b7c5c5a, ‘cuirass
remote-server’ handles this situation gracefully.
I’m still curious about who’s sending us garbage: it has to be valid
zmq, just with the wrong number of parts. From the logs, it seemed like
a port scanner or something on the MDC network was sending garbage on
all the open ports, but that would need to be a sophisticated one.
Ludo’.
bug#67629: [Cuirass] ‘remote-server’ wrecks havoc when misbehaving clients connect
Hi, Maxim Cournoyer skribis: > Ludovic Courtès writes: > >> The ‘cuirass remote-server’ process goes awry when misbehaved clients >> connect; specifically, some of its fibers crash, leaving it running but >> inactive: > > I guess what I reported in bug#67633 is a symptom of the above problem, > perhaps? It could be yes, if ‘remote-server’ crashed right at that moment. Ludo’.
bug#67629: [Cuirass] ‘remote-server’ wrecks havoc when misbehaving clients connect
Hi, Ludovic Courtès writes: > The ‘cuirass remote-server’ process goes awry when misbehaved clients > connect; specifically, some of its fibers crash, leaving it running but > inactive: I guess what I reported in bug#67633 is a symptom of the above problem, perhaps? -- Thanks, Maxim
bug#67629: [Cuirass] ‘remote-server’ wrecks havoc when misbehaving clients connect
The ‘cuirass remote-server’ process goes awry when misbehaved clients
connect; specifically, some of its fibers crash, leaving it running but
inactive:
--8<---cut here---start->8---
2023-12-04 10:13:14 periodic update: 0 resumable, 0 failed builds
2023-12-04 10:13:28 error: Connection reset by peer when replying to
xx.xx.xx.254.
2023-12-04 10:13:42 error: invalid log received from xx.xx.xx.254
2023-12-04 10:13:42 error: EOF while receiving log from xx.xx.xx.254
2023-12-04 10:13:48 Uncaught exception in task:
2023-12-04 10:13:48 In fibers.scm:
2023-12-04 10:13:48186:20 8 (_)
2023-12-04 10:13:48145:21 7 (_)
2023-12-04 10:13:48 In ice-9/boot-9.scm:
2023-12-04 10:13:48 1752:10 6 (with-exception-handler _ _ #:unwind? _
#:unwind-for-type _)
2023-12-04 10:13:48 In cuirass/scripts/remote-server.scm:
2023-12-04 10:13:48695:11 5 (_)
2023-12-04 10:13:48 In ice-9/boot-9.scm:
2023-12-04 10:13:48 1747:15 4 (with-exception-handler # _ #:unwind? _ #:unwind-for-type
_)
2023-12-04 10:13:48 In cuirass/scripts/remote-server.scm:
2023-12-04 10:13:48437:23 3 (serve-build-requests _ #< getq:
#
#))> getq-gc-co
unter: # putq: # putq-gc-counter: #>)
2023-12-04 10:13:48 In cuirass/remote.scm:
2023-12-04 10:13:48 466:6 2 (receive-message _ #:router? _)
2023-12-04 10:13:48 In ice-9/boot-9.scm:
2023-12-04 10:13:48 1685:16 1 (raise-exception _ #:continuable? _)
2023-12-04 10:13:48 1685:16 0 (raise-exception _ #:continuable? _)
2023-12-04 10:13:48 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2023-12-04 10:13:48 Throw to key `match-error' with args `("match" "no matching
pattern" (# # #))'.
2023-12-04 10:13:48 Uncaught exception in task:
2023-12-04 10:13:48 In fibers.scm:
2023-12-04 10:13:48 172:8 2 (_)
2023-12-04 10:13:48 In cuirass/notification.scm:
2023-12-04 10:13:48162:15 1 (_)
2023-12-04 10:13:48 In ice-9/boot-9.scm:
2023-12-04 10:13:48 1685:16 0 (raise-exception _ #:continuable? _)
2023-12-04 10:13:48 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2023-12-04 10:13:48 Throw to key `psql-query-error' with args `(#f #f "no
connection to the server\n")'.
2023-12-04 10:14:06 0 items queued for eventual download
2023-12-04 10:14:07 Uncaught exception in task:
2023-12-04 10:14:07 In fibers.scm:
2023-12-04 10:14:07 172:8 2 (_)
2023-12-04 10:14:07 In cuirass/scripts/remote-server.scm:
2023-12-04 10:14:07430:10 1 (_)
2023-12-04 10:14:07 In ice-9/boot-9.scm:
2023-12-04 10:14:07 1685:16 0 (raise-exception _ #:continuable? _)
2023-12-04 10:14:07 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2023-12-04 10:14:07 Throw to key `psql-query-error' with args `(#f #f "no
connection to the server\n")'.
2023-12-04 10:14:30 error: invalid log received from xx.xx.xx.254
2023-12-04 10:14:30 error: invalid log received from xx.xx.xx.254
2023-12-04 10:14:35 error: invalid log received from xx.xx.xx.254
--8<---cut here---end--->8---
Ludo’.
