[PATCH mig] Change x_server_routine functions to static inline for -std=gnu11

[David Michael]

* header.c (WriteServerHeader): Replace extern with static.
* server.c (WriteEpilog): Remove WriteSubsystemServerRoutine call.
---
 header.c | 2 +-
 server.c | 6 --
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/header.c b/header.c
index 23e5686..3af9746 100644
--- a/header.c
+++ b/header.c
@@ -178,7 +178,7 @@ WriteServerHeader(FILE *file, const statement_t *stats)
  * Include the x_server_routine function so it can be inlined.
  */
 fprintf(file, extern mig_routine_t %s_routines[];\n, ServerDemux);
-WriteSubsystemServerRoutine(file, extern inline);
+WriteSubsystemServerRoutine(file, static inline);
 
 WriteEpilog(file, protect);
 }
diff --git a/server.c b/server.c
index 15fc128..a08795b 100644
--- a/server.c
+++ b/server.c
@@ -216,12 +216,6 @@ WriteEpilog(FILE *file, const statement_t *stats)
 fprintf(file, }\n);
 fprintf(file, \n);
 
-/*
- * Then, the subsystem_server_routine routine
- */
-WriteSubsystemServerRoutine(file, mig_external);
-fprintf(file, \n);
-
 /* symtab */
 
 if (GenSymTab) {
-- 
2.1.0

Re: [PATCH mig] Explicitly use gnu_inline semantics for x_server_routine functions

[David Michael]

On Thu, May 7, 2015 at 6:42 AM, Justus Winter
4win...@informatik.uni-hamburg.de wrote:
 Quoting Samuel Thibault (2015-05-06 21:24:25)
 David Michael, le Tue 05 May 2015 16:33:45 -0400, a écrit :
  Does anyone foresee problems with this method?

 Well, that imposes using a gcc compiler.  But we can probably use static
 inline instead?

 Yes, I believe so.

I've rebuilt everything using static inline instead, and it seems to
work.  There was a duplicate function definition written by server.c
that had to be removed for Hurd to compile, though.  I'll send that
change in a separate e-mail.

Thanks.

David

refcounts_ref assertion failure

[Thomas Schwinge]

Hi!

Running a binutils/GDB build on an up-to-date Debian GNU/Hurd system, I
just hit (mostly manually transcribed):

ext2fs: ../../libports/../libshouldbeinlibc/refcount.h:165: refcounts_ref: 
Assertion `! (r.hard == 1  r.weak == 0) || !refcount detected 
use-after-free!' failed.

Unfortunately, it was the root filesystem, so I couldn't start GDB to get
a proper backstack, etc.

Justed CCed, as you've lately ;-) (in Hurd timescale) been changing
some code using these refcounts -- just in case you'd happen to have any
suspicion.


Grüße,
 Thomas


signature.asc
Description: PGP signature

Re: GSoC: Manolis to work on Guix port to GNU/Hurd

[Manolis Ragkousis]

Hello everyone,

Everything works great with those branches.
Thomas please have a look at uploading a tarball. :-)

Manolis