Re: 'struct flock' has no member named 'l_end'
Hello, Manolis Ragkousis, le Wed 08 Apr 2015 22:21:42 +0300, a écrit : in libpthread commit 8b48173fdc8f52a234ff9d3d1de5277c60d7eea4 the Makefile expects shm-directory.c to be present in sysdeps/generic/ but it is not. This file only exists in glibc 2.21 and is not yet implemented in our libpthread. I have created a master-glibc-2.21 branch to host these glibc 2.21 changes, and reverted them from master. Master should thus be buildable again against our glibc tree (I'm testing it now, so we can build tarballs) Samuel
Re: 'struct flock' has no member named 'l_end'
Manolis Ragkousis, le Wed 08 Apr 2015 22:21:42 +0300, a écrit : in libpthread commit 8b48173fdc8f52a234ff9d3d1de5277c60d7eea4 the Makefile expects shm-directory.c to be present in sysdeps/generic/ but it is not. This file only exists in glibc 2.21 and is not yet implemented in our libpthread. This is a 2.21 thing indeed. We'll just use the generic one, that's why we don't need to implement our own. So either we manage to make the addition libpthread-routines dependent on the libc version, or we just move on to 2.21 :) Samuel
Re: 'struct flock' has no member named 'l_end'
One last thing, in libpthread commit 8b48173fdc8f52a234ff9d3d1de5277c60d7eea4 the Makefile expects shm-directory.c to be present in sysdeps/generic/ but it is not. This file only exists in glibc 2.21 and is not yet implemented in our libpthread. Thanks you, Manolis
Re: 'struct flock' has no member named 'l_end'
Hi! On Sat, 28 Mar 2015 11:06:57 +0100, Samuel Thibault samuel.thiba...@gnu.org wrote: Manolis Ragkousis, le Sat 28 Mar 2015 09:43:08 +, a écrit : And one more thing. In libpthread commit 44ae774bed1a75ea926590f1bc7c9f3328219832 you pushed -#ifdef IS_IN_libpthread +#if IS_IN (libpthread) But it ends failing with ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) Ah, I thought this was available in 2.19. This is new and needed for glibc 2.21. Actually, maybe now is the time to rebase our repository on 2.21? I'm (slowly...) working on that. Grüße, Thomas signature.asc Description: PGP signature
Re: 'struct flock' has no member named 'l_end'
Thomas Schwinge, le Mon 30 Mar 2015 09:28:32 +0200, a écrit : On Sat, 28 Mar 2015 11:06:57 +0100, Samuel Thibault samuel.thiba...@gnu.org wrote: Manolis Ragkousis, le Sat 28 Mar 2015 09:43:08 +, a écrit : And one more thing. In libpthread commit 44ae774bed1a75ea926590f1bc7c9f3328219832 you pushed -#ifdef IS_IN_libpthread +#if IS_IN (libpthread) But it ends failing with ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) Ah, I thought this was available in 2.19. This is new and needed for glibc 2.21. Actually, maybe now is the time to rebase our repository on 2.21? I'm (slowly...) working on that. Ah. I've been working on it for the Debian package too. The testsuite is going fine after a couple of fixes, which I've commited to the debian glibc repo svn://svn.debian.org/svn/pkg-glibc/glibc-package/branches/glibc-2.21 Samuel
Re: 'struct flock' has no member named 'l_end'
Hello, On 25 March 2015 at 01:39, Samuel Thibault samuel.thiba...@gnu.org wrote: This was not up to date to some oddness in the tls-threadvar branch, but I've now fixed it, and thus contains the fix from the corresponding branch. Thank you. BTW, I think the latest libpthread source will save you some unnecessary burden about libpthead bits/ headers which would previously have to be installed before building glibc. Thank you Samuel, this is really appreciated! Ludovic was telling me a couple of days ago, that maybe we should consider hosting somewhere, a tar version of glibc and libpthread with the latest updates. This will make our lifes much easier. WDYT? And one more thing. In libpthread commit 44ae774bed1a75ea926590f1bc7c9f3328219832 you pushed -#ifdef IS_IN_libpthread +#if IS_IN (libpthread) But it ends failing with ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ Attaching build log. Thank you, Manolis In file included from ./pthread/../sysdeps/generic/pt-attr.c:25:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getinheritsched.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getschedparam.c:24:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getscope.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getschedpolicy.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ In file included from ./pthread/../sysdeps/generic/pt-attr-getdetachstate.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-destroy.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-destroy.o] Error 1 make[2]: *** Waiting for unfinished jobs /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr.o] Error 1 In file included from ./pthread/../sysdeps/generic/pt-attr-getguardsize.c:21:0: ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) ^ /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedpolicy.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedpolicy.o] Error 1 ./pthread/pt-internal.h:63:13: error: missing binary operator before token ( #if !(IS_IN (libpthread)) ^ /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedparam.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getschedparam.o] Error 1 /tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/sysd-rules:2439: recipe for target '/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getscope.o' failed make[2]: *** [/tmp/nix-build-glibc-hurd-cross-i686-pc-gnu-2.18.drv-0/build/libpthread/pt-attr-getscope.o] Error 1
Re: 'struct flock' has no member named 'l_end'
Manolis Ragkousis, le Sat 28 Mar 2015 09:43:08 +, a écrit : And one more thing. In libpthread commit 44ae774bed1a75ea926590f1bc7c9f3328219832 you pushed -#ifdef IS_IN_libpthread +#if IS_IN (libpthread) But it ends failing with ./pthread/pt-internal.h:38:11: error: missing binary operator before token ( #if IS_IN (libpthread) Ah, I thought this was available in 2.19. This is new and needed for glibc 2.21. Actually, maybe now is the time to rebase our repository on 2.21? Samuel
Re: 'struct flock' has no member named 'l_end'
Hello, Manolis Ragkousis, le Tue 24 Mar 2015 15:16:17 +, a écrit : Hello Samuel, Hello Hurd hackers Glibc, branch tschwinge/Roger_Whittaker fails to build with 'struct flock' has no member named 'l_end' . This was not up to date to some oddness in the tls-threadvar branch, but I've now fixed it, and thus contains the fix from the corresponding branch. BTW, I think the latest libpthread source will save you some unnecessary burden about libpthead bits/ headers which would previously have to be installed before building glibc. Samuel
