Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Hi! On Thu, 10 May 2012 11:17:01 +0800, I wrote: On Mon, 23 Apr 2012 14:38:41 +, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: The branch, t/hooks has been created This branch is missing from tschwinge/Roger_Whittaker (perhaps on purpose -- please in such cases feel free to add comments to .topmsg saying that something's not ready yet), as is t/libpthread_depends, but the latter one won't be needed until libpthread is ready for integration into glibc. Inspecting the current content of tschwinge/Roger_Whittaker, it turns out that these two branches in fact have been merged before, but there's no trace of that visibile for .topdeps and I have no idea how that is possible at all -- do you happen to remember what you've been doing on 2012-04-21 (commit 6a0800259dc141930c149b9472b4be3db6858c3f and thereabouts). Anyway, I fixed this now. Grüße, Thomas pgpmp3vRk5X2u.pgp Description: PGP signature
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Hi! On Thu, 10 May 2012 14:58:05 +0800, I wrote: On Thu, 10 May 2012 11:17:01 +0800, I wrote: On Mon, 23 Apr 2012 14:38:41 +, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: The branch, t/hooks has been created This branch is missing from tschwinge/Roger_Whittaker (perhaps on purpose -- please in such cases feel free to add comments to .topmsg saying that something's not ready yet), as is t/libpthread_depends, but the latter one won't be needed until libpthread is ready for integration into glibc. Inspecting the current content of tschwinge/Roger_Whittaker, it turns out that these two branches in fact have been merged before, but there's no trace of that visibile for .topdeps and I have no idea how that is possible at all -- do you happen to remember what you've been doing on 2012-04-21 (commit 6a0800259dc141930c149b9472b4be3db6858c3f and thereabouts). It is possible that this happened when only refs/top-bases/tschwinge/Roger_Whittaker was updated on Savannah, but not tschwinge/Roger_Whittaker. This might have happened if the former was pushed first and then the connection terminated, for example. (Though, my recent push first updated tschwinge/Roger_Whittaker and then refs/top-bases/tschwinge/Roger_Whittaker.) Grüße, Thomas pgpi0lpQ77kOs.pgp Description: PGP signature
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Thomas Schwinge, le Thu 10 May 2012 11:17:01 +0800, a écrit : On Mon, 23 Apr 2012 14:38:41 +, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: The branch, t/hooks has been created at 56798c444bc584c118b69a3506c4050b34edc35f (commit) - Log - commit 56798c444bc584c118b69a3506c4050b34edc35f Author: Samuel Thibault samuel.thiba...@ens-lyon.org Date: Sat Apr 21 21:03:12 2012 +0200 Add link rules to sort hooks otherwise they are not properly recorded What is this about, what kind of issue does it address? (I'm afraid I don't know a lot about this hooks stuff.) See the RUN_HOOK macro. It needs that all the symbols referenced by text_set_element are folded between the __stop__ and __start__ symbols, otherwise the for loop doesn't find them. Samuel
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Hi! On Thu, 10 May 2012 10:44:00 +0200, Samuel Thibault samuel.thiba...@gnu.org wrote: Thomas Schwinge, le Thu 10 May 2012 11:17:01 +0800, a écrit : On Mon, 23 Apr 2012 14:38:41 +, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: The branch, t/hooks has been created at 56798c444bc584c118b69a3506c4050b34edc35f (commit) - Log - commit 56798c444bc584c118b69a3506c4050b34edc35f Author: Samuel Thibault samuel.thiba...@ens-lyon.org Date: Sat Apr 21 21:03:12 2012 +0200 Add link rules to sort hooks otherwise they are not properly recorded What is this about, what kind of issue does it address? (I'm afraid I don't know a lot about this hooks stuff.) See the RUN_HOOK macro. It needs that all the symbols referenced by text_set_element are folded between the __stop__ and __start__ symbols, otherwise the for loop doesn't find them. Thanks, that helps. How did this work before, though? Due to __symbol_set_attribute specifying weak linkage for the static case, I can see why we didn't get undefined symbol errors when linking for the static case, but what about the dynamic case? (And that'd mean the whole loop just was a no-op before, right?) Did you find this while working on a specific problem? Also, what about data_set_element which is only used in hurd/dtable.c for _hurd_fork_locks, which is manually run through twice in sysdeps/mach/hurd/fork.c, but which I can't find start and stop markers being defined for? And, might something like that in fact be responsible for the issue I had already seen months ago, but have just earlier today finally posted as http://www.bddebian.com:/~hurd-web/open_issues/fork_deadlock/? Lastly, _hurd_fork_setup_hook is only defined but never used, it seems. Grüße, Thomas pgpLQLnQEdUsB.pgp Description: PGP signature
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
On Thu, 2012-05-10 at 18:09 +0800, Thomas Schwinge wrote: And, might something like that in fact be responsible for the issue I had already seen months ago, but have just earlier today finally posted as http://www.bddebian.com:/~hurd-web/open_issues/fork_deadlock/? Thomas, I took the liberty to change fork will hand to fork will hang for readability. I hope you don't mind.
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Thomas Schwinge, le Thu 10 May 2012 15:18:22 +0800, a écrit : refs/top-bases/tschwinge/Roger_Whittaker was updated on Savannah, but not tschwinge/Roger_Whittaker. This might have happened if the former was pushed first and then the connection terminated, for example. That's possible. tg takes ages and my internet connection went down, retried, etc. and at some point I must have forgotten about it going on and not having actually finished it. tg is really hackish :) Samuel
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Thomas Schwinge, le Thu 10 May 2012 18:09:03 +0800, a écrit : How did this work before, though? I'd say it didn't. Due to __symbol_set_attribute specifying weak linkage for the static case, I can see why we didn't get undefined symbol errors when linking for the static case, but what about the dynamic case? (And that'd mean the whole loop just was a no-op before, right?) Yes. Did you find this while working on a specific problem? I don't remember exactly, it's actually an old commit in my tree. Also, what about data_set_element which is only used in hurd/dtable.c for _hurd_fork_locks, which is manually run through twice in sysdeps/mach/hurd/fork.c, but which I can't find start and stop markers being defined for? data_set_element is something else apparently, but it seems it needs the same treatment indeed (I had only had a look at the hooks). And, might something like that in fact be responsible for the issue I had already seen months ago, but have just earlier today finally posted as http://www.bddebian.com:/~hurd-web/open_issues/fork_deadlock/? Possibly. Lastly, _hurd_fork_setup_hook is only defined but never used, it seems. Possibly a leftover or place for future use, I guess. Samuel
Re: [SCM] glibc maintenance branch, t/hooks, created. glibc-2.12-869-g56798c4
Hi! On Mon, 23 Apr 2012 14:38:41 +, Samuel Thibault samuel.thiba...@ens-lyon.org wrote: The branch, t/hooks has been created at 56798c444bc584c118b69a3506c4050b34edc35f (commit) - Log - commit 56798c444bc584c118b69a3506c4050b34edc35f Author: Samuel Thibault samuel.thiba...@ens-lyon.org Date: Sat Apr 21 21:03:12 2012 +0200 Add link rules to sort hooks otherwise they are not properly recorded What is this about, what kind of issue does it address? (I'm afraid I don't know a lot about this hooks stuff.) This branch is missing from tschwinge/Roger_Whittaker (perhaps on purpose -- please in such cases feel free to add comments to .topmsg saying that something's not ready yet), as is t/libpthread_depends, but the latter one won't be needed until libpthread is ready for integration into glibc. Grüße, Thomas pgpiaIZtITrEq.pgp Description: PGP signature
