Re: licensing of intloop() in libddekit/interrupt.c

[Robert Millan]

El 30/11/15 a les 23:20, Olaf Buddenhagen ha escrit:
> Hi Robert,
> 
> On Sun, Nov 08, 2015 at 09:39:49PM +0100, Robert Millan wrote:
> 
>> I have thus merged the remaining bits of GNU/Hurd port
> [...]
>> with this commit the port is now complete.
> 
> Great! :-)
> 
> I was wondering, now that this part is done, whether you intended also
> to work on the next steps towards integrating Rump drivers in the Hurd?

Maybe, if time permits. Can't promise anything though :-(

Note that my Rump packages haven't made it into Debian yet...

-- 
Robert Millan

Re: licensing of intloop() in libddekit/interrupt.c

[Olaf Buddenhagen]

Hi Robert,

On Sun, Nov 08, 2015 at 09:39:49PM +0100, Robert Millan wrote:

> I have thus merged the remaining bits of GNU/Hurd port
[...]
> with this commit the port is now complete.

Great! :-)

I was wondering, now that this part is done, whether you intended also
to work on the next steps towards integrating Rump drivers in the Hurd?

-antrik-

Re: licensing of intloop() in libddekit/interrupt.c

[Robert Millan]

El 10/11/15 a les 14:24, Antti Kantee ha escrit:
> On 08/11/15 20:39, Robert Millan wrote:
>> El 08/11/15 a les 20:45, Da Zheng ha escrit:
>>> Hello Robert,
>>>
>>> Sure, I have no problem with the license.
>>
>> Excellent!
>>
>> I have thus merged the remaining bits of GNU/Hurd port which included your 
>> code:
>>
>>
>> https://github.com/rumpkernel/pci-userspace/commit/a9202c047ff191c752d62c1d03c843f1737c33ba
>>
>> with this commit the port is now complete. Many thanks :-)
> 
> Great that something around here is complete ;)
> 
> Is it possible to easily make Travis CI build test that implementation?

Not that I know of. But I've seen some Jenkins-based testing for the Hurd by
lurking on this list:

  https://jenkins.debian.net/job/g-i-installation_debian_jessie_hurd_lxde/66/

Since all the relevant lists are CCed, chances are someone with better
knowledge can follow up :-)

-- 
Robert Millan

Re: licensing of intloop() in libddekit/interrupt.c

[Samuel Thibault]

Robert Millan, on Tue 10 Nov 2015 21:54:36 +0100, wrote:
> El 10/11/15 a les 14:24, Antti Kantee ha escrit:
> > On 08/11/15 20:39, Robert Millan wrote:
> >> El 08/11/15 a les 20:45, Da Zheng ha escrit:
> >>> Hello Robert,
> >>>
> >>> Sure, I have no problem with the license.
> >>
> >> Excellent!
> >>
> >> I have thus merged the remaining bits of GNU/Hurd port which included your 
> >> code:
> >>
> >>
> >> https://github.com/rumpkernel/pci-userspace/commit/a9202c047ff191c752d62c1d03c843f1737c33ba
> >>
> >> with this commit the port is now complete. Many thanks :-)
> > 
> > Great that something around here is complete ;)
> > 
> > Is it possible to easily make Travis CI build test that implementation?
> 
> Not that I know of. But I've seen some Jenkins-based testing for the Hurd by
> lurking on this list:
> 
>   https://jenkins.debian.net/job/g-i-installation_debian_jessie_hurd_lxde/66/

Yes, there are d-i tests, but they are failing more often than not due
to the weight of kvm-over-kvm used there, which gnumach doesn't cope
with.

Samuel

Re: licensing of intloop() in libddekit/interrupt.c

[Antti Kantee]

On 08/11/15 20:39, Robert Millan wrote:

El 08/11/15 a les 20:45, Da Zheng ha escrit:

Hello Robert,

Sure, I have no problem with the license.


Excellent!

I have thus merged the remaining bits of GNU/Hurd port which included your code:

   
https://github.com/rumpkernel/pci-userspace/commit/a9202c047ff191c752d62c1d03c843f1737c33ba

with this commit the port is now complete. Many thanks :-)


Great that something around here is complete ;)

Is it possible to easily make Travis CI build test that implementation?

Re: licensing of intloop() in libddekit/interrupt.c

[Robert Millan]

Hi!

El 08/11/15 a les 20:12, Da Zheng ha escrit:
> Sorry for disappearing for years.

Never mind, nice hearing from you :-)

> Is there anything I can do for you?

Sure thing. I guess you're busy so I'll be brief: I ported Rump 
(http://rumpkernel.org/)
to GNU/Hurd. In order to access hardware from user-space just like DDE does, I 
reused
some code of yours. Specifically, I used code from your intloop() function in
libddekit/interrupt.c (see [1]).

Would you agree to license that code under a permissive license so that we can 
merge
it into mainstream Rump?

The following are the license terms used in other parts of Rump. If you would 
like to
use these terms, just say so by replying publicly in this thread and I'll take 
care
of the rest (or if you have other license in mind, please let us know as well).

-
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *notice, this list of conditions and the following disclaimer in the
 *documentation and/or other materials provided with the distribution.
 *
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS
 * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 * SUCH DAMAGE.
-

Many thanks

[1] The copyright-significant bits which have actually been used in my work are:

https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=8a1bc5a21ade1a3aeedbb552315ff1ed5da6d7aa
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=40bd937d601627bc9604c5d7d8c528643358b3a7
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=dcd71f277d3fa4615b86e772a4f649d25981dd02
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=63e2a076f77620867d80500b1510f70f5e093a82
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=92e2538dd9825f83d8f961fe85630ebe0bfd4f40
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=2727b6bd16489e8592d3b45faee1f42c00ce2804
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=8a4668dfd4106f26bf5bf6ed69717eb06a3628db
https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=1c5442e1fc9d4dfc71c7ce20900436897afcabf8

-- 
Robert Millan

Re: licensing of intloop() in libddekit/interrupt.c

[Da Zheng]

Sorry for disappearing for years.
Is there anything I can do for you?

Best,
Da


On Sat, Nov 7, 2015 at 5:16 PM, Olaf Buddenhagen
 wrote:
> Hi,
>
>> El 07/11/15 a les 12:11, Robert Millan ha escrit:
>
>> > Unfortunately I didn't get any reply from Zheng Da. Does someone
>> > know if Zheng is using another email address nowadays?
>
> While we haven't heard from him in years, I was able to dig something up
> that seems current: http://www.cs.jhu.edu/~zhengda/
>
> The linked GitHub account ( https://github.com/icoming ) has an (empty)
> subhurd repository -- so it's definitely the right guy :-) There is an
> address there: dzhe...@jhu.edu
>
> There is pretty recent activity; so it should be up to date I hope.
>
>> > In case he can't be reached anymore, I traced origin of the
>> > intloop() routine
> [...]
>> > With this we have "Copyright (C) 2009, 2010 Zheng Da", but still no
>> > licensing information.
>
> If you are resonably sure that the code in question was indeed added by
> him, not imported, then maybe we don't even need to contact him: he
> signed a copyright assignment for the Hurd of course, and I assume it
> applies to this code as well -- so the copyright holder is actually the
> FSF.
>
>> > Unfortunately this gets a bit confusing: some parts of the Hurd are
>> > GPLv2 and some are GPLv2+.
>
> It should all be v2+, except for bits imported from Linux and/or DDE.
>
>> > Then the file Zheng was modifying [1] is imported from DDE/L4 which
>> > is GPLv2 [2].
> [...]
>> > What should we make of this? It's somewhat relevant as the code will
>> > be linked into librumpdev_pci, which in turn will be linked by its
>> > final users in the application layer.
>
> By default we can assume that the added code carries the same licensing
> terms as the rest of the file, i.e. GPLv2 only. There certainly should
> be no problem getting permission from the FSF to distribute it under v2+
> terms; and considering it's nothing strategic, I'm pretty sure we could
> also get a permissive license, if we think this is preferable to match
> the rest of librump...
>
> (I don't know how the code fits together though -- it *might* be
> preferable to actually put the Hurd interface part into a library in the
> Hurd repository, which is what Antti suggested I think...)
>
> -antrik-
>

Re: licensing of intloop() in libddekit/interrupt.c

[Da Zheng]

Hello Robert,

Sure, I have no problem with the license.

Best,
Da

On Sun, Nov 8, 2015 at 2:35 PM, Robert Millan  wrote:
> Hi!
>
> El 08/11/15 a les 20:12, Da Zheng ha escrit:
>> Sorry for disappearing for years.
>
> Never mind, nice hearing from you :-)
>
>> Is there anything I can do for you?
>
> Sure thing. I guess you're busy so I'll be brief: I ported Rump 
> (http://rumpkernel.org/)
> to GNU/Hurd. In order to access hardware from user-space just like DDE does, 
> I reused
> some code of yours. Specifically, I used code from your intloop() function in
> libddekit/interrupt.c (see [1]).
>
> Would you agree to license that code under a permissive license so that we 
> can merge
> it into mainstream Rump?
>
> The following are the license terms used in other parts of Rump. If you would 
> like to
> use these terms, just say so by replying publicly in this thread and I'll 
> take care
> of the rest (or if you have other license in mind, please let us know as 
> well).
>
> -
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>  * are met:
>  * 1. Redistributions of source code must retain the above copyright
>  *notice, this list of conditions and the following disclaimer.
>  * 2. Redistributions in binary form must reproduce the above copyright
>  *notice, this list of conditions and the following disclaimer in the
>  *documentation and/or other materials provided with the distribution.
>  *
>  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS
>  * OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>  * DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
>  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
>  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
>  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
>  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
>  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
>  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>  * SUCH DAMAGE.
> -
>
> Many thanks
>
> [1] The copyright-significant bits which have actually been used in my work 
> are:
>
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=8a1bc5a21ade1a3aeedbb552315ff1ed5da6d7aa
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=40bd937d601627bc9604c5d7d8c528643358b3a7
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=dcd71f277d3fa4615b86e772a4f649d25981dd02
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=63e2a076f77620867d80500b1510f70f5e093a82
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=92e2538dd9825f83d8f961fe85630ebe0bfd4f40
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=2727b6bd16489e8592d3b45faee1f42c00ce2804
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=8a4668dfd4106f26bf5bf6ed69717eb06a3628db
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=1c5442e1fc9d4dfc71c7ce20900436897afcabf8
>
> --
> Robert Millan

Re: licensing of intloop() in libddekit/interrupt.c

[Robert Millan]

El 08/11/15 a les 20:45, Da Zheng ha escrit:
> Hello Robert,
> 
> Sure, I have no problem with the license.

Excellent!

I have thus merged the remaining bits of GNU/Hurd port which included your code:

  
https://github.com/rumpkernel/pci-userspace/commit/a9202c047ff191c752d62c1d03c843f1737c33ba

with this commit the port is now complete. Many thanks :-)

-- 
Robert Millan

Re: licensing of intloop() in libddekit/interrupt.c

[Olaf Buddenhagen]

Hi,

> El 07/11/15 a les 12:11, Robert Millan ha escrit:

> > Unfortunately I didn't get any reply from Zheng Da. Does someone
> > know if Zheng is using another email address nowadays?

While we haven't heard from him in years, I was able to dig something up
that seems current: http://www.cs.jhu.edu/~zhengda/

The linked GitHub account ( https://github.com/icoming ) has an (empty)
subhurd repository -- so it's definitely the right guy :-) There is an
address there: dzhe...@jhu.edu

There is pretty recent activity; so it should be up to date I hope.

> > In case he can't be reached anymore, I traced origin of the
> > intloop() routine
[...]
> > With this we have "Copyright (C) 2009, 2010 Zheng Da", but still no
> > licensing information.

If you are resonably sure that the code in question was indeed added by
him, not imported, then maybe we don't even need to contact him: he
signed a copyright assignment for the Hurd of course, and I assume it
applies to this code as well -- so the copyright holder is actually the
FSF.

> > Unfortunately this gets a bit confusing: some parts of the Hurd are
> > GPLv2 and some are GPLv2+.

It should all be v2+, except for bits imported from Linux and/or DDE.

> > Then the file Zheng was modifying [1] is imported from DDE/L4 which
> > is GPLv2 [2].
[...]
> > What should we make of this? It's somewhat relevant as the code will
> > be linked into librumpdev_pci, which in turn will be linked by its
> > final users in the application layer.

By default we can assume that the added code carries the same licensing
terms as the rest of the file, i.e. GPLv2 only. There certainly should
be no problem getting permission from the FSF to distribute it under v2+
terms; and considering it's nothing strategic, I'm pretty sure we could
also get a permissive license, if we think this is preferable to match
the rest of librump...

(I don't know how the code fits together though -- it *might* be
preferable to actually put the Hurd interface part into a library in the
Hurd repository, which is what Antti suggested I think...)

-antrik-

Re: licensing of intloop() in libddekit/interrupt.c

[Robert Millan]

Apologies, I forgot to CC bug-hurd.

El 07/11/15 a les 12:11, Robert Millan ha escrit:
> 
> Unfortunately I didn't get any reply from Zheng Da. Does someone know if 
> Zheng is
> using another email address nowadays?
> 
> In case he can't be reached anymore, I traced origin of the intloop() routine 
> and
> found that:
> 
> 0. The copyright header in interrupt.c mentions Thomas Friebel 
> 
>and Christian Helmuth  as authors, however this 
> doesn't
>affect the code I'm importing (see #2).
> 
> 1. The copyright-significant bits which have actually been used in my work are
> exclusively made of code committed to Debian hurd.git:
> 
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=8a1bc5a21ade1a3aeedbb552315ff1ed5da6d7aa
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=40bd937d601627bc9604c5d7d8c528643358b3a7
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=dcd71f277d3fa4615b86e772a4f649d25981dd02
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=63e2a076f77620867d80500b1510f70f5e093a82
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=92e2538dd9825f83d8f961fe85630ebe0bfd4f40
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=2727b6bd16489e8592d3b45faee1f42c00ce2804
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=8a4668dfd4106f26bf5bf6ed69717eb06a3628db
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=1c5442e1fc9d4dfc71c7ce20900436897afcabf8
> 
> 2. Initial commit by Zheng (6f5290eeb41219ea8b81f6df3ffceb0f4614cdd1) is an 
> import commit
>and includes code written by others, however none of the code in that 
> commit is included
>in my work (since I'm only interested in the GNU Mach interaction bits 
> which were added
>after that).
> 
> 3. The remaining (Samuel's) commits affecting this routine are trivial 
> renames, not significant
>for copyright purposes:
> 
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=56b24422cad2f61ca9d1456e3cf755f53809caa3
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=321bb5dac2409552cf3db5bce8f9462a45cbcf5d
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=2f7814d3d8b629c85e3ea0d9f12f6d2a8daab931
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=6d61151e937510dcb7a4977975bb750eb7ae624c
> https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-hurd/hurd.git;a=commit;h=22481555a880bb5fe3b87b6f6fd74ed58fa91e7f
> 
> With this we have "Copyright (C) 2009, 2010 Zheng Da", but still no licensing 
> information.
> 
> Since Zheng committed it to pkg-hurd, I understand it's common convention to 
> assume
> Zheng's code is licensed under the same terms?
> 
> Unfortunately this gets a bit confusing: some parts of the Hurd are GPLv2 and 
> some are GPLv2+.
> Then the file Zheng was modifying [1] is imported from DDE/L4 which is GPLv2 
> [2].
> 
> [1] http://svn.tudos.org/repos/tudos/trunk/l4/pkg/dde/ddekit/src/interrupt.c
> [2] http://svn.tudos.org/repos/tudos/trunk/l4/pkg/COPYING
> 
> What should we make of this? It's somewhat relevant as the code will be 
> linked into librumpdev_pci,
> which in turn will be linked by its final users in the application layer.
> 
> Please advise...
> 
> El 16/08/15 a les 22:33, Robert Millan ha escrit:
>>
>> Hi Zheng Da,
>>
>> First of all, allow me to show you my appreciation for your effort on 
>> integrating
>> DDE with the Hurd. The groundwork on creating facilities that enable 
>> userspace
>> drivers has been greatly helpful on this little project of mine.
>>
>> Just to put you in context, I've ported Rump (http://rumpkernel.org/) to 
>> GNU/Hurd
>> and written some extensions that allow it to run its own PCI drivers in 
>> userspace.
>>
>> For that I used the same facilities in Gnu Mach that libddekit is using, and 
>> also
>> imported some the code in libddekit for userspace interrupt management. Olaf 
>> (see
>> below) believes that this code was written by you:
>>
>> El 16/08/15 a les 21:02, Olaf Buddenhagen ha escrit:
>>> On Sun, Aug 16, 2015 at 01:09:59PM +0200, Robert Millan wrote:
>>>
 * It includes code from other people under GPLv2;
>>>
- intrthread() is heavily based on intloop() from
hurd/libddekit/interrupt.c
>>>
>>> I haven't checked, but I assume this is form a Hurd-specific part of
>>> DDE, which has been implemented by Zheng Da for the Hurd port
>>> specifically? If so, we could try contacting him.
>>
>> Is this correct?
>>
>> I'm currently trying to merge the resulting code into Rump. This raises the
>>