Re: device_reference and device_deallocate

[Thomas Schwinge]

Hello!

I hope I'm still getting this right; it's been some time that I looked at
the Mach device management stuff.

On Wed, Jul 16, 2008 at 11:09:04PM -0400, Barry deFreese wrote:
> device_reference was renamed to mach_device_reference quite a while back 
> and device_deallocate was renamed to mach_device_deallocate.

This was done when Linux device drivers have been introduced and then
there was the need for a new indirection layer to separate calls to Linux
devices from those to pure Mach devices, while still having them
accessible through the same interface.


> However, ds_routines.c still define device_reference and 
> device_deallocate and kern/ipc_mig.c still calls them.

Yes, that's correct, as it needs to go through the device emulation ops.


I think that everything should stay as it is.  It's ``a bit'' of a mess,
also w.r.t. name spaces/chosen names for the various functions.


Regards,
 Thomas


signature.asc
Description: Digital signature

Re: device_reference and device_deallocate

[Samuel Thibault]

Barry deFreese, le Wed 16 Jul 2008 23:09:04 -0400, a écrit :
> device_reference was renamed to mach_device_reference quite a while back 
> and device_deallocate was renamed to mach_device_deallocate.
> 
> However, ds_routines.c still define device_reference and 
> device_deallocate and kern/ipc_mig.c still calls them.
> 
> As far as I can tell kern/ipc_mig.c is the only code that still 
> references.

Yes and no, see the comment:
`This is an inline version of dev_port_lookup().'
and dev_port_lookup does the same things as device_reference() from
ds_routines.c.  So I think it should remain as is.

Samuel

device_reference and device_deallocate

[Barry deFreese]

Hi folks,

I ran in to a strange one while working on some more gnumach cleanup.

device_reference was renamed to mach_device_reference quite a while back 
and device_deallocate was renamed to mach_device_deallocate.


However, ds_routines.c still define device_reference and 
device_deallocate and kern/ipc_mig.c still calls them.


As far as I can tell kern/ipc_mig.c is the only code that still 
references.  Do you think I'm safe to remove those functions from 
ds_routines.c and update kern/ipc_mig.c to use mach_device_*?

(Which are now prototyped in device/dev_hdr.h bye the way).

Thanks!

Barry deFreese