Re: libltdl memory corruption

[Ralf Wildenhues]

Hi Peter,

* Peter O'Gorman wrote on Tue, Mar 04, 2008 at 07:14:51AM CET:
 Ralf Wildenhues wrote:
  
  So I'd appreciate a review of this, and also test results on systems
  with loaders other than preopen and dlopen.  (I haven't even tested
  successful compilation on those other systems.)
 
 I did not manage to try the shl_load loader, only tested dyld. This
 patch causes no regressions on Mac OS X 10.2. If that is also true for
 the loaders you get around to trying, this is ok.

For the preopen, dlopen, shl_load loaders, I confirmed that the
testsuite addition exposes the bug, and the loader changes fixes the
testsuite failure.  For loadlibrary, I only cross-compiled from
GNU/Linux to ensure absense of typos.

I visually inspected the BeOS and dld changes again for typos, and then
applied the patch, after adding a NEWS entry.

 Thank you. Once again you sent a patch for a bug before I even got
 around to reading the list.

My pleasure.  :-)  Kudos to Andreas for reporting the bug.

Cheers,
Ralf


___
Bug-libtool mailing list
Bug-libtool@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-libtool

Re: libltdl memory corruption

[Peter O'Gorman]

Ralf Wildenhues wrote:
 Hello Andreas,
 
 * Andreas Schwab wrote on Mon, Mar 03, 2008 at 03:39:47PM CET:
 libltdl uses memory after free when initialized twice.
 
 Thank you very much for the bug report.  Proposed patch below.
 I tested it on i686-unknown-linux-gnu but it should be tested
 with as many loaders as possible.
 
 So I'd appreciate a review of this, and also test results on systems
 with loaders other than preopen and dlopen.  (I haven't even tested
 successful compilation on those other systems.)

This looks ok with a quick visual inspection. I'll try it on a couple of
systems tonight (dyld on mac os x 10.2, and shl_load on hpux10.20).

Peter
-- 
Peter O'Gorman
http://pogma.com


___
Bug-libtool mailing list
Bug-libtool@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-libtool