Re: \alterBroken syntax

2017-04-02 Thread Simon Albrecht

Am 02.04.2017 um 01:26 schrieb David Kastrup:

Dan Eble  writes:

David wrote:

It would seem more sensible to change overrides to have
tweak syntax and forego the gratuitous equals sign.

That would be an improvement.

It would be sort of a drastic change.


Well, somewhere far down the TODO-list there’s still the GLISS… this 
seems like an idea for that.


Best, Simon

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-04-01 Thread David Kastrup
Dan Eble  writes:

> David wrote:
>> It would seem more sensible to change overrides to have
>> tweak syntax and forego the gratuitous equals sign.
> That would be an improvement.

It would be sort of a drastic change.

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-04-01 Thread Dan Eble
David wrote:
> It would seem more sensible to change overrides to have
> tweak syntax and forego the gratuitous equals sign.
That would be an improvement.
— 
Dan


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-28 Thread David Kastrup
Dan Eble  writes:

> On Mar 27, 2017, at 22:20 , Simon Albrecht  wrote:
>> 
>>> This command can produce either an \override or a \tweak of
>>> a spanner property.
>> 
>> But that’s exactly the point: \alterBroken (and \shape and \offset)
>> can act _both_ as an override _and_ a tweak, so its syntax must be
>> different from either one of these.
>
> Can we agree that in an ideal world, a command that acts like an
> override would look like an override, and a command that acts like a
> tweak would look like a tweak?

A command that looks like an override must be hardwired into the parser.
I am not really all too eager to try smuggling setter functions
returning a music expression into the parser, so this is likely to stay
in that manner.  It would seem more sensible to change overrides to have
tweak syntax and forego the gratuitous equals sign.

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-27 Thread Dan Eble
On Mar 27, 2017, at 22:20 , Simon Albrecht  wrote:
> 
>> This command can produce either an \override or a \tweak of
>> a spanner property.
> 
> But that’s exactly the point: \alterBroken (and \shape and \offset) can act 
> _both_ as an override _and_ a tweak, so its syntax must be different from 
> either one of these.

Can we agree that in an ideal world, a command that acts like an override would 
look like an override, and a command that acts like a tweak would look like a 
tweak?

Surely the command can not act as both in the same instance.  Could it be split 
into two commands, say \overrideBroken and \tweakBroken?  Could the before- and 
after-break values be aggregated, e.g. \override Grob.property = #(make-broken 
…)?

Regards,
— 
Dan


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-27 Thread Simon Albrecht

Am 28.03.2017 um 03:31 schrieb Dan Eble:

Am 27.03.2017 um 23:32 schrieb Dan Eble:

This is the current syntax:
  \alterBroken property-name #’(before after) GrobName
This would be more consistent with other things:
  \alterBroken GrobName.property-name #’(before after)


\alterBroken in that respect is not to be compared with \override or \tweak, 
but with \shape or \offset.

I imagine that would come as a surprise to the documentation author
who wrote this:

 This command can produce either an \override or a \tweak of
 a spanner property.


But that’s exactly the point: \alterBroken (and \shape and \offset) can 
act _both_ as an override _and_ a tweak, so its syntax must be different 
from either one of these. It doesn’t work with symbol-list-or-symbol? 
for the first argument, but instead has symbol-list-or-music? for the 
last argument: if that’s a symbol-list, the override form is used, if 
it’s music, the tweak form is used.



and this:

 The leading hyphen must be used with the \tweak form. Do not add
 it when \alterBroken is used as an \override.


If the tweak form is used, the parser needs to know beforehand that 
\alterBroken wraps up a post event, so the leading hyphen is required.


Best, Simon

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-27 Thread Dan Eble
> Am 27.03.2017 um 23:32 schrieb Dan Eble:
>> 
>> This is the current syntax:
>>  \alterBroken property-name #’(before after) GrobName
>> This would be more consistent with other things:
>>  \alterBroken GrobName.property-name #’(before after)
>> 
> \alterBroken in that respect is not to be compared with \override or \tweak, 
> but with \shape or \offset.

I imagine that would come as a surprise to the documentation author
who wrote this:

This command can produce either an \override or a \tweak of
a spanner property.

and this:

The leading hyphen must be used with the \tweak form. Do not add
it when \alterBroken is used as an \override.

Regards,
— 
Dan


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-27 Thread Simon Albrecht

Am 27.03.2017 um 23:32 schrieb Dan Eble:

This is the current syntax:

 \alterBroken property-name #’(before after) GrobName

This would be more consistent with other things:

 \alterBroken GrobName.property-name #’(before after)


\alterBroken in that respect is not to be compared with \override or 
\tweak, but with \shape or \offset.


Best, Simon

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-27 Thread Dan Eble

> On Mar 27, 2017, at 17:32 , Dan Eble  wrote:
> 
> This is the current syntax:
> 
>\alterBroken property-name #’(before after) GrobName
> 
> This would be more consistent with other things:
> 
>\alterBroken GrobName.property-name #’(before after)
> 

Notation reference for 2.19.58, p.633:
The syntax for \alterBroken is [-]\alterBroken property values item 
and,
\relative c'' {
  r2
  \alterBroken thickness #'(10 1) Slur
  c8( d e f
  \break
  g8 f e d) r2
}

Result of trying the above example, but with the syntax changed as suggested:
   alter-break.ly:5:3: warning: not a spanner
and no difference in thickness.
— 
Dan


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: \alterBroken syntax

2017-03-27 Thread David Kastrup
Dan Eble  writes:

> This is the current syntax:
>
> \alterBroken property-name #’(before after) GrobName
>
> This would be more consistent with other things:
>
> \alterBroken GrobName.property-name #’(before after)

Have you actually read the documentation of \alterBroken and/or tried
the second form?

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond