Re: whiteout bug

2013-07-29 Thread Phil Holmes
Eluze elu...@gmail.com wrote in message 
news:1375047539550-148497.p...@n5.nabble.com...

Phil Holmes-2 wrote

Karol Majewski lt;



karol.majewsky@



gt; wrote in message
news:CAH85bB0snHDt5GtKyjWGgeOMmWkKx=wrkZ=kLx=+qL2TXx0V=



A@.gmail



...

First note in the second bar is partially overlayed by whie box, which 
is

not what we want, do we?


I wouldn't actually call it a bug.  It happens because lily now places
objects around text based on the actual shape of the text itself.
However,
the whiteout is purely a box, and so doesn't follow the same shape.
Simple
fix:

\layout {
\context {
\Score
\override TextScript.whiteout = ##t
\override TextScript #'vertical-skylines = #'()
}
}


sorry I can't agree - version 2.17.18 gave a quite good result for both 
the

letters before and after the ascender!  test4.preview.png
http://lilypond.1069038.n5.nabble.com/file/n148497/test4.preview.png



but strangely if I change the code of the 1st staff to

   \new Staff \relative c' {
 s4 s s a' c d4  _wh
 q8 q4 q8 q2
   }

the flags and stems are cropped wit 2.17.18 too!  test4-2.preview.png
http://lilypond.1069038.n5.nabble.com/file/n148497/test4-2.preview.png

could this be a regression?

Eluze



After 2.17.0, the staves are pushed together more than they were in 2.16.0, 
because of the way the text (whooo) is skylined.  As a result, the 
whiteout box occupies the same location as the descender from the quaver. 
For most of the 2.17.x builds, this results in the tail being slightly 
obscured.  For one or two of the builds, it appears that the tail is placed 
in front of the whiteout box, for reasons I don't understand, although I do 
remember Keith saying that the order of placing whiteout and other grobs is 
not determinate and has led to odd regression test results.


I remain of the opinion this is, essentially, intended behaviour based on 
the use of skylines, and is easily changed, either by turning skylining off, 
or by including a little padding on the markup.


--
Phil Holmes
Bug Squad 




___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Fw: whiteout bug

2013-07-29 Thread Trevor Daniels

Phil Holmes m...@philholmes.net wrote in message 
news:kt58ju$3le$1...@ger.gmane.org...

 For one or two of the builds, it appears that the tail is placed 
 in front of the whiteout box, for reasons I don't understand, although I do 
 remember Keith saying that the order of placing whiteout and other grobs is 
 not determinate and has led to odd regression test results.

The order in which grobs _in the same layer_ are placed is indeterminate,
but this can be controlled by setting the 'layer property.  See

http://www.lilypond.org/doc/v2.17/Documentation/notation/visibility-of-objects#index-layers

for details.

Trevor
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Fw: whiteout bug

2013-07-29 Thread Eluze
Trevor Daniels wrote
 Phil Holmes lt;

 mail@

 gt; wrote in message news:kt58ju$3le$

 1@.gmane

 ...
 
 For one or two of the builds, it appears that the tail is placed 
 in front of the whiteout box, for reasons I don't understand, although I
 do 
 remember Keith saying that the order of placing whiteout and other grobs
 is 
 not determinate and has led to odd regression test results.
 
 The order in which grobs _in the same layer_ are placed is indeterminate,
 but this can be controlled by setting the 'layer property.  See
 
 http://www.lilypond.org/doc/v2.17/Documentation/notation/visibility-of-objects#index-layers
 
 for details.

thanks for pointing us to this - so the correct workaround (if one insists
on sky-lines) is:

  \layout {
\context {
  \Staff
  \override TextScript.whiteout = ##t
  \override TextScript.layer = #0
}
  }

the odd thing is you have to find a fitting integer.

in our case only the value #0 is satisfying.

#1   leads to the cropping behavior 
#-1 has the bar line drawn through the text

Eluze



--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Fw-whiteout-bug-tp148504p148505.html
Sent from the Bugs mailing list archive at Nabble.com.

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Fw: whiteout bug

2013-07-29 Thread Trevor Daniels

Eluze wrote Monday, July 29, 2013 12:42 PM

 Trevor Daniels wrote

 The order in which grobs _in the same layer_ are placed is indeterminate,
 but this can be controlled by setting the 'layer property.  See
 
 http://www.lilypond.org/doc/v2.17/Documentation/notation/visibility-of-objects#index-layers
 
 for details.
 
 thanks for pointing us to this - so the correct workaround (if one insists
 on sky-lines) is:
 
  \layout {
\context {
  \Staff
  \override TextScript.whiteout = ##t
  \override TextScript.layer = #0
}
  }
 
 the odd thing is you have to find a fitting integer.
 
 in our case only the value #0 is satisfying.
 
 #1   leads to the cropping behavior 
 #-1 has the bar line drawn through the text

Yes, although sometimes you might have to change the 'layer for other
grobs to 'make room', as Lily uses only 0 and 1 by default and
only integral values are accepted for 'layer.  So if you want something
to appear reliably above the staff lines but below the bar lines you'd
need to change the 'layer for StaffSymbol to some negative integer,
say -2, and use -1 for the grob you want to insert.

Trevor
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: Fw: whiteout bug

2013-07-29 Thread Eluze
Trevor Daniels wrote
 Eluze wrote Monday, July 29, 2013 12:42 PM
 
 Trevor Daniels wrote
 
 The order in which grobs _in the same layer_ are placed is
 indeterminate,
 but this can be controlled by setting the 'layer property.  See
 
 http://www.lilypond.org/doc/v2.17/Documentation/notation/visibility-of-objects#index-layers
 
 for details.
 
 thanks for pointing us to this - so the correct workaround (if one
 insists
 on sky-lines) is:
 
  \layout {
\context {
  \Staff
  \override TextScript.whiteout = ##t
  \override TextScript.layer = #0
}
  }
 
 the odd thing is you have to find a fitting integer.
 
 in our case only the value #0 is satisfying.
 
 #1   leads to the cropping behavior 
 #-1 has the bar line drawn through the text
 
 Yes, although sometimes you might have to change the 'layer for other
 grobs to 'make room', as Lily uses only 0 and 1 by default and
 only integral values are accepted for 'layer.  So if you want something
 to appear reliably above the staff lines but below the bar lines you'd
 need to change the 'layer for StaffSymbol to some negative integer,
 say -2, and use -1 for the grob you want to insert.

thanks - I was vaguely aware - and afraid - of that.

in worst cases you might be forced to redesign the whole layer hierarchy for
all possible grobs …

Eluze



--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Fw-whiteout-bug-tp148504p148511.html
Sent from the Bugs mailing list archive at Nabble.com.

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


whiteout bug

2013-07-28 Thread Karol Majewski
Hi,

Take look at this:

%%

\version 2.17.22

\layout {
  \context {
\Score
\override TextScript.whiteout = ##t
  }
}

right = \relative c' {
a' c d4 a c d a c d a c d _wh
a c d8 a c d4 a c d8 a c d2
}

left = \relative c {
a' c d4 a c d a c d a c d
a c d8 a c d4 a c d8 a c d2
}

\score {
  
\new PianoStaff
  
  \new Staff = right \right
  \new Staff = left \left
  
  
}

%%%

First note in the second bar is partially overlayed by whie box, which is
not what we want, do we?
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: whiteout bug

2013-07-28 Thread Phil Holmes
Karol Majewski karol.majew...@gmail.com wrote in message 
news:CAH85bB0snHDt5GtKyjWGgeOMmWkKx=wrkZ=kLx=+qL2TXx0V=a...@mail.gmail.com...

Hi,

Take look at this:

%%

\version 2.17.22

\layout {
 \context {
   \Score
   \override TextScript.whiteout = ##t
 }
}

right = \relative c' {
a' c d4 a c d a c d a c d _wh
a c d8 a c d4 a c d8 a c d2
}

left = \relative c {
a' c d4 a c d a c d a c d
a c d8 a c d4 a c d8 a c d2
}

\score {
 
   \new PianoStaff
 
 \new Staff = right \right
 \new Staff = left \left
 
 
}

%%%

First note in the second bar is partially overlayed by whie box, which is
not what we want, do we?


I wouldn't actually call it a bug.  It happens because lily now places 
objects around text based on the actual shape of the text itself.  However, 
the whiteout is purely a box, and so doesn't follow the same shape.  Simple 
fix:


\layout {
\context {
\Score
\override TextScript.whiteout = ##t
\override TextScript #'vertical-skylines = #'()
}
}



--
Phil Holmes
Bug Squad 




___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond


Re: whiteout bug

2013-07-28 Thread Eluze
Phil Holmes-2 wrote
 Karol Majewski lt;

 karol.majewsky@

 gt; wrote in message 
 news:CAH85bB0snHDt5GtKyjWGgeOMmWkKx=wrkZ=kLx=+qL2TXx0V=

 A@.gmail

 ...
 
 First note in the second bar is partially overlayed by whie box, which is
 not what we want, do we?
 
 I wouldn't actually call it a bug.  It happens because lily now places 
 objects around text based on the actual shape of the text itself. 
 However, 
 the whiteout is purely a box, and so doesn't follow the same shape. 
 Simple 
 fix:
 
 \layout {
 \context {
 \Score
 \override TextScript.whiteout = ##t
 \override TextScript #'vertical-skylines = #'()
 }
 }

sorry I can't agree - version 2.17.18 gave a quite good result for both the
letters before and after the ascender!  test4.preview.png
http://lilypond.1069038.n5.nabble.com/file/n148497/test4.preview.png  



but strangely if I change the code of the 1st staff to 

\new Staff \relative c' {
  s4 s s a' c d4  _wh
  q8 q4 q8 q2
}

the flags and stems are cropped wit 2.17.18 too!  test4-2.preview.png
http://lilypond.1069038.n5.nabble.com/file/n148497/test4-2.preview.png  

could this be a regression?

Eluze



--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/whiteout-bug-tp148494p148497.html
Sent from the Bugs mailing list archive at Nabble.com.

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond