Re: GNU Make 4.3.92 release candidate available
Am 24.10.22 um 08:59 schrieb Paul Smith: > I expect this to be the final release candidate before GNU Make 4.4. > I will probably allow for testing for about a week. (I had accidentally posted this yesterday as reply to an older thread, but it was meant as feedback to make-4.3.92.) On macOS, compiling "glob.c" gives these warnings: glob.c:823:27: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~ * glob.c:942:24: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~ * glob.c:997:39: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] new_pathv = (char **) realloc (pglob->gl_pathv, ^~~ * glob.c:1388:23: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~ * but from what Paul said in https://lists.gnu.org/archive/html/bug-make/2019-05/msg00017.html > Argh, another glob.c issue. I really need to figure out how to update > to a newer version, preferably without breaking Windows AND pulling in > 75% of gnulib stuff in the process. I assume we still have to live with these warnings? Apart from that, there is only one compiler warning: src/getopt.c:685:6: warning: add explicit braces to avoid dangling else [-Wdangling-else] else ^ A fix had been posted in https://savannah.gnu.org/bugs/?func=detailitem_id=58075. That looks like a "small effort" change to me, perhaps it can be incorporated into GNU Make 4.4? Regards, Martin
Re: GNU make 4.3.90 release candidate available: Compiler warnings on macOS
Am 20.09.22 um 20:36 schrieb Paul Smith: > A new release candidate for GNU make 4.4 is available now for download: > > 0c3daaec8c81bf72f460677ccda32364 make-4.3.90.tar.lz > 54726144a7ae0465451f8ca0740f3d1f make-4.3.90.tar.gz On macOS, compiling "glob.c" gives these warnings: glob.c:823:27: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~ * glob.c:942:24: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~ * glob.c:997:39: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] new_pathv = (char **) realloc (pglob->gl_pathv, ^~~ * glob.c:1388:23: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~ * but from what Paul said in https://lists.gnu.org/archive/html/bug-make/2019-05/msg00017.html > Argh, another glob.c issue. I really need to figure out how to update > to a newer version, preferably without breaking Windows AND pulling in > 75% of gnulib stuff in the process. I assume we still have to live with these warnings? Apart from that, there is only one compiler warning: src/getopt.c:685:6: warning: add explicit braces to avoid dangling else [-Wdangling-else] else ^ A fix had been posted in https://savannah.gnu.org/bugs/?func=detailitem_id=58075. That looks like a "small effort" change to me, perhaps it can be incorporated into GNU Make 4.4? Regards, Martin
Re: __alloca patch?
On 07.05.19 03:36, Paul Smith wrote: > On Sat, 2019-05-04 at 17:00 -0400, Jeffrey Walton wrote: >> glob.c:818:27: warning: incompatible pointer types passing 'char **' to >> parameter of type 'char *'; dereference with * >> [-Wincompatible-pointer-types] >> = (char **) realloc (pglob->gl_pathv, >> ^~~ >> * > > That's odd; realloc() is supposed to take a void* not a char* as the > first parameter. Is MacOS really so non-standard? > > > ___ > Bug-make mailing list > Bug-make@gnu.org > https://lists.gnu.org/mailman/listinfo/bug-make > No, the macOS SDKs declare realloc() as void * realloc(void *ptr, size_t size); But it seems that http://git.savannah.gnu.org/cgit/make.git/tree/lib/glob.c redefines realloc as my_malloc, which is defined locally as static char * my_realloc (p, n) char *p; unsigned int n; // ... # define realloc my_realloc Martin ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
