RE: [PATCH] Fix output-sync option on EMX - updated
Hello! Done. Thank you very much! My take on this is that I need to see the refactoring to say something intelligent about it. Ok, of course. :) Currently i have some high-priority problems here, when i have more time i'll get back to it and of course post the patch. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: [PATCH] Fix output-sync option on EMX - updated
From: Pavel Fedin p.fe...@samsung.com Cc: bug-make@gnu.org Date: Thu, 16 Jan 2014 10:03:38 +0400 Thanks, this variant is fine with me. Good. I'm waiting for it to be committed Done. In order to make it switched at runtime, i would like to refactor child_execute_job(). I have suggested this earlier, nobody replied. My take on this is that I need to see the refactoring to say something intelligent about it. ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: [PATCH] Fix output-sync option on EMX - updated
From: Pavel Fedin p.fe...@samsung.com Cc: bug-make@gnu.org Date: Wed, 15 Jan 2014 10:23:58 +0400 I have rechecked. Actually NO_OUTPUT_SYNC is defined only by handmade config.h files for DOS, VMS and Amiga. EMX uses configure script, so NO_OUTPUT_SYNC will not be defined. However, indeed, there is rational seed in what you say. Since this code actually goes to generic part, it will be useful to be able to disable this code, just in case. Please take the updated patch. I have verified it to build by supplying CPPFLAGS=-DNO_OUTPUT_SYNC to configure. Thanks, this variant is fine with me. ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
RE: [PATCH] Fix output-sync option on EMX - updated
Hello! Thanks, this variant is fine with me. Good. I'm waiting for it to be committed, since i would like to go on with merging spawn-patch. In order to make it switched at runtime, i would like to refactor child_execute_job(). I have suggested this earlier, nobody replied. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: [PATCH] Fix output-sync option on EMX
From: Pavel Fedin p.fe...@samsung.com
Date: Tue, 14 Jan 2014 11:11:35 +0400
This is part of my spawn-patch for Make. The purpose of this piece is to
add missing support for output-sync option to spawn()-based flavors
(currently only EMX).
Thanks, but does EMX support output-sync? If not, this fragment:
+ /* Divert child output if output_sync in use. */
+ if (child-output.syncout)
+{
+ if (child-output.out = 0)
+outfd = child-output.out;
+ if (child-output.err = 0)
+errfd = child-output.err;
+}
+
should be conditioned on NO_OUTPUT_SYNC. Otherwise we are breaking
the EMX build of Make.
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Re: [PATCH] Fix output-sync option on EMX
On Tue, Jan 14, 2014 at 12:41 PM, Eli Zaretskii e...@gnu.org wrote: Thanks, but does EMX support output-sync? Didn't he just say The purpose of this piece is to add missing support for output-sync option to [...] EMX? David ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: [PATCH] Fix output-sync option on EMX
From: David Boyce david.s.bo...@gmail.com Date: Tue, 14 Jan 2014 13:13:13 -0500 Cc: Pavel Fedin p.fe...@samsung.com, bug-make bug-make@gnu.org On Tue, Jan 14, 2014 at 12:41 PM, Eli Zaretskii e...@gnu.org wrote: Thanks, but does EMX support output-sync? Didn't he just say The purpose of this piece is to add missing support for output-sync option to [...] EMX? The part you replaced with ... sounds like an important qualifier to me. I also have hard time believing that these 4 lines is all it takes to support output-sync on EMX. Finally, if that is indeed what EMX needs to support output-sync, that should be tested in the EMX build, not in a Cygwin build. ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
[PATCH] Fix output-sync option on EMX - updated
Hello!
Thanks, but does EMX support output-sync? If not, this fragment:
+ /* Divert child output if output_sync in use. */
+ if (child-output.syncout)
+{
+ if (child-output.out = 0)
+outfd = child-output.out;
+ if (child-output.err = 0)
+errfd = child-output.err;
+}
+
should be conditioned on NO_OUTPUT_SYNC. Otherwise we are breaking the
EMX build of Make.
I have rechecked. Actually NO_OUTPUT_SYNC is defined only by handmade
config.h files for DOS, VMS and Amiga. EMX uses configure script, so
NO_OUTPUT_SYNC will not be defined.
However, indeed, there is rational seed in what you say. Since this code
actually goes to generic part, it will be useful to be able to disable this
code, just in case.
Please take the updated patch. I have verified it to build by supplying
CPPFLAGS=-DNO_OUTPUT_SYNC to configure.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
make-fix-output-sync-emx.diff
Description: Binary data
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
[PATCH] Fix output-sync option on EMX
Hello! This is part of my spawn-patch for Make. The purpose of this piece is to add missing support for output-sync option to spawn()-based flavors (currently only EMX). Tested together with the rest of spawn-patch under Cygwin, works fine. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia make-fix-output-sync-emx.diff Description: Binary data ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
