[bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms
Update of bug #38945 (project make): Status:None = Fixed Assigned to:None = psmith Open/Closed:Open = Closed Fixed Release:None = SCM Triage Status: Need Info = Verified ___ Follow-up Comment #5: Fixed. Thanks for the repro case! ___ Reply to this item at: http://savannah.gnu.org/bugs/?38945 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
[bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms
Follow-up Comment #4, bug #38945 (project make): Here's a minimal testcase to reproduce this bug. Put the following in Makefile (Unix or DOS linebreaks): include snippet define RULES clean:: $(RM) $(OBJS) $(OBJS:.o=.d) endef $(eval $(RULES)) Put the following in snippet (DOS linebreaks): OBJS = x86/cpu.o There must not be an empty line after OBJS in snippet, otherwise the bug will not trigger. ___ Reply to this item at: http://savannah.gnu.org/bugs/?38945 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
[bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms
Update of bug #38945 (project make): Triage Status:None = Need Info ___ Follow-up Comment #2: I'm trying to create a repro case for this. I've created a file on Linux and forced it to contain CRLF line endings but I can't get it to fail with the errors you've described. I'm not sure what you mean by a rule/prefix name, and the makefile you point to as an example case doesn't contain any rules: it's simply a long list of variable assignments. The name of that file doesn't match the error message you give, and there aren't 129 lines in that file, so that message is from a different file. Can you attach a small, simple makefile to the bug that shows the error? ___ Reply to this item at: http://savannah.gnu.org/bugs/?38945 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
[bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms
Follow-up Comment #3, bug #38945 (project make): I'm actually having a hard time making a small reproducible file... At the moment, you can easily reproduce this as: $ git clone git://git.libav.org/libav.git $ cd libav $ ./configure $ todos libavcodec/x86/Makefile $ make common.mak:65: *** missing separator. Stop. ___ Reply to this item at: http://savannah.gnu.org/bugs/?38945 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
[bug #38945] [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms
URL: http://savannah.gnu.org/bugs/?38945 Summary: [PATCH] Fix CRLF backslash-newline handing on non-WINDOWS32 platforms Project: make Submitted by: dwbuiten Submitted on: Wed 08 May 2013 11:36:31 PM GMT Severity: 3 - Normal Item Group: Bug Status: None Privacy: Public Assigned to: None Open/Closed: Open Discussion Lock: Any Component Version: SCM Operating System: POSIX-Based Fixed Release: None Triage Status: None ___ Details: Attached is a patch that will fix erroneous parsing for Makefile with CRLF line endings, and a backslash-newline before a rule/prefix name (which POSIX says should is allowed and should be ignored). Example case: http://git.libav.org/?p=libav.git;a=blob;f=libavcodec/x86/Makefile;h=f13f3e0ea8f45efb9050ff7439d7e2de108778d0;hb=HEAD# When cloned on windows with autocrlf set to true, you get the following with MSYS Make: common.mak:129: *** missing separator. Stop. Also reproducible on Linux with CRLF endings. The attached patch fixes the issue on non-WINDOWS32 platforms such as Linux and MSYS. Comments and opinions welcome! - Derek ___ File Attachments: --- Date: Wed 08 May 2013 11:36:31 PM GMT Name: 0001-Fix-CRLF-backslash-newline-handing-on-non-WINDOWS32-.patch Size: 781B By: dwbuiten Fix http://savannah.gnu.org/bugs/download.php?file_id=28051 ___ Reply to this item at: http://savannah.gnu.org/bugs/?38945 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
