[bug #62100] [PATCH] Add '--shuffle' argument support

[Paul D. Smith]

Update of bug #62100 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
Operating System:None => Any
   Fixed Release:None => SCM
   Triage Status:None => Medium Effort  


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Paul D. Smith]

Follow-up Comment #8, bug #62100 (project make):

I applied this with a few cleanups.

Thanks for your work on this!


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Fangrui Song]

Follow-up Comment #7, bug #62100 (project make):

Thanks for v7. Hope that we will have this soon in make to help these
packages: https://trofi.github.io/posts/230-when-make-j-nproc-fails.html :)


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Additional Item Attachment, bug #62100 (project make):

File name: v7-0001-Add-shuffle-argument-support.patch Size:35 KB
   




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Follow-up Comment #6, bug #62100 (project make):

Adding a v7-0001-Add-shuffle-argument-support.patch which 2 extra changes:
1. fixed 'if' indentation in src/main.c noticed by Fangrui Song
2. tweaked --help output to '--shuffle[={SEED|random|identity|reverse|none}]'
noticed by Fangrui Song


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Fangrui Song]

Follow-up Comment #5, bug #62100 (project make):

--shuffle has caught some brittle dependency issues in glibc: 
https://sourceware.org/bugzilla/show_bug.cgi?id=29167 build failures with make
--shuffle -j N

There is a coding style issue in v6. Left a comment on 
https://trofi.github.io/posts/238-new-make-shuffle-mode.html

It'd be nice to move forward with the patch. (I'd wish that bmake from NetBSD
can add this as well. I've come across quite a few issues in FreeBSD.)


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Follow-up Comment #4, bug #62100 (project make):

Caught bugs in a few upstream projects. Two nice simple examples:
- vim: https://github.com/vim/vim/pull/9978
- groff: https://savannah.gnu.org/bugs/?62084


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Follow-up Comment #3, bug #62100 (project make):

Uploaded v6-0001-Add-shuffle-argument-support.patch. It's the rebased v5
against today's make.git where a small merge conflict is fixed around added
option. Otherwise identical to v5.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Additional Item Attachment, bug #62100 (project make):

File name: v6-0001-Add-shuffle-argument-support.patch Size:35 KB
   




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Paul D. Smith]

Follow-up Comment #2, bug #62100 (project make):

Thanks Sergei.  I'll add some code review comments here today or tomorrow.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Paul D. Smith]

Update of bug #62100 (project make):

  Item Group:None => Enhancement


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Follow-up Comment #1, bug #62100 (project make):

Changes from v4: presence of `.NOTPARALLEL:` target disables shuffling as
makefile is already known to be broken in target reorder caused by -j
parallelism.

Example of real package is `netpbm`. Upstream does not plan to fix it.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

Additional Item Attachment, bug #62100 (project make):

File name: v5-0001-Add-shuffle-argument-support.patch Size:35 KB
   




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/

[bug #62100] [PATCH] Add '--shuffle' argument support

[Sergei Trofimovich]

URL:
  

 Summary: [PATCH] Add '--shuffle' argument support
 Project: make
Submitted by: slyfox
Submitted on: Wed 23 Feb 2022 07:51:47 AM UTC
Severity: 3 - Normal
  Item Group: None
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: None
Operating System: None
   Fixed Release: None
   Triage Status: None

___

Details:

The idea of the change is to introduce non-deterministic ordering
into goal and prerequisite traversal to imitate non-deterministic
ordering of 'make -j g1 g2 g3' mode.

Filing the bug to make sure it does not get lost.

The patch is against current git tree:


$ git describe
4.3-138-gfcc23a4d






___

File Attachments:


---
Date: Wed 23 Feb 2022 07:51:47 AM UTC  Name:
v4-0001-Add-shuffle-argument-support.patch  Size: 35KiB   By: slyfox



___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/