[bug #63373] make 4.4: build failure using AIX XLC 16.1

[Paul D. Smith]

Update of bug #63373 (project make):

  Status:None => Fixed  
 Assigned to:None => psmith 
 Open/Closed:Open => Closed 
   Fixed Release:None => SCM
   Triage Status:None => Small Effort   

___

Follow-up Comment #2:

Fix pushed to Git.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63373] make 4.4: build failure using AIX XLC 16.1

[Paul D. Smith]

Follow-up Comment #1, bug #63373 (project make):

Strange, I could have sworn I went through all the code and fixed this a few
months ago when Dmitry was testing builds on AIX.

Will fix, thanks for the report.


diff --git a/src/main.c b/src/main.c
index 78729de1..ba92de37 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1503,7 +1503,7 @@ main (int argc, char **argv, char **envp)

 /* If this is MAKE_RESTARTS, check to see if the "already printed
the enter statement" flag is set.  */
-if (len == 13 && memcmp (envp[i], STRING_SIZE_TUPLE
("MAKE_RESTARTS")) == 0)
+if (len == 13 && memcmp (envp[i], "MAKE_RESTARTS", 13) == 0)
   {
 if (*ep == '-')
   {



___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #63373] make 4.4: build failure using AIX XLC 16.1

[djm]

URL:
  

 Summary: make 4.4: build failure using AIX XLC 16.1
 Project: make
   Submitter: mccannd
   Submitted: Wed 16 Nov 2022 11:28:00 AM UTC
Severity: 3 - Normal
  Item Group: Build/Install
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: 4.4
Operating System: POSIX-Based
   Fixed Release: None
   Triage Status: None


___

Follow-up Comments:


---
Date: Wed 16 Nov 2022 11:28:00 AM UTC By: djm 
When using the AIX XLC V16.1 compiler to build GNU make 4.4, the following
error is observed:

source='make-4.4/src/main.c' object='src/main.o' libtool=no  
DEPDIR=.deps
depmode=xlc /bin/sh make-4.4/build-aux/depcomp  /opt/IBM/xlc/16.1.0/bin/xlc_r
-DHAVE_CONFIG_H   -Isrc -Imake-4.4/src -Ilib -Imake-4.4/lib 
-DLIBDIR=\"/opt/tools/gnumake/4.4/lib\"
-DLOCALEDIR=\"/opt/tools/gnumake/4.4/share/locale\" 
-DINCLUDEDIR=\"/opt/tools/gnumake/4.4/include\" -g -c -o src/main.o
make-4.4/src/main.c
"make-4.4/src/main.c", line 1508.78: 1506-041 (E) The invocation of macro
memcmp contains fewer arguments than are required by the macro definition.
"make-4.4/src/main.c", line 1508.26: 1506-046 (S) Syntax error.
"make-4.4/src/main.c", line 1508.26: 1506-182 (S) Arguments missing for
built-in function __memcmp.

Given that the following comment exists with STRING_SIZE_TUPLE, surely
STRING_SIZE_TUPLE should not be used with memcmp?

/* Only usable when NOT calling a macro: only use it for local functions.  */
#define STRING_SIZE_TUPLE(_s) (_s), CSTRLEN(_s)







___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/