Re: Add makefile.mak to list of default makefiles
Date: Tue, 8 Jul 2014 13:55:40 +0100
From: Jonny Grant j...@jguk.org
Cc: psm...@gnu.org, bug-make@gnu.org
On 8 July 2014 03:38, Eli Zaretskii e...@gnu.org wrote:
From: Paul Smith psm...@gnu.org
Cc: Eli Zaretskii e...@gnu.org, bug-make@gnu.org
Date: Mon, 07 Jul 2014 17:00:03 -0400
I do wonder, though, why we have both makefile and Makefile above.
Does that actually ever do anything on Windows, other than waste a bit
of time checking for the same file twice?
No.
Ok, updated patch:
--- read.c 2013-10-09 06:22:42.0 +0100
+++ read.c.new 2014-07-07 18:10:43.914952000 +0100
@@ -246,7 +246,11 @@
#ifdef _AMIGA
{ GNUmakefile, Makefile, SMakefile, 0 };
#else /* !Amiga !VMS */
+#ifdef WINDOWS32
+ { GNUmakefile, makefile, makefile.mak, 0 };
+#else
{ GNUmakefile, makefile, Makefile, 0 };
+#endif
#endif /* AMIGA */
#endif /* VMS */
register char **p = default_makefiles;
Thanks, I pushed this in your name.
Also renaming README.W32 - README_W32.txt
I didn't do anything about this part. As long as README files for
other platforms don't have .txt or .text extensions, I see no reason
why the one for Windows should.
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
On 8 July 2014 03:38, Eli Zaretskii e...@gnu.org wrote:
From: Paul Smith psm...@gnu.org
Cc: Eli Zaretskii e...@gnu.org, bug-make@gnu.org
Date: Mon, 07 Jul 2014 17:00:03 -0400
I do wonder, though, why we have both makefile and Makefile above.
Does that actually ever do anything on Windows, other than waste a bit
of time checking for the same file twice?
No.
Ok, updated patch:
--- read.c 2013-10-09 06:22:42.0 +0100
+++ read.c.new 2014-07-07 18:10:43.914952000 +0100
@@ -246,7 +246,11 @@
#ifdef _AMIGA
{ GNUmakefile, Makefile, SMakefile, 0 };
#else /* !Amiga !VMS */
+#ifdef WINDOWS32
+ { GNUmakefile, makefile, makefile.mak, 0 };
+#else
{ GNUmakefile, makefile, Makefile, 0 };
+#endif
#endif /* AMIGA */
#endif /* VMS */
register char **p = default_makefiles;
Also renaming README.W32 - README_W32.txt
Regards, Jon
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
From: Paul Smith psm...@gnu.org Cc: Eli Zaretskii e...@gnu.org, bug-make@gnu.org Date: Mon, 07 Jul 2014 02:06:54 -0400 On Mon, 2014-06-30 at 21:28 +0100, Jonny Grant wrote: I have a few, but triggered by make -f makefile.mak. So it would be quite useful GNU Make could pick up the Windows makefile extension .MAK If Eli feels this is useful for Windows implementations he can add it; however, I don't want this added for the non-Windows ports. I've never seen anyone name a makefile like this on any UNIX/POSIX system, ever. As Reinier points out, on UNIX/POSIX systems you often see .mk used as an extension, but never (IME) Makefile.mk; UNIX/POSIX environments don't rely (solely) on extensions and (again IME) have no problem understanding that files named Makefile or makefile are makefiles, even without extensions. Should we add Makefile.mk for Posix hosts and makefile.mak for Windows, then? Renaming the Windows README files is also fine with me if it's fine with Eli. My only doubt about this request is that README files for other platforms will still be called README.system. Should we rename them all? ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
On Mon, Jul 7, 2014 at 4:59 PM, Eli Zaretskii e...@gnu.org wrote: From: Paul Smith psm...@gnu.org Cc: Eli Zaretskii e...@gnu.org, bug-make@gnu.org Date: Mon, 07 Jul 2014 02:06:54 -0400 On Mon, 2014-06-30 at 21:28 +0100, Jonny Grant wrote: I have a few, but triggered by make -f makefile.mak. So it would be quite useful GNU Make could pick up the Windows makefile extension .MAK If Eli feels this is useful for Windows implementations he can add it; however, I don't want this added for the non-Windows ports. I've never seen anyone name a makefile like this on any UNIX/POSIX system, ever. As Reinier points out, on UNIX/POSIX systems you often see .mk used as an extension, but never (IME) Makefile.mk; UNIX/POSIX environments don't rely (solely) on extensions and (again IME) have no problem understanding that files named Makefile or makefile are makefiles, even without extensions. Should we add Makefile.mk for Posix hosts and makefile.mak for Windows, then? Please do not (for Posix) For instance we use a lot of include of piece for our Makefile(s).. all these pieces are indeed call foo.mk but these files are fragment and are not to be run directly. Makefile.mk is at best a pleonasm, and if someone really, really likes that, it is already supported via -f Makefile.mk Renaming the Windows README files is also fine with me if it's fine with Eli. My only doubt about this request is that README files for other platforms will still be called README.system. Should we rename them all? Why inflict some vestigial CP/M 'feature' on the rest of the world ? Norbert ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
Date: Mon, 7 Jul 2014 17:42:18 +0200 From: Norbert Thiebaud nthieb...@gmail.com Cc: psm...@gnu.org, j...@jguk.org, bug-make@gnu.org bug-make@gnu.org Renaming the Windows README files is also fine with me if it's fine with Eli. My only doubt about this request is that README files for other platforms will still be called README.system. Should we rename them all? Why inflict some vestigial CP/M 'feature' on the rest of the world ? That's exactly what I was asking. ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
I believe it's theoretically possible to have a case-sensitive
filesystem on Windows though it would primarily benefit masochists.
On Mon, Jul 7, 2014 at 5:00 PM, Paul Smith psm...@gnu.org wrote:
On Mon, 2014-07-07 at 21:15 +0100, Jonny Grant wrote:
+#ifdef WINDOWS32
+ { GNUmakefile, makefile, Makefile, makefile.mak, 0 };
+#else
This is OK with me. I definitely don't want to add Makefile.mk to the
UNIX/POSIX side; that's not something anyone ever uses anyway.
I do wonder, though, why we have both makefile and Makefile above.
Does that actually ever do anything on Windows, other than waste a bit
of time checking for the same file twice?
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
From: Paul Smith psm...@gnu.org Cc: Eli Zaretskii e...@gnu.org, bug-make@gnu.org Date: Mon, 07 Jul 2014 17:00:03 -0400 I do wonder, though, why we have both makefile and Makefile above. Does that actually ever do anything on Windows, other than waste a bit of time checking for the same file twice? No. ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
On Mon Jun 30 21:28:43 2014, j...@jguk.org (Jonny Grant) wrote: Hi Eli I have a few, but triggered by make -f makefile.mak. So it would be quite useful GNU Make could pick up the Windows makefile extension .MAK On non-Windows platforms I've seen .mk quite a few times, but never .mak. I would also rename README.W32 to be README_W32.txt Seconded. Regards, Jon -- Reinier Post ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
Hi Eli I have a few, but triggered by make -f makefile.mak. So it would be quite useful GNU Make could pick up the Windows makefile extension .MAK I would also rename README.W32 to be README_W32.txt Regards, Jon On 28 June 2014 15:11, Eli Zaretskii e...@gnu.org wrote: Date: Sat, 28 Jun 2014 12:12:32 +0100 From: Jonny Grant j...@jguk.org Rationale, on Windows makefiles often have this name for other make programs. In addition it is easier to associate with an editor because it has an extension. FWIW, I have only one makefile.mak on my system, and it seems to be related to Borland Make, whose makefile language is quite incompatible with that of GNU Make. Aren't we doing our users a dis-service by this change? ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
Add makefile.mak to list of default makefiles
Hello Paul
Could the following change be added please.
Rationale, on Windows makefiles often have this name for other make
programs. In addition it is easier to associate with an editor because
it has an extension.
I am not a member of this list, so could I ask to keep my email
address included in any replies.
Regards, Jon
--- read.c 2013-10-09 06:22:42.0 +0100
+++ read.c.new 2014-06-27 11:28:13.825182400 +0100
@@ -246,7 +246,7 @@
#ifdef _AMIGA
{ GNUmakefile, Makefile, SMakefile, 0 };
#else /* !Amiga !VMS */
-{ GNUmakefile, makefile, Makefile, 0 };
+{ GNUmakefile, makefile, Makefile, makefile.mak, 0 };
#endif /* AMIGA */
#endif /* VMS */
register char **p = default_makefiles;
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Re: Add makefile.mak to list of default makefiles
Date: Sat, 28 Jun 2014 12:12:32 +0100 From: Jonny Grant j...@jguk.org Rationale, on Windows makefiles often have this name for other make programs. In addition it is easier to associate with an editor because it has an extension. FWIW, I have only one makefile.mak on my system, and it seems to be related to Borland Make, whose makefile language is quite incompatible with that of GNU Make. Aren't we doing our users a dis-service by this change? ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make
