Re: [Bug-wget] Fix: Large files in WARC

[Giuseppe Scrivano]

Gijs van Tulder gvtul...@gmail.com writes:

 Hi,

 Another small problem in the WARC section: wget crashes with a
 segmentation fault if you have WARC output enabled and try to download
 a file larger than 2GB. I think this is because of the size_t, ftell
 and fseek in warc.c.

 The attached patch changes the references from size_t to off_t, ftell
 to ftello, fseek to fseeko. On my 64-bit system this seemed to fix the
 problem (but I'm not an expert in these matters, so maybe this doesn't
 hold for 32-bit systems).

Thanks, pushed!

Giuseppe

Re: [Bug-wget] Fix: Large files in WARC

[Giuseppe Scrivano]

Ángel González keis...@gmail.com writes:

 You would also need
  #define _FILE_OFFSET_BITS 64
 but that seems already handled by configure.
 I'm not sure if that would work for 32bit Windows, though.

_FILE_OFFSET_BITS is defined by the AC_SYS_LARGEFILE macro in the
configure.ac file so we haven't to worry about it.

Cheers,
Giuseppe