[Bug-wget] files changed to directories!

2013-10-05 Thread e-letter
Readers,

Just learned an interesting observation: navigated to a directory
containing some audio files (mp3, ogg, etc.)

Activated the command:

wget -r -A *.mp3 http://url/to/mp3/files

After download completed, some the majority mp3 files became empty
directories, but curiously a minor few (estimate 10 %) remained as
audio files:

ls showed

audio1.mp3 became audio1.mp3/

The moral, be careful fellow novices! :)



[Bug-wget] bug 21693

2013-10-05 Thread SEITAZ

Hi All,

I want to give it a go in supporting wget, I'm dooing c for some years 
now and I thought I give the gnu/fsf ide a shot ;)


Just couple of questions.

Now.. I've found something small to work on, namely bug 21693, which is 
scheduled for release 1.13.


I've got the source from git, got it build, and:
# src/wget --version
GNU Wget 1.14.84-7e85 built on linux-gnu.

So the version moved to 1.14.x but the bug from 1.13 is still open, is 
it? If it realy is please sign me up for it.


Thanks,
Pawel



Re: [Bug-wget] bug 21693

2013-10-05 Thread Darshit Shah
Hi Pawel,

Glad that you would like to contribute to GNU Wget.
The bug that you have mentioned, #21693 seems to have been fixed by Micah
himself. The comments state that a patch was applied through commit edd30.

You should try and test whether the bug still exists or not. Try going
through the details for fnmatch() and see if you can make the code fail. If
so, please create a test for the same and fix it.

In case the bug is already fixed, please look at a couple of other open
bugs, and try fixing those. The bug tracker hasn't been updated in a while
and may not be up-to-date.

Do remember, that in case you do submit a non-trivial patch (10 lines),
you will be required to submit Copyright Assignment to FSF before your
patch can be merged. Giuseppe, the maintainer can fill you in on those
details as and when required.

BTW, Wget v1.14 has been out for nearly a year now.



On Sat, Oct 5, 2013 at 9:15 PM, SEITAZ sei...@wlubuskiem.pl wrote:

 Hi All,

 I want to give it a go in supporting wget, I'm dooing c for some years now
 and I thought I give the gnu/fsf ide a shot ;)

 Just couple of questions.

 Now.. I've found something small to work on, namely bug 21693, which is
 scheduled for release 1.13.

 I've got the source from git, got it build, and:
 # src/wget --version
 GNU Wget 1.14.84-7e85 built on linux-gnu.

 So the version moved to 1.14.x but the bug from 1.13 is still open, is it?
 If it realy is please sign me up for it.

 Thanks,
 Pawel




-- 
Thanking You,
Darshit Shah


Re: [Bug-wget] bug 21693

2013-10-05 Thread SEITAZ

Ok, thanks for the clues.
Will take a look.

Pawel

On 05.10.2013 20:42, Darshit Shah wrote:

Hi Pawel,

Glad that you would like to contribute to GNU Wget.
The bug that you have mentioned, #21693 seems to have been fixed by 
Micah himself. The comments state that a patch was applied through 
commit edd30.


You should try and test whether the bug still exists or not. Try going 
through the details for fnmatch() and see if you can make the code 
fail. If so, please create a test for the same and fix it.


In case the bug is already fixed, please look at a couple of other 
open bugs, and try fixing those. The bug tracker hasn't been updated 
in a while and may not be up-to-date.


Do remember, that in case you do submit a non-trivial patch (10 
lines), you will be required to submit Copyright Assignment to FSF 
before your patch can be merged. Giuseppe, the maintainer can fill you 
in on those details as and when required.


BTW, Wget v1.14 has been out for nearly a year now.



On Sat, Oct 5, 2013 at 9:15 PM, SEITAZ sei...@wlubuskiem.pl 
mailto:sei...@wlubuskiem.pl wrote:


Hi All,

I want to give it a go in supporting wget, I'm dooing c for some
years now and I thought I give the gnu/fsf ide a shot ;)

Just couple of questions.

Now.. I've found something small to work on, namely bug 21693,
which is scheduled for release 1.13.

I've got the source from git, got it build, and:
# src/wget --version
GNU Wget 1.14.84-7e85 built on linux-gnu.

So the version moved to 1.14.x but the bug from 1.13 is still
open, is it? If it realy is please sign me up for it.

Thanks,
Pawel




--
Thanking You,
Darshit Shah