Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

[Matthew White]

Hi Giuseppe,

On Sun, 25 Sep 2016 19:52:18 +0200
Giuseppe Scrivano  wrote:

> Hi Matthew,
> 
> Matthew White  writes:
> 
> > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, 
> > contrib/check-hard is ok]
> >
> > This implements the auto-processing of Metalink files part of a 
> > "Content-Type: application/metalink4+xml" header answer.
> >
> > e.g.:
> > $ wget --metalink-over-http \
> >--metalink-index=inf \
> >[--content-disposition \]
> >[--trust-server-names \]
> >[--header="Accept: */*,application/metalink4+xml" \]
> >
> >
> > The following description is verbatim from the patch:
> > -
> > Process the Content-Type header, identify an application/metalink4+xml
> > file.  The Content-Disposition could provide an alternate name through
> > the "filename" field for the metalink xml file.  Respectively, the cli
> > options --metalink-over-http and --content-disposition are required.
> >
> > When Metalink/XML auto-processing, to use the Content-Disposition's
> > filename, the cli option --trust-server-names is also required.
> > -
> 
> this looks fine to me as well.
> 
> Could you please re-send the updated series?

You may find the series of patches in my branch 
https://github.com/mehw/wget/tree/metalink_staging .

There's a new Metalink/XML v3 python class:
* testenv/misc/metalinkv3_xml.py

I still have to update the NEWS file.

> 
> I had some problems applying your patches, as some comments from the
> emails got into the patch itself, could you try with git send-email?

About `git send-email`, what Subject, In-Reply-to, and References should be 
used to post the series of patches?

What about the gpg signature?

> 
> Thanks,
> Giuseppe

Regards,
Matthew

-- 
Matthew White 


pgp266kkL8kuq.pgp
Description: PGP signature

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

[Giuseppe Scrivano]

Darshit Shah  writes:

> Apart from the patch format, the patch itself looks good.
>
> @Giuseppe: We will require Copyright assignments for Piotr right? This
> patch may be small, but there are a couple others in the pipeline.

yes, I think we will need that.  The sum of all the contributions cannot
be considered trivial.

Regards,
Giuseppe

Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

[Giuseppe Scrivano]

Hi Matthew,

Matthew White  writes:

> [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, 
> contrib/check-hard is ok]
>
> This implements the auto-processing of Metalink files part of a 
> "Content-Type: application/metalink4+xml" header answer.
>
> e.g.:
> $ wget --metalink-over-http \
>--metalink-index=inf \
>[--content-disposition \]
>[--trust-server-names \]
>[--header="Accept: */*,application/metalink4+xml" \]
>
>
> The following description is verbatim from the patch:
> -
> Process the Content-Type header, identify an application/metalink4+xml
> file.  The Content-Disposition could provide an alternate name through
> the "filename" field for the metalink xml file.  Respectively, the cli
> options --metalink-over-http and --content-disposition are required.
>
> When Metalink/XML auto-processing, to use the Content-Disposition's
> filename, the cli option --trust-server-names is also required.
> -

this looks fine to me as well.

Could you please re-send the updated series?

I had some problems applying your patches, as some comments from the
emails got into the patch itself, could you try with git send-email?

Thanks,
Giuseppe