Re: [Bug-wget] [PATCH 21/27] New option --metalink-index to process Metalink application/metalink4+xml

[Matthew White]

Hi Giuseppe,

On Thu, 29 Sep 2016 22:31:21 +0200
Giuseppe Scrivano  wrote:

> Hi Matthew,
> 
> Matthew White  writes:
> 
> > diff --git a/src/init.c b/src/init.c
> > index 6729c5a..26f3886 100644
> > --- a/src/init.c
> > +++ b/src/init.c
> > @@ -248,6 +248,7 @@ static const struct {
> >{ "login",_user,  cmd_string },/* 
> > deprecated*/
> >{ "maxredirect",  _redirect,  cmd_number },
> >  #ifdef HAVE_METALINK
> > +  { "metalinkindex",_index, cmd_number_inf },
> >{ "metalinkoverhttp", _over_http, cmd_boolean },
> >  #endif
> >{ "method",   ,cmd_string_uppercase },
> > @@ -385,6 +386,10 @@ defaults (void)
> >   bit pattern will be the least of the implementors' worries.  */
> >xzero (opt);
> >  
> > +#ifdef HAVE_METALINK
> > +  opt.metalink_index = -1;
> > +#endif
> > +
> >opt.cookies = true;
> >opt.verbose = -1;
> >opt.ntry = 20;
> > diff --git a/src/main.c b/src/main.c
> > index ac6ee2c..d48e3b2 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -354,6 +354,7 @@ static struct cmdline_option option_data[] =
> >  { "rejected-log", 0, OPT_VALUE, "rejectedlog", -1 },
> >  { "max-redirect", 0, OPT_VALUE, "maxredirect", -1 },
> >  #ifdef HAVE_METALINK
> > +{ "metalink-index", 0, OPT_VALUE, "metalinkindex", -1 },
> >  { "metalink-over-http", 0, OPT_BOOLEAN, "metalinkoverhttp", -1 },
> >  #endif
> >  { "method", 0, OPT_VALUE, "method", -1 },
> > @@ -714,6 +715,8 @@ Download:\n"),
> >  N_("\
> > --keep-badhash  keep files with checksum mismatch 
> > (append .badhash)\n"),
> >  N_("\
> > +   --metalink-index=NUMBER Metalink application/metalink4+xml 
> > metaurl ordinal NUMBER\n"),
> 
> "Metalink" should be lower case.

With "Metalink" I meant the standard/protocol Metalink/HTTP, the HTTP should be 
implied by application/metalink4+xml, hence it is missing.

Once the Patch v2 26/27 
http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00157.html is applied, 
"Metalink" may refer to a plain HTTP header too of application/metalink4+xml 
type.

This is why I prefer to use "Metalink" and not "Metalink/HTTP".

> 
> Giuseppe

Regards,
Matthew

-- 
Matthew White 


pgpRM24rXOSHZ.pgp
Description: PGP signature

Re: [Bug-wget] [PATCH v2 01/27] new Metalink functionalities

[Matthew White]

Hi Giuseppe,

On Thu, 29 Sep 2016 22:46:52 +0200
Giuseppe Scrivano  wrote:

> Hi Matthew,
> 
> Matthew White  writes:
> 
> > Series of patches to implement new Metalink functionalities.
> >
> > In response to Giuseppe 
> > http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00127.html , here you 
> > find my revised series of patches.
> >
> > Posting with `git send-email` as requested.
> >
> > This series of patches supersedes the following:
> 
> thanks for your work!  I went quickly through it and it seems you
> addressed the reported issues, I will give it another look tomorrow or
> during the weekend.
> Given the size of the changes, I'll wait for other comments before
> merging it though.
> If there are no other comments, I will amend the minor things I reported
> before merging the series without the need of a v3.

Thanks Giuseppe.

In the meantime, I'm keeping my metalink_staging branch updated with new fixes.

https://github.com/mehw/wget/tree/metalink_staging

> 
> Regards,
> Giuseppe

Regards,
Matthew

-- 
Matthew White 


pgpdCSJyDBN5W.pgp
Description: PGP signature

Re: [Bug-wget] [PATCH v2 01/27] new Metalink functionalities

[Giuseppe Scrivano]

Hi Matthew,

Matthew White  writes:

> Series of patches to implement new Metalink functionalities.
>
> In response to Giuseppe 
> http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00127.html , here you 
> find my revised series of patches.
>
> Posting with `git send-email` as requested.
>
> This series of patches supersedes the following:

thanks for your work!  I went quickly through it and it seems you
addressed the reported issues, I will give it another look tomorrow or
during the weekend.
Given the size of the changes, I'll wait for other comments before
merging it though.
If there are no other comments, I will amend the minor things I reported
before merging the series without the need of a v3.

Regards,
Giuseppe

Re: [Bug-wget] [PATCH 27/27] New: Metalink/XML v3 python class, update tests to use this class

[Giuseppe Scrivano]

Matthew White  writes:

> * NEWS: Mention the Metalink/XML v3 python class
> * testenv/misc/metalinkv3_xml.py: New Metalink/XML v3 python class

I think this should not be included.  NEWS is for users to know what
changed in a new release, we don't add internal changes.

Giuseppe

Re: [Bug-wget] [PATCH 21/27] New option --metalink-index to process Metalink application/metalink4+xml

[Giuseppe Scrivano]

Hi Matthew,

Matthew White  writes:

> diff --git a/src/init.c b/src/init.c
> index 6729c5a..26f3886 100644
> --- a/src/init.c
> +++ b/src/init.c
> @@ -248,6 +248,7 @@ static const struct {
>{ "login",_user,  cmd_string },/* deprecated*/
>{ "maxredirect",  _redirect,  cmd_number },
>  #ifdef HAVE_METALINK
> +  { "metalinkindex",_index, cmd_number_inf },
>{ "metalinkoverhttp", _over_http, cmd_boolean },
>  #endif
>{ "method",   ,cmd_string_uppercase },
> @@ -385,6 +386,10 @@ defaults (void)
>   bit pattern will be the least of the implementors' worries.  */
>xzero (opt);
>  
> +#ifdef HAVE_METALINK
> +  opt.metalink_index = -1;
> +#endif
> +
>opt.cookies = true;
>opt.verbose = -1;
>opt.ntry = 20;
> diff --git a/src/main.c b/src/main.c
> index ac6ee2c..d48e3b2 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -354,6 +354,7 @@ static struct cmdline_option option_data[] =
>  { "rejected-log", 0, OPT_VALUE, "rejectedlog", -1 },
>  { "max-redirect", 0, OPT_VALUE, "maxredirect", -1 },
>  #ifdef HAVE_METALINK
> +{ "metalink-index", 0, OPT_VALUE, "metalinkindex", -1 },
>  { "metalink-over-http", 0, OPT_BOOLEAN, "metalinkoverhttp", -1 },
>  #endif
>  { "method", 0, OPT_VALUE, "method", -1 },
> @@ -714,6 +715,8 @@ Download:\n"),
>  N_("\
> --keep-badhash  keep files with checksum mismatch (append 
> .badhash)\n"),
>  N_("\
> +   --metalink-index=NUMBER Metalink application/metalink4+xml 
> metaurl ordinal NUMBER\n"),

"Metalink" should be lower case.

Giuseppe

[Bug-wget] [bug #49226] Add possibility to append to existing WARC file

[anonymous]

URL:
  

 Summary: Add possibility to append to existing WARC file
 Project: GNU Wget
Submitted by: None
Submitted on: Thu 29 Sep 2016 07:40:36 PM UTC
Category: Feature Request
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
 Originator Name: sirex
Originator Email: sire...@gmail.com
 Open/Closed: Open
 Discussion Lock: Any
 Release: None
Operating System: None
 Reproducibility: None
   Fixed Release: None
 Planned Release: None
  Regression: None
   Work Required: None
  Patch Included: None

___

Details:

Currently wget always overwrites WARC file even if one already exists.

It would be great if wget could append to existing WARC file instead of
overwriting it.




___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

[Matthew White]

Hi Giuseppe,

On Mon, 26 Sep 2016 10:23:31 +0200
Giuseppe Scrivano  wrote:

> Hi,
> 
> Matthew White  writes:
> 
> >> Could you please re-send the updated series?
> >
> > You may find the series of patches in my branch 
> > https://github.com/mehw/wget/tree/metalink_staging .
> 
> it works for me, I will take a look soon at them.

I'm keeping the branch updated and rebased on the latest Savannah's master.

> 
> >
> > There's a new Metalink/XML v3 python class:
> > * testenv/misc/metalinkv3_xml.py
> >
> > I still have to update the NEWS file.
> >
> >> 
> >> I had some problems applying your patches, as some comments from the
> >> emails got into the patch itself, could you try with git send-email?
> >
> > About `git send-email`, what Subject, In-Reply-to, and References should be 
> > used to post the series of patches?
> 
> you could use the subject to tag the new version of the series: like
> "PATCH v2".  In-reply-to and References should be empty for a new
> version of a patch series.  They are more helpful if you are replying to
> a single message.

Ok, thanks.

Series of patches posted with `git send-email`.

[PATCH v2 01/27] new Metalink functionalities:
http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00133.html

> 
> 
> > What about the gpg signature?
> 
> I have not tried that, but I guess git send-email should be able to keep
> signed commits.  At least if the patches are applied to the same commit
> and the checksum is not changed.

Thanks again for this tip.

> 
> Thanks,
> Giuseppe

Regards,
Matthew

-- 
Matthew White 


pgpaiRwBR5nFu.pgp
Description: PGP signature

[Bug-wget] Digest Authentication Support in wget

[Osmani Rosado Falcon]

Hello,

I connect to internet through a digest proxy. According to wget manual 
the authentication is basic in wget. I need digest authentication 
support in wget because many applications use it as back end. I known 
that curl support digest authentication but curl not supply all my 
needs. Do you will add this feature in future releases.


Thanks,
Osmani

--
Osmani Rosado Falcón
Lic en Ciencia de la Computación

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

[Dale R. Worley]

Piotr  writes:
> I would like to avoid forcing users to hack like this ;).
> Wget should print to std* when in fg and print to wget.log when in bg, no 
> matter how user gets there.
> I don't think getpgrp() == tcgetpgrp(STDOUT_FILENO) is heavy and should 
> probaby be ok to check it when printing lines.

That makes sense, though I'd be careful to check for errors returned
from tcgetpgrp().

Dale